From: Chris Ball <cjb@laptop.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] mmc: sh_mobile_sdhi: support modular mmc-core with non-standard hotplug
Date: Fri, 16 Mar 2012 12:22:23 -0400 [thread overview]
Message-ID: <87fwd8bjnk.fsf@laptop.org> (raw)
In-Reply-To: <CANqRtoQ8GSmX5U-twQjKmHcBv18RBHO_YW8DqBW8myOauebufg@mail.gmail.com> (Magnus Damm's message of "Fri, 9 Mar 2012 22:51:21 +0900")
Hi,
On Fri, Mar 09 2012, Magnus Damm wrote:
> On Fri, Mar 9, 2012 at 6:16 PM, Guennadi Liakhovetski
> <g.liakhovetski@gmx.de> wrote:
>> Currently if a platform wants to implement a non-standard card-detection
>> method, it would need to call tmio_mmc_cd_wakeup(), which is an inline
>> function, calling mmc_detect_change(). For this the platform would have
>> to link mmc_core statically into the kernel, losing the ability to build
>> it as a module. This patch adds a callback to the sh_mobile_sdhi driver,
>> which eliminates this dependency.
>>
>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
> Looks good to me, thanks for this!
>
> Acked-by: Magnus Damm <damm@opensource.se>
Pushed to mmc-next for 3.4, thanks.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
WARNING: multiple messages have this Message-ID (diff)
From: Chris Ball <cjb@laptop.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] mmc: sh_mobile_sdhi: support modular mmc-core with non-standard hotplug
Date: Fri, 16 Mar 2012 16:22:23 +0000 [thread overview]
Message-ID: <87fwd8bjnk.fsf@laptop.org> (raw)
In-Reply-To: <CANqRtoQ8GSmX5U-twQjKmHcBv18RBHO_YW8DqBW8myOauebufg@mail.gmail.com> (Magnus Damm's message of "Fri, 9 Mar 2012 22:51:21 +0900")
Hi,
On Fri, Mar 09 2012, Magnus Damm wrote:
> On Fri, Mar 9, 2012 at 6:16 PM, Guennadi Liakhovetski
> <g.liakhovetski@gmx.de> wrote:
>> Currently if a platform wants to implement a non-standard card-detection
>> method, it would need to call tmio_mmc_cd_wakeup(), which is an inline
>> function, calling mmc_detect_change(). For this the platform would have
>> to link mmc_core statically into the kernel, losing the ability to build
>> it as a module. This patch adds a callback to the sh_mobile_sdhi driver,
>> which eliminates this dependency.
>>
>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
> Looks good to me, thanks for this!
>
> Acked-by: Magnus Damm <damm@opensource.se>
Pushed to mmc-next for 3.4, thanks.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-03-16 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 14:12 [PATCH] mmc: sh_mobile_sdhi: support modular mmc-core with non-standard hotplug Guennadi Liakhovetski
2012-02-27 14:12 ` Guennadi Liakhovetski
2012-03-09 9:16 ` [PATCH v2] " Guennadi Liakhovetski
2012-03-09 9:16 ` Guennadi Liakhovetski
2012-03-09 13:51 ` Magnus Damm
2012-03-09 13:51 ` Magnus Damm
2012-03-16 16:22 ` Chris Ball [this message]
2012-03-16 16:22 ` Chris Ball
2012-03-16 3:18 ` Chris Ball
2012-03-16 3:18 ` Chris Ball
2012-03-16 9:27 ` Guennadi Liakhovetski
2012-03-16 9:27 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwd8bjnk.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.