From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: David Gibson <dwg@au1.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, mgorman@suse.de,
kamezawa.hiroyu@jp.fujitsu.com, dhillf@gmail.com,
aarcange@redhat.com, mhocko@suse.cz, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH -V2 0/9] memcg: add HugeTLB resource tracking
Date: Sun, 04 Mar 2012 23:39:23 +0530 [thread overview]
Message-ID: <87fwdodyr0.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120302032853.GB2728@truffala.fritz.box>
On Fri, 2 Mar 2012 14:28:53 +1100, David Gibson <dwg@au1.ibm.com> wrote:
> On Thu, Mar 01, 2012 at 02:40:29PM -0800, Andrew Morton wrote:
> > On Thu, 1 Mar 2012 14:46:11 +0530
> > "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> >
> > > This patchset implements a memory controller extension to control
> > > HugeTLB allocations. It is similar to the existing hugetlb quota
> > > support in that, the limit is enforced at mmap(2) time and not at
> > > fault time. HugeTLB's quota mechanism limits the number of huge pages
> > > that can allocated per superblock.
> > >
> > > For shared mappings we track the regions mapped by a task along with the
> > > memcg. We keep the memory controller charged even after the task
> > > that did mmap(2) exits. Uncharge happens during truncate. For Private
> > > mappings we charge and uncharge from the current task cgroup.
> >
> > I haven't begin to get my head around this yet, but I'd like to draw
> > your attention to https://lkml.org/lkml/2012/2/15/548. That fix has
> > been hanging around for a while, but I haven't done anything with it
> > yet because I don't like its additional blurring of the separation
> > between hugetlb core code and hugetlbfs. I want to find time to sit
> > down and see if the fix can be better architected but haven't got
> > around to that yet.
>
> So.. that version of the fix I specifically rebuilt to address your
> concerns about that blurring - in fact I think it reduces the current
> layer blurring. I haven't had any reply - what problems do see it as
> still having?
>
https://lkml.org/lkml/2012/2/16/179 ?
That is a serious issue isn't it ?
-aneesh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: David Gibson <dwg@au1.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, mgorman@suse.de,
kamezawa.hiroyu@jp.fujitsu.com, dhillf@gmail.com,
aarcange@redhat.com, mhocko@suse.cz, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH -V2 0/9] memcg: add HugeTLB resource tracking
Date: Sun, 04 Mar 2012 23:39:23 +0530 [thread overview]
Message-ID: <87fwdodyr0.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120302032853.GB2728@truffala.fritz.box>
On Fri, 2 Mar 2012 14:28:53 +1100, David Gibson <dwg@au1.ibm.com> wrote:
> On Thu, Mar 01, 2012 at 02:40:29PM -0800, Andrew Morton wrote:
> > On Thu, 1 Mar 2012 14:46:11 +0530
> > "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> >
> > > This patchset implements a memory controller extension to control
> > > HugeTLB allocations. It is similar to the existing hugetlb quota
> > > support in that, the limit is enforced at mmap(2) time and not at
> > > fault time. HugeTLB's quota mechanism limits the number of huge pages
> > > that can allocated per superblock.
> > >
> > > For shared mappings we track the regions mapped by a task along with the
> > > memcg. We keep the memory controller charged even after the task
> > > that did mmap(2) exits. Uncharge happens during truncate. For Private
> > > mappings we charge and uncharge from the current task cgroup.
> >
> > I haven't begin to get my head around this yet, but I'd like to draw
> > your attention to https://lkml.org/lkml/2012/2/15/548. That fix has
> > been hanging around for a while, but I haven't done anything with it
> > yet because I don't like its additional blurring of the separation
> > between hugetlb core code and hugetlbfs. I want to find time to sit
> > down and see if the fix can be better architected but haven't got
> > around to that yet.
>
> So.. that version of the fix I specifically rebuilt to address your
> concerns about that blurring - in fact I think it reduces the current
> layer blurring. I haven't had any reply - what problems do see it as
> still having?
>
https://lkml.org/lkml/2012/2/16/179 ?
That is a serious issue isn't it ?
-aneesh
next prev parent reply other threads:[~2012-03-04 18:09 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 9:16 [PATCH -V2 0/9] memcg: add HugeTLB resource tracking Aneesh Kumar K.V
2012-03-01 9:16 ` Aneesh Kumar K.V
2012-03-01 9:16 ` [PATCH -V2 1/9] mm: move hugetlbfs region tracking function to common code Aneesh Kumar K.V
2012-03-01 9:16 ` Aneesh Kumar K.V
[not found] ` <1330593380-1361-2-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-01 22:33 ` Andrew Morton
2012-03-01 22:33 ` Andrew Morton
2012-03-01 22:33 ` Andrew Morton
[not found] ` <20120301143345.7e928efe.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-03-04 17:37 ` Aneesh Kumar K.V
2012-03-04 17:37 ` Aneesh Kumar K.V
2012-03-04 17:37 ` Aneesh Kumar K.V
2012-03-01 9:16 ` [PATCH -V2 2/9] mm: Update region function to take new data arg Aneesh Kumar K.V
2012-03-01 9:16 ` Aneesh Kumar K.V
2012-03-01 9:16 ` [PATCH -V2 3/9] hugetlbfs: Use the generic region API and drop local one Aneesh Kumar K.V
2012-03-01 9:16 ` Aneesh Kumar K.V
2012-03-01 9:16 ` [PATCH -V2 4/9] memcg: Add non reclaim resource tracking to memcg Aneesh Kumar K.V
2012-03-01 9:16 ` Aneesh Kumar K.V
2012-03-02 8:38 ` KAMEZAWA Hiroyuki
2012-03-02 8:38 ` KAMEZAWA Hiroyuki
[not found] ` <20120302173816.9796f243.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-03-04 18:07 ` Aneesh Kumar K.V
2012-03-04 18:07 ` Aneesh Kumar K.V
2012-03-04 18:07 ` Aneesh Kumar K.V
[not found] ` <87ipikdyud.fsf-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-08 5:56 ` KAMEZAWA Hiroyuki
2012-03-08 5:56 ` KAMEZAWA Hiroyuki
2012-03-08 5:56 ` KAMEZAWA Hiroyuki
2012-03-08 11:48 ` Aneesh Kumar K.V
2012-03-08 11:48 ` Aneesh Kumar K.V
2012-03-01 9:16 ` [PATCH -V2 5/9] hugetlbfs: Add memory controller support for shared mapping Aneesh Kumar K.V
2012-03-01 9:16 ` Aneesh Kumar K.V
2012-03-01 9:16 ` [PATCH -V2 6/9] hugetlbfs: Add memory controller support for private mapping Aneesh Kumar K.V
2012-03-01 9:16 ` Aneesh Kumar K.V
[not found] ` <1330593380-1361-7-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-05-17 23:16 ` Darrick J. Wong
2012-05-17 23:16 ` Darrick J. Wong
2012-05-17 23:16 ` Darrick J. Wong
2012-03-01 9:16 ` [PATCH -V2 7/9] memcg: track resource index in cftype private Aneesh Kumar K.V
2012-03-01 9:16 ` Aneesh Kumar K.V
2012-03-01 9:16 ` [PATCH -V2 8/9] hugetlbfs: Add memcg control files for hugetlbfs Aneesh Kumar K.V
2012-03-01 9:16 ` Aneesh Kumar K.V
2012-03-01 9:16 ` [PATCH -V2 9/9] memcg: Add memory controller documentation for hugetlb management Aneesh Kumar K.V
2012-03-01 9:16 ` Aneesh Kumar K.V
2012-03-01 22:40 ` [PATCH -V2 0/9] memcg: add HugeTLB resource tracking Andrew Morton
2012-03-01 22:40 ` Andrew Morton
[not found] ` <20120301144029.545a5589.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-03-02 3:28 ` David Gibson
2012-03-02 3:28 ` David Gibson
2012-03-02 3:28 ` David Gibson
2012-03-04 18:09 ` Aneesh Kumar K.V [this message]
2012-03-04 18:09 ` Aneesh Kumar K.V
[not found] ` <87fwdodyr0.fsf-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-06 2:38 ` David Gibson
2012-03-06 2:38 ` David Gibson
2012-03-06 2:38 ` David Gibson
2012-03-04 19:15 ` Aneesh Kumar K.V
2012-03-04 19:15 ` Aneesh Kumar K.V
2012-03-05 13:56 ` Hillf Danton
2012-03-05 13:56 ` Hillf Danton
2012-03-06 14:05 ` Aneesh Kumar K.V
2012-03-06 14:05 ` Aneesh Kumar K.V
[not found] ` <1330593380-1361-1-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-02 5:48 ` KAMEZAWA Hiroyuki
2012-03-02 5:48 ` KAMEZAWA Hiroyuki
2012-03-02 5:48 ` KAMEZAWA Hiroyuki
2012-03-04 18:14 ` Aneesh Kumar K.V
2012-03-04 18:14 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwdodyr0.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=dhillf@gmail.com \
--cc=dwg@au1.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.