From: Rusty Russell <rusty@rustcorp.com.au>
To: Pawel Moll <pawel.moll@arm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] virtio-mmio: Devices parameter parsing
Date: Tue, 22 Nov 2011 11:23:31 +1030 [thread overview]
Message-ID: <87fwhhx9is.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1321898210.3093.263.camel@hornet.cambridge.arm.com>
On Mon, 21 Nov 2011 17:56:50 +0000, Pawel Moll <pawel.moll@arm.com> wrote:
> On Mon, 2011-11-21 at 14:44 +0000, Pawel Moll wrote:
> > I'll post v3 tonight or tomorrow.
>
> Ok, it won't be v3 then...
>
> I tried again, using your suggestions - see below (just the crucial bit,
> however I have the kernel-parameters.txt bits ready as well). Parsing
> works like charm, however when it gets to device_register() and
> platform_device_register_resndata() I hit the same problem as
> previously. Both are using slab allocator...
>
> device_register()->device_add()->device_private_init()->kzalloc()
>
> and
>
> platform_device_register_resndata()->platform_device_register_full()->
> platform_device_alloc()->kzalloc().
>
> Essentially it seems that the parameter callbacks are just executed
> waaay to early to do more than just set few integers here and there...
>
> Any ideas?
Rewrite the kernel and every arch so allocators work as soon as we hit
start_kernel() and we can get rid of hundreds of ugly workarounds?
Perhaps not today. So, we will need a linked list of devices and
resources. Yeah, that means allocating, which means YA
slab_is_available()/alloc_bootmem() hack.
Think of yourself as a pioneer...
Thanks :)
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Pawel Moll <pawel.moll@arm.com>
Cc: "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization\@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] virtio-mmio: Devices parameter parsing
Date: Tue, 22 Nov 2011 11:23:31 +1030 [thread overview]
Message-ID: <87fwhhx9is.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1321898210.3093.263.camel@hornet.cambridge.arm.com>
On Mon, 21 Nov 2011 17:56:50 +0000, Pawel Moll <pawel.moll@arm.com> wrote:
> On Mon, 2011-11-21 at 14:44 +0000, Pawel Moll wrote:
> > I'll post v3 tonight or tomorrow.
>
> Ok, it won't be v3 then...
>
> I tried again, using your suggestions - see below (just the crucial bit,
> however I have the kernel-parameters.txt bits ready as well). Parsing
> works like charm, however when it gets to device_register() and
> platform_device_register_resndata() I hit the same problem as
> previously. Both are using slab allocator...
>
> device_register()->device_add()->device_private_init()->kzalloc()
>
> and
>
> platform_device_register_resndata()->platform_device_register_full()->
> platform_device_alloc()->kzalloc().
>
> Essentially it seems that the parameter callbacks are just executed
> waaay to early to do more than just set few integers here and there...
>
> Any ideas?
Rewrite the kernel and every arch so allocators work as soon as we hit
start_kernel() and we can get rid of hundreds of ugly workarounds?
Perhaps not today. So, we will need a linked list of devices and
resources. Yeah, that means allocating, which means YA
slab_is_available()/alloc_bootmem() hack.
Think of yourself as a pioneer...
Thanks :)
Rusty.
next prev parent reply other threads:[~2011-11-22 0:53 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 13:53 [PATCH] virtio-mmio: Devices parameter parsing Pawel Moll
2011-11-16 0:42 ` Rusty Russell
2011-11-16 0:42 ` Rusty Russell
2011-11-16 18:13 ` Pawel Moll
2011-11-16 18:13 ` Pawel Moll
2011-11-17 12:42 ` [PATCH v2] " Pawel Moll
2011-11-17 12:42 ` Pawel Moll
2011-11-21 3:32 ` [PATCH] " Rusty Russell
2011-11-21 14:44 ` Pawel Moll
2011-11-21 14:44 ` Pawel Moll
2011-11-21 17:56 ` Pawel Moll
2011-11-21 17:56 ` Pawel Moll
2011-11-22 0:53 ` Rusty Russell [this message]
2011-11-22 0:53 ` Rusty Russell
2011-11-23 18:08 ` Pawel Moll
2011-11-28 0:31 ` Rusty Russell
2011-11-28 0:31 ` Rusty Russell
2011-11-29 17:36 ` Pawel Moll
2011-11-29 17:36 ` Pawel Moll
2011-12-01 2:06 ` Rusty Russell
2011-12-01 2:06 ` Rusty Russell
2011-12-12 17:53 ` Pawel Moll
2011-12-12 17:53 ` Pawel Moll
2011-12-12 17:57 ` [PATCH 1/2] params: <level>_initcall-like kernel parameters Pawel Moll
2011-12-12 17:57 ` Pawel Moll
2011-12-12 17:57 ` [PATCH 2/2] virtio-mmio: Devices parameter parsing Pawel Moll
2011-12-12 17:57 ` Pawel Moll
2012-04-09 16:32 ` Sasha Levin
2012-04-09 16:32 ` Sasha Levin
2012-04-10 12:53 ` Pawel Moll
2012-04-10 12:53 ` Pawel Moll
2011-12-15 3:51 ` [PATCH 1/2] params: <level>_initcall-like kernel parameters Rusty Russell
2011-12-15 3:51 ` Rusty Russell
2011-12-15 9:38 ` Pawel Moll
2011-12-15 9:38 ` Pawel Moll
2011-11-22 0:44 ` [PATCH] virtio-mmio: Devices parameter parsing Rusty Russell
2011-11-22 0:44 ` Rusty Russell
2011-11-21 3:32 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2012-05-09 17:30 Pawel Moll
2012-05-09 17:30 ` Pawel Moll
2012-05-10 0:44 ` Rusty Russell
2012-05-10 0:44 ` Rusty Russell
2011-11-15 13:53 Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwhhx9is.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.