All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Aaro Koskinen <aaro.koskinen@nokia.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/6] arm: mach-omap2: smartreflex: fix sr_late_init() error path in probe
Date: Thu, 24 Mar 2011 10:18:49 -0700	[thread overview]
Message-ID: <87fwqczbba.fsf@ti.com> (raw)
In-Reply-To: <1300984535-10530-2-git-send-email-aaro.koskinen@nokia.com> (Aaro Koskinen's message of "Thu, 24 Mar 2011 18:35:31 +0200")

Aaro Koskinen <aaro.koskinen@nokia.com> writes:

> sr_late_init() will take care of freeing the resources.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>

Thanks,

As I've already got some other SR related stuff queued up for 2.6.39,
I'll queue patches 2-6 for the 2.6.39-rc fixes cycle.

Tony can take patch 1 as he see's fit.

Also, I renamed the subject/shortlog to use 'OMAP2+: smartreflex: ..."
instead of 'arm: mach-omap2'.

Kevin

> ---
>  arch/arm/mach-omap2/smartreflex.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> index 8f674c9..6dfc8db 100644
> --- a/arch/arm/mach-omap2/smartreflex.c
> +++ b/arch/arm/mach-omap2/smartreflex.c
> @@ -883,7 +883,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
>  		ret = sr_late_init(sr_info);
>  		if (ret) {
>  			pr_warning("%s: Error in SR late init\n", __func__);
> -			goto err_release_region;
> +			return ret;
>  		}
>  	}

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] arm: mach-omap2: smartreflex: fix sr_late_init() error path in probe
Date: Thu, 24 Mar 2011 10:18:49 -0700	[thread overview]
Message-ID: <87fwqczbba.fsf@ti.com> (raw)
In-Reply-To: <1300984535-10530-2-git-send-email-aaro.koskinen@nokia.com> (Aaro Koskinen's message of "Thu, 24 Mar 2011 18:35:31 +0200")

Aaro Koskinen <aaro.koskinen@nokia.com> writes:

> sr_late_init() will take care of freeing the resources.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>

Thanks,

As I've already got some other SR related stuff queued up for 2.6.39,
I'll queue patches 2-6 for the 2.6.39-rc fixes cycle.

Tony can take patch 1 as he see's fit.

Also, I renamed the subject/shortlog to use 'OMAP2+: smartreflex: ..."
instead of 'arm: mach-omap2'.

Kevin

> ---
>  arch/arm/mach-omap2/smartreflex.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> index 8f674c9..6dfc8db 100644
> --- a/arch/arm/mach-omap2/smartreflex.c
> +++ b/arch/arm/mach-omap2/smartreflex.c
> @@ -883,7 +883,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
>  		ret = sr_late_init(sr_info);
>  		if (ret) {
>  			pr_warning("%s: Error in SR late init\n", __func__);
> -			goto err_release_region;
> +			return ret;
>  		}
>  	}

  reply	other threads:[~2011-03-24 17:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-24 16:35 [PATCH 1/6] arm: mach-omap2: omap_l3_smx: fix request_irq() error path Aaro Koskinen
2011-03-24 16:35 ` Aaro Koskinen
2011-03-24 16:35 ` [PATCH 2/6] arm: mach-omap2: smartreflex: fix sr_late_init() error path in probe Aaro Koskinen
2011-03-24 16:35   ` Aaro Koskinen
2011-03-24 17:18   ` Kevin Hilman [this message]
2011-03-24 17:18     ` Kevin Hilman
2011-03-25  3:50     ` Nishanth Menon
2011-03-25  3:50       ` Nishanth Menon
2011-03-25 14:51       ` Kevin Hilman
2011-03-25 14:51         ` Kevin Hilman
2011-03-24 16:35 ` [PATCH 3/6] arm: mach-omap2: smartreflex: request the memory region Aaro Koskinen
2011-03-24 16:35   ` Aaro Koskinen
2011-03-24 16:35 ` [PATCH 4/6] arm: mach-omap2: smartreflex: fix ioremap leak on probe error Aaro Koskinen
2011-03-24 16:35   ` Aaro Koskinen
2011-03-24 16:35 ` [PATCH 5/6] arm: mach-omap2: smartreflex: delete instance from sr_list " Aaro Koskinen
2011-03-24 16:35   ` Aaro Koskinen
2011-03-24 16:35 ` [PATCH 6/6] arm: mach-omap2: smartreflex: delete debugfs entries " Aaro Koskinen
2011-03-24 16:35   ` Aaro Koskinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fwqczbba.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=aaro.koskinen@nokia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.