From: Andi Kleen <andi@firstfloor.org>
To: Russ Anderson <rja@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tony Luck <tony.luck@intel.com>,
Christoph Lameter <clameter@sgi.com>
Subject: Re: [PATCH 3/3] ia64: Call migration code on correctable errors v2
Date: Fri, 02 May 2008 17:45:55 +0000 [thread overview]
Message-ID: <87fxt0vbu4.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20080502004425.GD12006@sgi.com> (Russ Anderson's message of "Thu, 1 May 2008 19:44:25 -0500")
Russ Anderson <rja@sgi.com> writes:
> Migrate data off pages with correctable memory errors. This patch is the
> ia64 specific piece. It connects the CPE handler to the page migration
> code. It is implemented as a kernel loadable module, similar to the mca
> recovery code (mca_recovery.ko). This allows the feature to be turned off
> by uninstalling the module. Creates /proc/badram to display bad page
> information and free bad pages.
How do you know what pages have excessive errors? And how is excessive defined?
Surely you don't keep a per page error count? It's unclear from your patch.
Anyways I don't think this should be ia64 specific, but generic code.
I also have my doubts about making such small code subsystems modules. Modules
always get rounded to pages so it ultimatively just wastes memory.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Russ Anderson <rja@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tony Luck <tony.luck@intel.com>,
Christoph Lameter <clameter@sgi.com>
Subject: Re: [PATCH 3/3] ia64: Call migration code on correctable errors v2
Date: Fri, 02 May 2008 19:45:55 +0200 [thread overview]
Message-ID: <87fxt0vbu4.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20080502004425.GD12006@sgi.com> (Russ Anderson's message of "Thu, 1 May 2008 19:44:25 -0500")
Russ Anderson <rja@sgi.com> writes:
> Migrate data off pages with correctable memory errors. This patch is the
> ia64 specific piece. It connects the CPE handler to the page migration
> code. It is implemented as a kernel loadable module, similar to the mca
> recovery code (mca_recovery.ko). This allows the feature to be turned off
> by uninstalling the module. Creates /proc/badram to display bad page
> information and free bad pages.
How do you know what pages have excessive errors? And how is excessive defined?
Surely you don't keep a per page error count? It's unclear from your patch.
Anyways I don't think this should be ia64 specific, but generic code.
I also have my doubts about making such small code subsystems modules. Modules
always get rounded to pages so it ultimatively just wastes memory.
-Andi
next prev parent reply other threads:[~2008-05-02 17:45 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 0:44 [PATCH 3/3] ia64: Call migration code on correctable errors v2 Russ Anderson
2008-05-02 0:44 ` Russ Anderson
2008-05-02 1:22 ` Christoph Lameter
2008-05-02 1:22 ` Christoph Lameter
2008-05-02 2:43 ` Russ Anderson
2008-05-02 2:43 ` Russ Anderson
2008-05-02 9:58 ` Pekka Enberg
2008-05-02 9:58 ` Pekka Enberg
2008-05-02 16:40 ` Russ Anderson
2008-05-02 16:40 ` Russ Anderson
2008-05-02 16:57 ` Pekka J Enberg
2008-05-02 16:57 ` Pekka J Enberg
2008-05-02 17:30 ` Russ Anderson
2008-05-02 17:30 ` Russ Anderson
2008-05-02 17:45 ` Andi Kleen [this message]
2008-05-02 17:45 ` Andi Kleen
2008-05-02 18:50 ` Russ Anderson
2008-05-02 18:50 ` Russ Anderson
2008-05-02 19:33 ` Andi Kleen
2008-05-02 19:33 ` Andi Kleen
2008-05-02 20:27 ` Russ Anderson
2008-05-02 20:27 ` Russ Anderson
2008-05-09 15:11 ` [PATCH 3/3] ia64: Call migration code on correctable errors v3 Russ Anderson
2008-05-09 15:11 ` Russ Anderson
2008-05-09 20:52 ` Andrew Morton
2008-05-09 20:52 ` Andrew Morton
2008-05-09 21:03 ` Christoph Lameter
2008-05-09 21:03 ` Christoph Lameter
2008-05-09 21:07 ` Russ Anderson
2008-05-09 21:07 ` Russ Anderson
2008-05-13 23:05 ` [PATCH 3/3] ia64: Call migration code on correctable errors v4 Russ Anderson
2008-05-13 23:05 ` Russ Anderson
2008-05-16 19:23 ` [PATCH 3/3] ia64: Call migration code on correctable errors v5 Russ Anderson
2008-05-16 19:23 ` Russ Anderson
2008-05-16 23:15 ` Christoph Lameter
2008-05-16 23:15 ` Christoph Lameter
2008-06-09 16:20 ` [PATCH 3/3] ia64: Call migration code on correctable errors v6 Russ Anderson
2008-06-09 16:20 ` Russ Anderson
2008-06-23 3:25 ` KOSAKI Motohiro
2008-06-23 3:25 ` KOSAKI Motohiro
2008-06-25 22:25 ` Russ Anderson
2008-06-25 22:25 ` Russ Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fxt0vbu4.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rja@sgi.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.