Re: [PATCH] Use getopt_long() instead of argp_parse() in grub-emu

[Marco Gerards <mgerards@xs4all.nl>]

Christian Franke <Christian.Franke@t-online.de> writes:

> Unlike the other GRUB2 utils, grub-emu uses the glibc extension
> argp_parse(). It is unavailable on Cygwin, which might also be the
> case for other platforms where glibc is not the native runtime.
>
> This patch changes this back to the more traditional getopt_long().
>
> It also fixes the syntax of the path prefix.

There where no objections, so I'll review this patch as promised.

How did you change the path syntax?

> 2007-11-10  Christian Franke  <franke@computer.org>
>
> 	* util/grub-emu.c: Replace argp.h by getopt.h.

Please use <argp.h> and <getopt.h> to show where it comes from.

> 	(parse_opt): Remove.

You also modified options, removed struct arguments, argp and perhaps
other things I missed.  You should document them properly in the
changelog entry.

> 	(usage): New function.
> 	(main): Replace argp_parse() by getopt_long().
> 	Rename argument variables accordingly.
> 	Add missing "(...)" for root_dev in prefix.

--
Marco