[PATCH][RESEND] Make xend set the console limit

[PATCH][RESEND] Make xend set the console limit

[Dan Smith]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

This is a resend of the console limit patch I sent last week.  If
there is anything wrong with the change, please advise.

Signed-off-by: Dan Smith <danms@us.ibm.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: console_resend.patch --]
[-- Type: text/x-patch, Size: 1535 bytes --]

diff -r 446aa56ca4fe tools/examples/xend-config.sxp
--- a/tools/examples/xend-config.sxp	Mon Oct 17 12:50:28 2005
+++ b/tools/examples/xend-config.sxp	Tue Oct 18 15:47:50 2005
@@ -19,6 +19,9 @@
 # Specifying 'localhost' prevents remote connections.
 # Specifying the empty string '' allows all connections.
 (console-address   'localhost')
+
+# The limit (in kilobytes) on the size of the console buffer
+(console-limit 1024)
 
 ## Use the following if VIF traffic is routed.
 # The script used to start/stop networking for xend.
diff -r 446aa56ca4fe tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py	Mon Oct 17 12:50:28 2005
+++ b/tools/python/xen/xend/XendDomainInfo.py	Tue Oct 18 15:47:50 2005
@@ -588,7 +588,7 @@
         to_store = {
             'domid':              str(self.domid),
             'vm':                 self.vmpath,
-
+            'console/limit':      str(xroot.get_console_limit() * 1024),
             'memory/target':      str(self.info['memory_KiB'])
             }
 
diff -r 446aa56ca4fe tools/python/xen/xend/XendRoot.py
--- a/tools/python/xen/xend/XendRoot.py	Mon Oct 17 12:50:28 2005
+++ b/tools/python/xen/xend/XendRoot.py	Tue Oct 18 15:47:50 2005
@@ -267,6 +267,9 @@
     def get_dom0_vcpus(self):
         return self.get_config_int('dom0-cpus', self.dom0_vcpus_default)
 
+    def get_console_limit(self):
+        return self.get_config_int('console-limit', 1024)
+
 def instance():
     """Get an instance of XendRoot.
     Use this instead of the constructor.

[-- Attachment #3: Type: text/plain, Size: 87 bytes --]

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@us.ibm.com

[-- Attachment #4: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH][RESEND] Make xend set the console limit

[Ewan Mellor]

On Tue, Oct 18, 2005 at 03:46:28PM -0700, Dan Smith wrote:

> This is a resend of the console limit patch I sent last week.  If
> there is anything wrong with the change, please advise.

There's nothing wrong with the patch that I can see -- I've just been short of
time.  Apologies.  It will make it in soon.

Ewan.

Re: [PATCH][RESEND] Make xend set the console limit

[Dan Smith]

EM> There's nothing wrong with the patch that I can see -- I've just
EM> been short of time.  Apologies.  It will make it in soon.

Not a problem.  At one point, someone mentioned a 48-hour resend
buffer for patches that might have gotten missed.

Thanks Ewan!

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@us.ibm.com

Re: [PATCH][RESEND] Make xend set the console limit

[Ewan Mellor]

On Wed, Oct 19, 2005 at 06:33:10AM -0700, Dan Smith wrote:

> 
> EM> There's nothing wrong with the patch that I can see -- I've just
> EM> been short of time.  Apologies.  It will make it in soon.
> 
> Not a problem.  At one point, someone mentioned a 48-hour resend
> buffer for patches that might have gotten missed.

Yes, that's definitely a good idea -- we do forget things sometimes!

Ewan.