All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Michael Walle" <michael@walle.cc>
Cc: <haibo.chen@oss.nxp.com>,  "Pratyush Yadav" <pratyush@kernel.org>,
	"Michael Walle" <mwalle@kernel.org>,
	 "Takahiro Kuwano" <takahiro.kuwano@infineon.com>,
	 "Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>,  <linux-kernel@vger.kernel.org>,
	<imx@lists.linux.dev>,  "Haibo Chen" <haibo.chen@nxp.com>,
	<stable@vger.kernel.org>
Subject: Re: [PATCH v5] mtd: spi-nor: clear the default read_sr2 opcode for Octal DTR flashes
Date: Wed, 18 Nov 2026 15:21:17 +0100	[thread overview]
Message-ID: <87h5hei5k2.fsf@bootlin.com> (raw)
In-Reply-To: <DMYBR7I0R1PK.25FUNB24SPCFS@walle.cc> (Michael Walle's message of "Wed, 18 Nov 2026 13:10:38 +0100")

On 18/11/2026 at 13:10:38 +01, "Michael Walle" <michael@walle.cc> wrote:

> On Fri Oct 23, 2026 at 9:11 AM CEST, haibo.chen wrote:
>> From: Haibo Chen <haibo.chen@nxp.com>
>>
>> The core defaults opcodes.read_sr2 to the legacy RDCR opcode (0x35), and
>> spi_nor_cache_sr_lock_bits() reads SR2 during spi_nor_init(), i.e. after
>> the flash has been switched to its runtime protocol. On an octal flash
>> running in 8D-8D-8D mode the opcode is extended per cmd_ext_type (e.g.
>> 0x3535), but RDCR is not a valid register read there: these parts access
>> their status/configuration registers through a vendor-specific indirect
>> space, if at all. The flash does not answer, the register read times out
>> and probe (or resume) fails (on i.MX FlexSPI: -ETIMEDOUT and a controller
>> WARN(), seen with a Micron MT35XU01G and a Macronix MX25UW51345G).
>>
>> Clear read_sr2 on every path that enables 8D-8D-8D, so that
>> spi_nor_read_sr1_and_sr2() degrades to an SR1-only read and no
>> unsupported command is issued. A manufacturer driver that genuinely
>> needs an SR2 read in this mode can still install its own opcode in a
>> later fixup.
>>
>> - spi_nor_parse_profile1(): the common case. The xSPI Profile 1.0 table
>>   does not describe any SR2/RDCR read, and it runs before the
>>   manufacturer late_init.
>> - mt35xu512aba_post_sfdp_fixup(): some mt35xu512aba batches lack the
>>   Profile 1.0 table and enable 8D here instead, with the BFPT QER field
>>   left at a reserved value so read_sr2 keeps its RDCR default.
>> - spi_nor_no_sfdp_init_params(): non-SFDP parts that enable 8D via
>>   SPI_NOR_OCTAL_DTR_READ keep the RDCR default too.
>>
>> CMP (the only user of SR2 beyond quad-enable in the locking code) is
>> Winbond-specific and is not placed in SR2 on their 8D-capable parts, so
>> no octal flash loses a usable SR2 read because of this change.
>>
>> Fixes: 63489002d397 ("mtd: spi-nor: Refactor Read Status/Write Status support")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
>> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
>
> Miquel, if you want to pick it yourself for fixes, otherwise I can
> also push it there.
>
> In any case,
>
> Acked-by: Michael Walle <mwalle@kernel.org>

Sorry, I'm used to be the only one doing that job. Please do it.

Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Michael Walle" <michael@walle.cc>
Cc: <haibo.chen@oss.nxp.com>,  "Pratyush Yadav" <pratyush@kernel.org>,
	"Michael Walle" <mwalle@kernel.org>,
	 "Takahiro Kuwano" <takahiro.kuwano@infineon.com>,
	 "Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>,  <linux-kernel@vger.kernel.org>,
	<imx@lists.linux.dev>,  "Haibo Chen" <haibo.chen@nxp.com>,
	<stable@vger.kernel.org>
Subject: Re: [PATCH v5] mtd: spi-nor: clear the default read_sr2 opcode for Octal DTR flashes
Date: Wed, 18 Nov 2026 15:21:17 +0100	[thread overview]
Message-ID: <87h5hei5k2.fsf@bootlin.com> (raw)
In-Reply-To: <DMYBR7I0R1PK.25FUNB24SPCFS@walle.cc> (Michael Walle's message of "Wed, 18 Nov 2026 13:10:38 +0100")

On 18/11/2026 at 13:10:38 +01, "Michael Walle" <michael@walle.cc> wrote:

> On Fri Oct 23, 2026 at 9:11 AM CEST, haibo.chen wrote:
>> From: Haibo Chen <haibo.chen@nxp.com>
>>
>> The core defaults opcodes.read_sr2 to the legacy RDCR opcode (0x35), and
>> spi_nor_cache_sr_lock_bits() reads SR2 during spi_nor_init(), i.e. after
>> the flash has been switched to its runtime protocol. On an octal flash
>> running in 8D-8D-8D mode the opcode is extended per cmd_ext_type (e.g.
>> 0x3535), but RDCR is not a valid register read there: these parts access
>> their status/configuration registers through a vendor-specific indirect
>> space, if at all. The flash does not answer, the register read times out
>> and probe (or resume) fails (on i.MX FlexSPI: -ETIMEDOUT and a controller
>> WARN(), seen with a Micron MT35XU01G and a Macronix MX25UW51345G).
>>
>> Clear read_sr2 on every path that enables 8D-8D-8D, so that
>> spi_nor_read_sr1_and_sr2() degrades to an SR1-only read and no
>> unsupported command is issued. A manufacturer driver that genuinely
>> needs an SR2 read in this mode can still install its own opcode in a
>> later fixup.
>>
>> - spi_nor_parse_profile1(): the common case. The xSPI Profile 1.0 table
>>   does not describe any SR2/RDCR read, and it runs before the
>>   manufacturer late_init.
>> - mt35xu512aba_post_sfdp_fixup(): some mt35xu512aba batches lack the
>>   Profile 1.0 table and enable 8D here instead, with the BFPT QER field
>>   left at a reserved value so read_sr2 keeps its RDCR default.
>> - spi_nor_no_sfdp_init_params(): non-SFDP parts that enable 8D via
>>   SPI_NOR_OCTAL_DTR_READ keep the RDCR default too.
>>
>> CMP (the only user of SR2 beyond quad-enable in the locking code) is
>> Winbond-specific and is not placed in SR2 on their 8D-capable parts, so
>> no octal flash loses a usable SR2 read because of this change.
>>
>> Fixes: 63489002d397 ("mtd: spi-nor: Refactor Read Status/Write Status support")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
>> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
>
> Miquel, if you want to pick it yourself for fixes, otherwise I can
> also push it there.
>
> In any case,
>
> Acked-by: Michael Walle <mwalle@kernel.org>

Sorry, I'm used to be the only one doing that job. Please do it.

Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2026-11-18 14:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23  7:11 [PATCH v5] mtd: spi-nor: clear the default read_sr2 opcode for Octal DTR flashes haibo.chen
2026-10-23  7:11 ` haibo.chen
2026-11-10  8:13 ` Bough Chen
2026-11-10  8:13   ` Bough Chen
2026-11-17  9:34   ` Miquel Raynal
2026-11-17  9:34     ` Miquel Raynal
2026-11-18 12:10 ` Michael Walle
2026-11-18 12:10   ` Michael Walle
2026-11-18 14:21   ` Miquel Raynal [this message]
2026-11-18 14:21     ` Miquel Raynal
2026-11-20 12:26 ` Michael Walle
2026-11-20 12:26   ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h5hei5k2.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=haibo.chen@nxp.com \
    --cc=haibo.chen@oss.nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=stable@vger.kernel.org \
    --cc=takahiro.kuwano@infineon.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.