Re: [PATCH] target/arm: replace cp_regs hashtable lookup with direct array index

["Alex Bennée" <alex.bennee@linaro.org>]

Richard Henderson <richard.henderson@linaro.org> writes:

> On 6/3/26 01:00, Alex Bennée wrote:
>>> This will not work, because each ARMCPU has separate cpreg info
>>> structures, and these structures only have the lifetime of the ARMCPU
>>> struct.  We create and destroy these at runtime, so at some point you
>>> may end up with pointers to freed memory.
>> Shouldn't it be the same set for each CPU though?
>
> I have thought for some time that the cpregs should be stored on the
> class, not the instance, so that these structures are shared, but it's
> non-trivial.

IIRC there are also some places where the list isn't complete until
realize time (I think for things like the GIC system registers).

>
> r~

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro