All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arseniy Krasnov <avkrasnov@rulkc.org>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Frieder Schrempf <frieder.schrempf@kontron.de>,
	 Boris Brezillon <bbrezillon@kernel.org>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	 rulkc@linuxtesting.org, oxffffaa@gmail.com,
	 stable@vger.kernel.org
Subject: Re: [PATCH v1] mtd: rawnand: fix condition in 'nand_select_target()'
Date: Tue, 05 May 2026 10:10:06 +0200	[thread overview]
Message-ID: <87h5omqntt.fsf@bootlin.com> (raw)
In-Reply-To: <57b0cc2a-6d62-405c-bfa5-68d1c46dbad9@rulkc.org> (Arseniy Krasnov's message of "Tue, 5 May 2026 10:59:16 +0300")

On 05/05/2026 at 10:59:16 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:

> 05.05.2026 10:50, Miquel Raynal wrote:
>> Hi,
>>
>> On 05/05/2026 at 01:10:12 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:
>>
>> Two important typos in the commit log :-)
>>
>>> 'cs' here must in range [0:nanddev_ntargets).
>>                 be                           [
>
>
> Hi, sorry, You mean?
>
>
> 'cs' here must be in range [0:nanddev_ntargets]. 

I meant [0:nanddev_ntargets[ which is the mathematical way, IIRC, to
indicate that the last value is out of scope/excluded.

[0:nanddev_ntargets] means that nanddev_ntargets is included in the
scope of values and here since you are explicitly showing that it is
not, it feels wrong to use that convention.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arseniy Krasnov <avkrasnov@rulkc.org>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Frieder Schrempf <frieder.schrempf@kontron.de>,
	 Boris Brezillon <bbrezillon@kernel.org>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	 rulkc@linuxtesting.org, oxffffaa@gmail.com,
	 stable@vger.kernel.org
Subject: Re: [PATCH v1] mtd: rawnand: fix condition in 'nand_select_target()'
Date: Tue, 05 May 2026 10:10:06 +0200	[thread overview]
Message-ID: <87h5omqntt.fsf@bootlin.com> (raw)
In-Reply-To: <57b0cc2a-6d62-405c-bfa5-68d1c46dbad9@rulkc.org> (Arseniy Krasnov's message of "Tue, 5 May 2026 10:59:16 +0300")

On 05/05/2026 at 10:59:16 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:

> 05.05.2026 10:50, Miquel Raynal wrote:
>> Hi,
>>
>> On 05/05/2026 at 01:10:12 +03, Arseniy Krasnov <avkrasnov@rulkc.org> wrote:
>>
>> Two important typos in the commit log :-)
>>
>>> 'cs' here must in range [0:nanddev_ntargets).
>>                 be                           [
>
>
> Hi, sorry, You mean?
>
>
> 'cs' here must be in range [0:nanddev_ntargets]. 

I meant [0:nanddev_ntargets[ which is the mathematical way, IIRC, to
indicate that the last value is out of scope/excluded.

[0:nanddev_ntargets] means that nanddev_ntargets is included in the
scope of values and here since you are explicitly showing that it is
not, it feels wrong to use that convention.

Thanks,
Miquèl

  reply	other threads:[~2026-05-05  8:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 22:10 [PATCH v1] mtd: rawnand: fix condition in 'nand_select_target()' Arseniy Krasnov
2026-05-04 22:10 ` Arseniy Krasnov
2026-05-05  7:50 ` Miquel Raynal
2026-05-05  7:50   ` Miquel Raynal
2026-05-05  7:59   ` Arseniy Krasnov
2026-05-05  7:59     ` Arseniy Krasnov
2026-05-05  8:10     ` Miquel Raynal [this message]
2026-05-05  8:10       ` Miquel Raynal
2026-05-05  8:14       ` Arseniy Krasnov
2026-05-05  8:14         ` Arseniy Krasnov
2026-05-05  8:23         ` Miquel Raynal
2026-05-05  8:23           ` Miquel Raynal
2026-05-05 11:46           ` Arseniy Krasnov
2026-05-05 11:46             ` Arseniy Krasnov
  -- strict thread matches above, loose matches on Subject: below --
2026-05-04 20:28 Arseniy Krasnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h5omqntt.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=avkrasnov@rulkc.org \
    --cc=bbrezillon@kernel.org \
    --cc=frieder.schrempf@kontron.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=oxffffaa@gmail.com \
    --cc=richard@nod.at \
    --cc=rulkc@linuxtesting.org \
    --cc=stable@vger.kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.