From: Thomas Gleixner <tglx@linutronix.de>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
ryan_chen <ryan_chen@aspeedtech.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
jk@codeconstruct.com.au, Kevin Chen <kevin_chen@aspeedtech.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH v5 2/3] Irqchip/ast2700-intc: add debugfs support for routing/protection display
Date: Wed, 22 Oct 2025 18:37:44 +0200 [thread overview]
Message-ID: <87h5vqyjs7.ffs@tglx> (raw)
In-Reply-To: <20251022065507.1152071-3-ryan_chen@aspeedtech.com>
On Wed, Oct 22 2025 at 14:55, Ryan Chen wrote:
The prefix is: irqchip/ast....:
> AST2700 INTC0/INTC1 nodes ("aspeed,ast2700-intc0/1") not only
> include the interrupt controller child node ("aspeed,ast2700-intc-ic"),
> but also provide interrupt routing and register protection features.
Lacks a new line to open a new paragraph.
> Adds debugfs entries for interrupt routing and protection status for
Add
> AST2700 INTC0/INTC1.
But what you are failing to explain is why this is required and
useful. Just adding code because we can is not a real good reason.
Thanks,
tglx
next prev parent reply other threads:[~2025-10-22 16:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 6:55 [PATCH v5 0/3] AST2700 interrupt controller hierarchy support Ryan Chen
2025-10-22 6:55 ` [PATCH v5 1/3] dt-bindings: interrupt-controller: aspeed,ast2700: Add support for INTC hierarchy Ryan Chen
2025-10-22 8:29 ` Rob Herring (Arm)
2025-10-22 13:51 ` Rob Herring
2025-10-23 6:57 ` Ryan Chen
2025-10-24 23:11 ` Rob Herring
2025-10-26 3:57 ` Ryan Chen
2025-10-22 6:55 ` [PATCH v5 2/3] Irqchip/ast2700-intc: add debugfs support for routing/protection display Ryan Chen
2025-10-22 16:37 ` Thomas Gleixner [this message]
2025-10-23 8:20 ` Ryan Chen
2025-10-22 6:55 ` [PATCH v5 3/3] irqchip: aspeed: add compatible strings for ast2700-intc0-ic and ast2700-intc1-ic Ryan Chen
2025-10-22 16:51 ` Thomas Gleixner
2025-10-23 8:29 ` Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5vqyjs7.ffs@tglx \
--to=tglx@linutronix.de \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jk@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=kevin_chen@aspeedtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.