Re: [PATCH 1/2] lib/xe/oa: Add perf consts to support more metrics

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Tue, 26 Aug 2025 14:15:44 -0700, Sushma Venkatesh Reddy wrote:
>
> Add new metrics: SqidiTotalCount, L3BankTotalCount, L3NodeTotalCount,
> GeometryPipeTotalCount, DepthPipeTotalCount and ColorPipeTotalCount

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

>
> Signed-off-by: Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com>
> ---
>  lib/xe/oa-configs/codegen.py |  9 ++++++++-
>  lib/xe/xe_oa.h               | 13 +++++++++++++
>  2 files changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/lib/xe/oa-configs/codegen.py b/lib/xe/oa-configs/codegen.py
> index 8629eac6d..d3742e11b 100644
> --- a/lib/xe/oa-configs/codegen.py
> +++ b/lib/xe/oa-configs/codegen.py
> @@ -128,7 +128,6 @@ class Set:
>          return self.xml.find(path)
>
>
> -#TODO add SqidiTotalCount, L3BankTotalCount, L3NodeTotalCount
>  hw_vars_mapping = {
>      "$EuCoresTotalCount": { 'c': "perf->devinfo.n_eus", 'desc': "The total number of execution units" },
>      "$EuSlicesTotalCount": { 'c': "perf->devinfo.n_eu_slices" },
> @@ -164,6 +163,14 @@ hw_vars_mapping = {
>      "$ComputeEngineTotalCount": { 'c': "perf->devinfo.n_eus", 'desc': "The total number of execution units" },
>
>      "$CopyEngineTotalCount": { 'c': "perf->devinfo.n_eus", 'desc': "The total number of execution units" },
> +
> +    "$SqidiTotalCount": { 'c': "perf->devinfo.n_sq_idis", 'desc': "Total number of SQIDI units" },
> +    "$L3BankTotalCount": { 'c': "perf->devinfo.l3_banks", 'desc': "Total L3 bank count" },
> +    "$L3NodeTotalCount": { 'c': "perf->devinfo.n_l3_nodes", 'desc': "Total L3 node count" },
> +
> +    "$GeometryPipeTotalCount": { 'c': "perf->devinfo.n_geom_pipes", 'desc': "The total number of geometry pipelines" },
> +    "$DepthPipeTotalCount": { 'c': "perf->devinfo.n_depth_pipes", 'desc': "The total number of depth pipelines" },
> +    "$ColorPipeTotalCount": { 'c': "perf->devinfo.n_color_pipes", 'desc': "The total number of color pipelines" },
>  }
>
>  def is_hw_var(name):
> diff --git a/lib/xe/xe_oa.h b/lib/xe/xe_oa.h
> index 7d3d07456..020f6d058 100644
> --- a/lib/xe/xe_oa.h
> +++ b/lib/xe/xe_oa.h
> @@ -110,6 +110,19 @@ struct intel_xe_perf_devinfo {
>	/* Number of threads in one EU */
>	uint64_t eu_threads_count;
>
> +	/* Squidi Total Count */
> +	uint32_t n_sq_idis;
> +	/* L3 Bank Count */
> +	uint32_t l3_banks;
> +	/* Number of L3 nodes */
> +	uint32_t n_l3_nodes;
> +	/* Number of depth pipes */
> +	uint32_t n_depth_pipes;
> +	/* Number of geometry pipes */
> +	uint32_t n_geom_pipes;
> +	/* Number of color pipes */
> +	uint32_t n_color_pipes;
> +
>	/**
>	 * Maximu number of slices present on this device (can be more than
>	 * num_slices if some slices are fused).
> --
> 2.43.0
>