Re: [RFC PATCH v2 2/9] iio: pressure: bmp280: implement adaptive wait for BMx280 devices

[ASSI <Stromeko@nexgo.de>]

Andy Shevchenko writes:
>> Suggested-by: Andy Shevchenko <andy@kernel.org>
>
> I'm not sure this tag may be used as I suggested implementation detail
> and not the idea behind the change as a whole.

OK, will remove this.

>> Tested-by: Achim Gratz <Achim.Gratz@Stromeko.DE>
>
> This is confusing. Does it mean you haven't tested the patches without this tag?
> Note, it's a must to test by the author that's why the tag is
> _implied_, no need to make it explicit. I.o.w. author of the code is
> supposed to test that before sending (or comment that the code is
> untested in the cover letter and/or comment block of the email).

I intended it to mean that I actually tested the full range of
attributes, unlike what apparently happened with the previous version of
this function.  But I see what you mean, I'll take it out then.

> MIN() is for the constants, please change it to the proper macro.
> Also note that this is a C language and not LISP, i.e. remove unneeded
> parentheses.

Ack, the macro probably has enough argument sanitization so this is no
worry here.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+