From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>,
oe-kbuild-all@lists.linux.dev,
Charles Keepax <ckeepax@opensource.cirrus.com>
Subject: Re: [broonie-ci:20250313_tiwai_asoc_convert_to_modern_pm_macros 113/194] sound/soc/codecs/cs35l56.c:949:12: warning: 'cs35l56_runtime_resume_i2c_spi' defined but not used
Date: Mon, 17 Mar 2025 08:42:48 +0100 [thread overview]
Message-ID: <87h63sf6h3.wl-tiwai@suse.de> (raw)
In-Reply-To: <202503171139.HSG8dCAn-lkp@intel.com>
On Mon, 17 Mar 2025 04:41:39 +0100,
kernel test robot wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git 20250313_tiwai_asoc_convert_to_modern_pm_macros
> head: 9a2c84a9570fadf5fa15f3e6ca13a7ca23a6fb4c
> commit: 87d228cc39db9625da9b75daaed25be23ec0a667 [113/194] ASoC: cs35l56: Convert to RUNTIME_PM_OPS()
> config: csky-randconfig-001-20250317 (https://download.01.org/0day-ci/archive/20250317/202503171139.HSG8dCAn-lkp@intel.com/config)
> compiler: csky-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250317/202503171139.HSG8dCAn-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202503171139.HSG8dCAn-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> >> sound/soc/codecs/cs35l56.c:949:12: warning: 'cs35l56_runtime_resume_i2c_spi' defined but not used [-Wunused-function]
> 949 | static int cs35l56_runtime_resume_i2c_spi(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> sound/soc/codecs/cs35l56.c:942:12: warning: 'cs35l56_runtime_suspend_i2c_spi' defined but not used [-Wunused-function]
> 942 | static int cs35l56_runtime_suspend_i2c_spi(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Those are conditionally exported symbols and I overlooked that
CONFIG_SND_SOC_CS35L56_SDW may still enable CONFIG_SND_SOC_CS35L56
without i2c/spi. So please drop the patch
[PATCH 08/89] ASoC: cs35l56: Convert to RUNTIME_PM_OPS()
Should I resubmit the series together with the typo corrections?
thanks,
Takashi
next prev parent reply other threads:[~2025-03-17 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 3:41 [broonie-ci:20250313_tiwai_asoc_convert_to_modern_pm_macros 113/194] sound/soc/codecs/cs35l56.c:949:12: warning: 'cs35l56_runtime_resume_i2c_spi' defined but not used kernel test robot
2025-03-17 7:42 ` Takashi Iwai [this message]
2025-03-17 9:34 ` Mark Brown
2025-03-17 9:36 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h63sf6h3.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.