Re: [broonie-ci:20250313_tiwai_asoc_convert_to_modern_pm_macros 113/194] sound/soc/codecs/cs35l56.c:949:12: warning: 'cs35l56_runtime_resume_i2c_spi' defined but not used

[Takashi Iwai <tiwai@suse.de>]

On Mon, 17 Mar 2025 10:34:33 +0100,
Mark Brown wrote:
> 
> On Mon, Mar 17, 2025 at 08:42:48AM +0100, Takashi Iwai wrote:
> 
> > > >> sound/soc/codecs/cs35l56.c:949:12: warning: 'cs35l56_runtime_resume_i2c_spi' defined but not used [-Wunused-function]
> > >      949 | static int cs35l56_runtime_resume_i2c_spi(struct device *dev)
> > >          |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > >> sound/soc/codecs/cs35l56.c:942:12: warning: 'cs35l56_runtime_suspend_i2c_spi' defined but not used [-Wunused-function]
> > >      942 | static int cs35l56_runtime_suspend_i2c_spi(struct device *dev)
> > >          |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> > Those are conditionally exported symbols and I overlooked that
> > CONFIG_SND_SOC_CS35L56_SDW may still enable CONFIG_SND_SOC_CS35L56
> > without i2c/spi.  So please drop the patch
> >   [PATCH 08/89] ASoC: cs35l56: Convert to RUNTIME_PM_OPS()
> 
> > Should I resubmit the series together with the typo corrections?
> 
> Ugh, actually this one is so early you may as well resubmit the entire
> series :(

OK, will do.


Takashi