* [broonie-ci:20250313_tiwai_asoc_convert_to_modern_pm_macros 113/194] sound/soc/codecs/cs35l56.c:949:12: warning: 'cs35l56_runtime_resume_i2c_spi' defined but not used
@ 2025-03-17 3:41 kernel test robot
2025-03-17 7:42 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2025-03-17 3:41 UTC (permalink / raw)
To: Takashi Iwai; +Cc: oe-kbuild-all, Mark Brown, Charles Keepax
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git 20250313_tiwai_asoc_convert_to_modern_pm_macros
head: 9a2c84a9570fadf5fa15f3e6ca13a7ca23a6fb4c
commit: 87d228cc39db9625da9b75daaed25be23ec0a667 [113/194] ASoC: cs35l56: Convert to RUNTIME_PM_OPS()
config: csky-randconfig-001-20250317 (https://download.01.org/0day-ci/archive/20250317/202503171139.HSG8dCAn-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250317/202503171139.HSG8dCAn-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503171139.HSG8dCAn-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> sound/soc/codecs/cs35l56.c:949:12: warning: 'cs35l56_runtime_resume_i2c_spi' defined but not used [-Wunused-function]
949 | static int cs35l56_runtime_resume_i2c_spi(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> sound/soc/codecs/cs35l56.c:942:12: warning: 'cs35l56_runtime_suspend_i2c_spi' defined but not used [-Wunused-function]
942 | static int cs35l56_runtime_suspend_i2c_spi(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/cs35l56_runtime_resume_i2c_spi +949 sound/soc/codecs/cs35l56.c
941
> 942 static int cs35l56_runtime_suspend_i2c_spi(struct device *dev)
943 {
944 struct cs35l56_private *cs35l56 = dev_get_drvdata(dev);
945
946 return cs35l56_runtime_suspend_common(&cs35l56->base);
947 }
948
> 949 static int cs35l56_runtime_resume_i2c_spi(struct device *dev)
950 {
951 struct cs35l56_private *cs35l56 = dev_get_drvdata(dev);
952
953 return cs35l56_runtime_resume_common(&cs35l56->base, false);
954 }
955
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [broonie-ci:20250313_tiwai_asoc_convert_to_modern_pm_macros 113/194] sound/soc/codecs/cs35l56.c:949:12: warning: 'cs35l56_runtime_resume_i2c_spi' defined but not used
2025-03-17 3:41 [broonie-ci:20250313_tiwai_asoc_convert_to_modern_pm_macros 113/194] sound/soc/codecs/cs35l56.c:949:12: warning: 'cs35l56_runtime_resume_i2c_spi' defined but not used kernel test robot
@ 2025-03-17 7:42 ` Takashi Iwai
2025-03-17 9:34 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2025-03-17 7:42 UTC (permalink / raw)
To: Mark Brown; +Cc: Takashi Iwai, oe-kbuild-all, Charles Keepax
On Mon, 17 Mar 2025 04:41:39 +0100,
kernel test robot wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git 20250313_tiwai_asoc_convert_to_modern_pm_macros
> head: 9a2c84a9570fadf5fa15f3e6ca13a7ca23a6fb4c
> commit: 87d228cc39db9625da9b75daaed25be23ec0a667 [113/194] ASoC: cs35l56: Convert to RUNTIME_PM_OPS()
> config: csky-randconfig-001-20250317 (https://download.01.org/0day-ci/archive/20250317/202503171139.HSG8dCAn-lkp@intel.com/config)
> compiler: csky-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250317/202503171139.HSG8dCAn-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202503171139.HSG8dCAn-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> >> sound/soc/codecs/cs35l56.c:949:12: warning: 'cs35l56_runtime_resume_i2c_spi' defined but not used [-Wunused-function]
> 949 | static int cs35l56_runtime_resume_i2c_spi(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> sound/soc/codecs/cs35l56.c:942:12: warning: 'cs35l56_runtime_suspend_i2c_spi' defined but not used [-Wunused-function]
> 942 | static int cs35l56_runtime_suspend_i2c_spi(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Those are conditionally exported symbols and I overlooked that
CONFIG_SND_SOC_CS35L56_SDW may still enable CONFIG_SND_SOC_CS35L56
without i2c/spi. So please drop the patch
[PATCH 08/89] ASoC: cs35l56: Convert to RUNTIME_PM_OPS()
Should I resubmit the series together with the typo corrections?
thanks,
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [broonie-ci:20250313_tiwai_asoc_convert_to_modern_pm_macros 113/194] sound/soc/codecs/cs35l56.c:949:12: warning: 'cs35l56_runtime_resume_i2c_spi' defined but not used
2025-03-17 7:42 ` Takashi Iwai
@ 2025-03-17 9:34 ` Mark Brown
2025-03-17 9:36 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2025-03-17 9:34 UTC (permalink / raw)
To: Takashi Iwai; +Cc: oe-kbuild-all, Charles Keepax
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
On Mon, Mar 17, 2025 at 08:42:48AM +0100, Takashi Iwai wrote:
> > >> sound/soc/codecs/cs35l56.c:949:12: warning: 'cs35l56_runtime_resume_i2c_spi' defined but not used [-Wunused-function]
> > 949 | static int cs35l56_runtime_resume_i2c_spi(struct device *dev)
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >> sound/soc/codecs/cs35l56.c:942:12: warning: 'cs35l56_runtime_suspend_i2c_spi' defined but not used [-Wunused-function]
> > 942 | static int cs35l56_runtime_suspend_i2c_spi(struct device *dev)
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Those are conditionally exported symbols and I overlooked that
> CONFIG_SND_SOC_CS35L56_SDW may still enable CONFIG_SND_SOC_CS35L56
> without i2c/spi. So please drop the patch
> [PATCH 08/89] ASoC: cs35l56: Convert to RUNTIME_PM_OPS()
> Should I resubmit the series together with the typo corrections?
Ugh, actually this one is so early you may as well resubmit the entire
series :(
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [broonie-ci:20250313_tiwai_asoc_convert_to_modern_pm_macros 113/194] sound/soc/codecs/cs35l56.c:949:12: warning: 'cs35l56_runtime_resume_i2c_spi' defined but not used
2025-03-17 9:34 ` Mark Brown
@ 2025-03-17 9:36 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2025-03-17 9:36 UTC (permalink / raw)
To: Mark Brown; +Cc: Takashi Iwai, oe-kbuild-all, Charles Keepax
On Mon, 17 Mar 2025 10:34:33 +0100,
Mark Brown wrote:
>
> On Mon, Mar 17, 2025 at 08:42:48AM +0100, Takashi Iwai wrote:
>
> > > >> sound/soc/codecs/cs35l56.c:949:12: warning: 'cs35l56_runtime_resume_i2c_spi' defined but not used [-Wunused-function]
> > > 949 | static int cs35l56_runtime_resume_i2c_spi(struct device *dev)
> > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > >> sound/soc/codecs/cs35l56.c:942:12: warning: 'cs35l56_runtime_suspend_i2c_spi' defined but not used [-Wunused-function]
> > > 942 | static int cs35l56_runtime_suspend_i2c_spi(struct device *dev)
> > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> > Those are conditionally exported symbols and I overlooked that
> > CONFIG_SND_SOC_CS35L56_SDW may still enable CONFIG_SND_SOC_CS35L56
> > without i2c/spi. So please drop the patch
> > [PATCH 08/89] ASoC: cs35l56: Convert to RUNTIME_PM_OPS()
>
> > Should I resubmit the series together with the typo corrections?
>
> Ugh, actually this one is so early you may as well resubmit the entire
> series :(
OK, will do.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-17 9:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-17 3:41 [broonie-ci:20250313_tiwai_asoc_convert_to_modern_pm_macros 113/194] sound/soc/codecs/cs35l56.c:949:12: warning: 'cs35l56_runtime_resume_i2c_spi' defined but not used kernel test robot
2025-03-17 7:42 ` Takashi Iwai
2025-03-17 9:34 ` Mark Brown
2025-03-17 9:36 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.