From: Markus Armbruster <armbru@redhat.com>
To: CLEMENT MATHIEU--DRIF <clement.mathieu--drif@eviden.com>
Cc: "Yi Liu" <yi.l.liu@intel.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Bibo Mao" <maobibo@loongson.cn>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Zhenzhong Duan" <zhenzhong.duan@intel.com>
Subject: Re: Giving your own patches your Reviewed-by
Date: Thu, 13 Mar 2025 08:13:03 +0100 [thread overview]
Message-ID: <87h63xcsjk.fsf@pond.sub.org> (raw)
In-Reply-To: <542252f1-d4f5-41a7-badd-c17acd94e8bf@eviden.com> (CLEMENT MATHIEU--DRIF's message of "Thu, 13 Mar 2025 06:45:52 +0000")
CLEMENT MATHIEU--DRIF <clement.mathieu--drif@eviden.com> writes:
> On 12/03/2025 13:54, Yi Liu wrote:
[...]
>> Commit eda4c9b5b3c is the similar case. Zhenzhong and Clément took
>> the patch from me and I was cced when Zhenzhong sent it out. I gave
>> my r-b after reviewing it.
>
> Some other commits of the same series were in a similar situation:
> initially written by me and slightly changed by Zhenzhong.
> These are not caught by one-liner above because I deliberately didn't
> give an rb.
>
> According to Daniel it seems to be ok to review a co-authored patch but
> is this considered a last resort?
Ideally, patch review is a fresh look at things. If you can't get such
"outsider" review, and it's not for lack of trying, you work with the
maintainer to figure out what to do. If you *are* the maintainer, you
make a judgement call.
That said, recording meaningful work can't be wrong. If you feel you
did meaningful review work, go ahead and add your R-by.
next prev parent reply other threads:[~2025-03-13 7:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 9:45 Giving your own patches your Reviewed-by Markus Armbruster
2025-03-12 10:03 ` Philippe Mathieu-Daudé
2025-03-12 10:10 ` Markus Armbruster
2025-03-12 10:13 ` Daniel P. Berrangé
2025-03-12 12:54 ` Yi Liu
2025-03-13 6:45 ` CLEMENT MATHIEU--DRIF
2025-03-13 7:13 ` Markus Armbruster [this message]
2025-03-12 10:18 ` Philippe Mathieu-Daudé
2025-03-12 10:55 ` Markus Armbruster
2025-03-12 10:45 ` Daniel P. Berrangé
2025-03-12 10:56 ` Philippe Mathieu-Daudé
2025-03-13 1:21 ` bibo mao
2025-03-13 5:32 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h63xcsjk.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=clement.mathieu--drif@eviden.com \
--cc=maobibo@loongson.cn \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=yi.l.liu@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.