From: Markus Armbruster <armbru@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, Akihiko Odaki <akihiko.odaki@daynix.com>,
Bibo Mao <maobibo@loongson.cn>,
Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: Giving your own patches your Reviewed-by
Date: Wed, 12 Mar 2025 11:55:56 +0100 [thread overview]
Message-ID: <87o6y6jz5v.fsf@pond.sub.org> (raw)
In-Reply-To: <33ac4559-462a-4623-ae19-517ccf64381e@linaro.org> ("Philippe Mathieu-Daudé"'s message of "Wed, 12 Mar 2025 11:18:59 +0100")
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> Since you are looking at this, it reminds me an orthogonal discussion
> we refresh from time to time at the KVM forum conference: is it OK to
> merge unreviewed patches?
We should make an effort to get reviews.
If we can't get any within a reasonable time, merging can be okay.
"Reasonable time" depends on the patches. Shorter for a build fix than
for a new feature.
"Can be" also depends on the patches. How risky do they feel?
Judgement call. The first call should commonly be "try harder to get
reviews".
next prev parent reply other threads:[~2025-03-12 10:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 9:45 Giving your own patches your Reviewed-by Markus Armbruster
2025-03-12 10:03 ` Philippe Mathieu-Daudé
2025-03-12 10:10 ` Markus Armbruster
2025-03-12 10:13 ` Daniel P. Berrangé
2025-03-12 12:54 ` Yi Liu
2025-03-13 6:45 ` CLEMENT MATHIEU--DRIF
2025-03-13 7:13 ` Markus Armbruster
2025-03-12 10:18 ` Philippe Mathieu-Daudé
2025-03-12 10:55 ` Markus Armbruster [this message]
2025-03-12 10:45 ` Daniel P. Berrangé
2025-03-12 10:56 ` Philippe Mathieu-Daudé
2025-03-13 1:21 ` bibo mao
2025-03-13 5:32 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6y6jz5v.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=maobibo@loongson.cn \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.