From: Thomas Gleixner <tglx@linutronix.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
20241015061522.25288-1-rui.zhang@intel.com,
Zhang Rui <rui.zhang@intel.com>,
hpa@zytor.com, peterz@infradead.org, thorsten.blum@toblux.com,
yuntao.wang@linux.dev, tony.luck@intel.com, len.brown@intel.com,
srinivas.pandruvada@intel.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, rafael.j.wysocki@intel.com,
x86@kernel.org, linux-pm@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] modpost: Add .irqentry.text to OTHER_SECTIONS
Date: Tue, 03 Dec 2024 17:10:09 +0100 [thread overview]
Message-ID: <87h67ku4ri.ffs@tglx> (raw)
In-Reply-To: <CAK7LNARufW5wc=qBt5R=RJ9BkFirLKAgRgg_t=OmTTGbjLfsAg@mail.gmail.com>
On Wed, Dec 04 2024 at 00:27, Masahiro Yamada wrote:
> On Tue, Dec 3, 2024 at 6:03 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>> > In this mainline kernel, DEFINE_IDTENTRY_SYSVEC()
>> > expands to a normal .text function which is explicitly
>> > annotated 'noinline'.
>>
>> It's not annotated noinline, it's annotated 'noinstr', which puts the
>> code into the .noinstr.text section. That one is indeed covered.
>
> The callsite of local_apic_timer_interrupt() is annotated 'noinline'
> if I correctly understand this line:
> https://github.com/torvalds/linux/blob/v6.13-rc1/arch/x86/include/asm/idtentry.h#L272
You're right. I got lost in the macro maze and looked at the actual
sysvec_...() part.
>> So yes, the fix is only required for pre 5.8 kernels.
>
> This never occurs on x86 after commit f0178fc01fe46,
> but theoretically this may occur for other architectures.
Correct.
Thanks,
tglx
next prev parent reply other threads:[~2024-12-03 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 11:18 bisected: [PATCH V4] x86/apic: Always explicitly disarm TSC-deadline timer Sergey Senozhatsky
2024-11-28 11:22 ` Sergey Senozhatsky
2024-11-30 11:21 ` Thomas Gleixner
2024-11-30 11:45 ` Sergey Senozhatsky
2024-12-01 11:17 ` [PATCH] modpost: Add .irqentry.text to OTHER_SECTIONS Thomas Gleixner
2024-12-02 2:02 ` Masahiro Yamada
2024-12-02 21:03 ` Thomas Gleixner
2024-12-03 15:27 ` Masahiro Yamada
2024-12-03 16:10 ` Thomas Gleixner [this message]
2024-12-02 4:10 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h67ku4ri.ffs@tglx \
--to=tglx@linutronix.de \
--cc=20241015061522.25288-1-rui.zhang@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
--cc=senozhatsky@chromium.org \
--cc=srinivas.pandruvada@intel.com \
--cc=stable@vger.kernel.org \
--cc=thorsten.blum@toblux.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yuntao.wang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.