Re: [Intel-xe] [PATCH] drm/xe/mtl: Use 16.67 Mhz freq scale factor to get rpX

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Wed, 01 Nov 2023 09:32:12 -0700, Badal Nilawar wrote:
>
> For mtl and above 16.67 Mhz is the scale factor to calculate
> rpX frequencies.
>
> v2: Fix review comment (Ashutosh)

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

>
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_pc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
> index 74247e0d3674..020c6597cd78 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.c
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.c
> @@ -313,7 +313,7 @@ static void mtl_update_rpe_value(struct xe_guc_pc *pc)
>	else
>		reg = xe_mmio_read32(gt, MTL_GT_RPE_FREQUENCY);
>
> -	pc->rpe_freq = REG_FIELD_GET(MTL_RPE_MASK, reg) * GT_FREQUENCY_MULTIPLIER;
> +	pc->rpe_freq = decode_freq(REG_FIELD_GET(MTL_RPE_MASK, reg));
>  }
>
>  static void tgl_update_rpe_value(struct xe_guc_pc *pc)
> @@ -653,10 +653,10 @@ static void mtl_init_fused_rp_values(struct xe_guc_pc *pc)
>		reg = xe_mmio_read32(gt, MTL_MEDIAP_STATE_CAP);
>	else
>		reg = xe_mmio_read32(gt, MTL_RP_STATE_CAP);
> -	pc->rp0_freq = REG_FIELD_GET(MTL_RP0_CAP_MASK, reg) *
> -		GT_FREQUENCY_MULTIPLIER;
> -	pc->rpn_freq = REG_FIELD_GET(MTL_RPN_CAP_MASK, reg) *
> -		GT_FREQUENCY_MULTIPLIER;
> +
> +	pc->rp0_freq = decode_freq(REG_FIELD_GET(MTL_RP0_CAP_MASK, reg));
> +
> +	pc->rpn_freq = decode_freq(REG_FIELD_GET(MTL_RPN_CAP_MASK, reg));
>  }
>
>  static void tgl_init_fused_rp_values(struct xe_guc_pc *pc)
> --
> 2.25.1
>