All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Suraj Kandpal <suraj.kandpal@intel.com>,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [Intel-gfx] [PATCH v3 1/7] drm/dp_helper: Add helper to check DSC support with given o/p format
Date: Mon, 20 Mar 2023 10:59:15 +0200	[thread overview]
Message-ID: <87h6ufajdo.fsf@intel.com> (raw)
In-Reply-To: <20230309062855.393087-2-suraj.kandpal@intel.com>


Thomas, Maxime, Maarten, ack for merging this one via drm-intel?

BR,
Jani.



On Thu, 09 Mar 2023, Suraj Kandpal <suraj.kandpal@intel.com> wrote:
> From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>
> Add helper to check if the DP sink supports DSC with the given
> o/p format.
>
> v2: Add documentation for the helper. (Uma Shankar)
>
> v3: /** instead of  /* (Uma Shankar)
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> ---
>  include/drm/display/drm_dp_helper.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h
> index ab55453f2d2c..533d3ee7fe05 100644
> --- a/include/drm/display/drm_dp_helper.h
> +++ b/include/drm/display/drm_dp_helper.h
> @@ -194,6 +194,19 @@ drm_dp_dsc_sink_max_slice_width(const u8 dsc_dpcd[DP_DSC_RECEIVER_CAP_SIZE])
>  		DP_DSC_SLICE_WIDTH_MULTIPLIER;
>  }
>  
> +/**
> + * drm_dp_dsc_sink_supports_format() - check if sink supports DSC with given output format
> + * @dsc_dpcd : DSC-capability DPCDs of the sink
> + * @output_format: output_format which is to be checked
> + *
> + * Returns true if the sink supports DSC with the given output_format, false otherwise.
> + */
> +static inline bool
> +drm_dp_dsc_sink_supports_format(const u8 dsc_dpcd[DP_DSC_RECEIVER_CAP_SIZE], u8 output_format)
> +{
> +	return dsc_dpcd[DP_DSC_DEC_COLOR_FORMAT_CAP - DP_DSC_SUPPORT] & output_format;
> +}
> +
>  /* Forward Error Correction Support on DP 1.4 */
>  static inline bool
>  drm_dp_sink_supports_fec(const u8 fec_capable)

-- 
Jani Nikula, Intel Open Source Graphics Center

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Suraj Kandpal <suraj.kandpal@intel.com>,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, uma.shankar@intel.com,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH v3 1/7] drm/dp_helper: Add helper to check DSC support with given o/p format
Date: Mon, 20 Mar 2023 10:59:15 +0200	[thread overview]
Message-ID: <87h6ufajdo.fsf@intel.com> (raw)
In-Reply-To: <20230309062855.393087-2-suraj.kandpal@intel.com>


Thomas, Maxime, Maarten, ack for merging this one via drm-intel?

BR,
Jani.



On Thu, 09 Mar 2023, Suraj Kandpal <suraj.kandpal@intel.com> wrote:
> From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>
> Add helper to check if the DP sink supports DSC with the given
> o/p format.
>
> v2: Add documentation for the helper. (Uma Shankar)
>
> v3: /** instead of  /* (Uma Shankar)
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> ---
>  include/drm/display/drm_dp_helper.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h
> index ab55453f2d2c..533d3ee7fe05 100644
> --- a/include/drm/display/drm_dp_helper.h
> +++ b/include/drm/display/drm_dp_helper.h
> @@ -194,6 +194,19 @@ drm_dp_dsc_sink_max_slice_width(const u8 dsc_dpcd[DP_DSC_RECEIVER_CAP_SIZE])
>  		DP_DSC_SLICE_WIDTH_MULTIPLIER;
>  }
>  
> +/**
> + * drm_dp_dsc_sink_supports_format() - check if sink supports DSC with given output format
> + * @dsc_dpcd : DSC-capability DPCDs of the sink
> + * @output_format: output_format which is to be checked
> + *
> + * Returns true if the sink supports DSC with the given output_format, false otherwise.
> + */
> +static inline bool
> +drm_dp_dsc_sink_supports_format(const u8 dsc_dpcd[DP_DSC_RECEIVER_CAP_SIZE], u8 output_format)
> +{
> +	return dsc_dpcd[DP_DSC_DEC_COLOR_FORMAT_CAP - DP_DSC_SUPPORT] & output_format;
> +}
> +
>  /* Forward Error Correction Support on DP 1.4 */
>  static inline bool
>  drm_dp_sink_supports_fec(const u8 fec_capable)

-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2023-03-20  8:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09  6:28 [Intel-gfx] [PATCH v3 0/7] Enable YCbCr420 format for VDSC Suraj Kandpal
2023-03-09  6:28 ` Suraj Kandpal
2023-03-09  6:28 ` [Intel-gfx] [PATCH v3 1/7] drm/dp_helper: Add helper to check DSC support with given o/p format Suraj Kandpal
2023-03-09  6:28   ` Suraj Kandpal
2023-03-20  8:59   ` Jani Nikula [this message]
2023-03-20  8:59     ` Jani Nikula
2023-03-24 15:42     ` [Intel-gfx] " Maarten Lankhorst
2023-03-24 15:42       ` Maarten Lankhorst
2023-03-09  6:28 ` [Intel-gfx] [PATCH v3 2/7] drm/i915/dp: Check if DSC supports the given output_format Suraj Kandpal
2023-03-09  6:28   ` Suraj Kandpal
2023-03-09  6:28 ` [Intel-gfx] [PATCH v3 3/7] drm/i915/dsc: Adding the new registers for DSC Suraj Kandpal
2023-03-09  6:28   ` Suraj Kandpal
2023-03-09  6:28 ` [Intel-gfx] [PATCH v3 4/7] drm/i915/dsc: Enable YCbCr420 for VDSC Suraj Kandpal
2023-03-09  6:28   ` Suraj Kandpal
2023-03-09  6:28 ` [Intel-gfx] [PATCH v3 5/7] drm/i915/dsc: Fill in native_420 field Suraj Kandpal
2023-03-09  6:28   ` Suraj Kandpal
2023-03-09  6:28 ` [Intel-gfx] [PATCH v3 6/7] drm/i915/vdsc: Check slice design requirement Suraj Kandpal
2023-03-09  6:28   ` Suraj Kandpal
2023-03-09  6:28 ` [Intel-gfx] [PATCH v3 7/7] drm/i915/dsc: Add debugfs entry to validate DSC output formats Suraj Kandpal
2023-03-09  6:28   ` Suraj Kandpal
2023-03-09  7:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Enable YCbCr420 format for VDSC (rev3) Patchwork
2023-03-10 20:16 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6ufajdo.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mripard@kernel.org \
    --cc=suraj.kandpal@intel.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.