From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v3 4/9] drm/i915/perf: Group engines into respective OA groups
Date: Wed, 01 Mar 2023 16:36:25 -0800 [thread overview]
Message-ID: <87h6v43s6u.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20230228022329.3615793-5-umesh.nerlige.ramappa@intel.com>
On Mon, 27 Feb 2023 18:23:24 -0800, Umesh Nerlige Ramappa wrote:
>
> @@ -3378,12 +3376,13 @@ void i915_oa_init_reg_state(const struct intel_context *ce,
> const struct intel_engine_cs *engine)
> {
> struct i915_perf_stream *stream;
> + struct i915_perf_group *g = engine->oa_group;
>
> - if (!engine_supports_oa(engine))
> + if (!g)
Maybe leave the engine_supports_oa check here since the NULL oa_group check
is now implemented there.
Rest looks good to be overall so this is:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
next prev parent reply other threads:[~2023-03-02 0:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 2:23 [Intel-gfx] [PATCH v3 0/9] Add OAM support for MTL Umesh Nerlige Ramappa
2023-02-28 2:23 ` [Intel-gfx] [PATCH v3 1/9] drm/i915/perf: Drop wakeref on GuC RC error Umesh Nerlige Ramappa
2023-02-28 2:23 ` [Intel-gfx] [PATCH v3 2/9] drm/i915/perf: Add helper to check supported OA engines Umesh Nerlige Ramappa
2023-02-28 2:23 ` [Intel-gfx] [PATCH v3 3/9] drm/i915/perf: Validate OA sseu config outside switch Umesh Nerlige Ramappa
2023-02-28 2:23 ` [Intel-gfx] [PATCH v3 4/9] drm/i915/perf: Group engines into respective OA groups Umesh Nerlige Ramappa
2023-03-02 0:36 ` Dixit, Ashutosh [this message]
2023-02-28 2:23 ` [Intel-gfx] [PATCH v3 5/9] drm/i915/perf: Fail modprobe if i915_perf_init fails on OOM Umesh Nerlige Ramappa
2023-02-28 2:23 ` [Intel-gfx] [PATCH v3 6/9] drm/i915/perf: Parse 64bit report header formats correctly Umesh Nerlige Ramappa
2023-02-28 2:23 ` [Intel-gfx] [PATCH v3 7/9] drm/i915/perf: Handle non-power-of-2 reports Umesh Nerlige Ramappa
2023-02-28 22:55 ` Dixit, Ashutosh
2023-02-28 2:23 ` [Intel-gfx] [PATCH v3 8/9] drm/i915/perf: Add engine class instance parameters to perf Umesh Nerlige Ramappa
2023-03-01 21:59 ` Dixit, Ashutosh
2023-03-03 0:52 ` Umesh Nerlige Ramappa
2023-02-28 2:23 ` [Intel-gfx] [PATCH v3 9/9] drm/i915/perf: Add support for OA media units Umesh Nerlige Ramappa
2023-03-02 21:01 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6v43s6u.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.