From: Peter Korsgaard <peter@korsgaard.com>
To: Quentin Schulz <foss+buildroot@0leil.net>
Cc: Peter Seiderer <ps.report@gmx.net>,
Quentin Schulz <quentin.schulz@theobroma-systems.com>,
Joshua Henderson <joshua.henderson@microchip.com>,
Julien Corjon <corjon.j@ecagroup.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/qt5wayland: fix compilation when libxkbcommon is disabled
Date: Mon, 04 Apr 2022 14:30:20 +0200 [thread overview]
Message-ID: <87h779115v.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220328111413.1618964-2-foss+buildroot@0leil.net> (Quentin Schulz's message of "Mon, 28 Mar 2022 13:14:13 +0200")
>>>>> "Quentin" == Quentin Schulz <foss+buildroot@0leil.net> writes:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> When libxkbcommon is disabled, QT_CONFIG(xkbcommon) is not defined which
> means the variable and function pointer in this patch are compiled out
> from the header, but the cpp code actually still made use of it. This
> patch fixes the build issue when libxkbcommon package is not to be
> built.
> This patch was taken from (merged):
> https://codereview.qt-project.org/c/qt/qtwayland/+/344916
> Cc: Quentin Schulz <foss+buildroot@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-04-04 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 11:14 [Buildroot] [PATCH 1/2] package/qt5base: fix race with libxkbcommon Quentin Schulz
2022-03-28 11:14 ` [Buildroot] [PATCH 2/2] package/qt5wayland: fix compilation when libxkbcommon is disabled Quentin Schulz
2022-04-04 12:30 ` Peter Korsgaard [this message]
2022-03-28 19:54 ` [Buildroot] [PATCH 1/2] package/qt5base: fix race with libxkbcommon Arnout Vandecappelle
2022-04-04 12:30 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h779115v.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=corjon.j@ecagroup.com \
--cc=foss+buildroot@0leil.net \
--cc=joshua.henderson@microchip.com \
--cc=ps.report@gmx.net \
--cc=quentin.schulz@theobroma-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.