All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Quentin Schulz <foss+buildroot@0leil.net>
Cc: Peter Seiderer <ps.report@gmx.net>,
	Quentin Schulz <quentin.schulz@theobroma-systems.com>,
	Joshua Henderson <joshua.henderson@microchip.com>,
	Julien Corjon <corjon.j@ecagroup.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/qt5base: fix race with libxkbcommon
Date: Mon, 04 Apr 2022 14:30:10 +0200	[thread overview]
Message-ID: <87lewl1165.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220328111413.1618964-1-foss+buildroot@0leil.net> (Quentin Schulz's message of "Mon, 28 Mar 2022 13:14:12 +0200")

>>>>> "Quentin" == Quentin Schulz <foss+buildroot@0leil.net> writes:

 > From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
 > qt5wayland package currently has a bug if the xkbcommon Qt config is not
 > enabled which highlighted a race issues between qt5base, libxkbcommon
 > and qt5wayland.

 > qt5wayland has a dependency on libxkbcommon package if it's enabled.
 > qt5base only has a dependency on libxkbcommon if xcb support is to be
 > enabled.

 > If libxkbcommon package is built before qt5base, qt5base will detect it
 > during its configure step and enable the Qt config accordingly. This
 > will make it available to qt5wayland afterwards, even if xcb support is
 > not enabled in Buildroot Kconfig.

 > However, if qt5base is built before libxkbcommon is, qt5base will not
 > advertise support of xbcommon feature to qt5wayland (which will fail its
 > build because of a bug in the source code).

 > Since the package build order should not impact the outcome of the
 > build, let's explicit the dependency if and only if libxkbcommon package
 > is to be compiled at some point in time so that at least this feature is
 > not susceptible to races.

 > Cc: Quentin Schulz <foss+buildroot@0leil.net>
 > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2022-04-04 12:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 11:14 [Buildroot] [PATCH 1/2] package/qt5base: fix race with libxkbcommon Quentin Schulz
2022-03-28 11:14 ` [Buildroot] [PATCH 2/2] package/qt5wayland: fix compilation when libxkbcommon is disabled Quentin Schulz
2022-04-04 12:30   ` Peter Korsgaard
2022-03-28 19:54 ` [Buildroot] [PATCH 1/2] package/qt5base: fix race with libxkbcommon Arnout Vandecappelle
2022-04-04 12:30 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lewl1165.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=corjon.j@ecagroup.com \
    --cc=foss+buildroot@0leil.net \
    --cc=joshua.henderson@microchip.com \
    --cc=ps.report@gmx.net \
    --cc=quentin.schulz@theobroma-systems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.