From: Felipe Balbi <balbi@kernel.org>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: pxa25x_udc: Constify static struct pxa25x_ep_ops
Date: Wed, 28 Jul 2021 12:25:14 +0300 [thread overview]
Message-ID: <87h7geu6x1.fsf@kernel.org> (raw)
In-Reply-To: <20210728092052.4178-1-rikard.falkeborn@gmail.com>
Rikard Falkeborn <rikard.falkeborn@gmail.com> writes:
> The struct pxa25x_ep_ops is only assigned to the ops field in the
> usb_ep struct, which is a pointer to const struct usb_ep_ops.
> Make it const to allow the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: pxa25x_udc: Constify static struct pxa25x_ep_ops
Date: Wed, 28 Jul 2021 12:25:14 +0300 [thread overview]
Message-ID: <87h7geu6x1.fsf@kernel.org> (raw)
In-Reply-To: <20210728092052.4178-1-rikard.falkeborn@gmail.com>
Rikard Falkeborn <rikard.falkeborn@gmail.com> writes:
> The struct pxa25x_ep_ops is only assigned to the ops field in the
> usb_ep struct, which is a pointer to const struct usb_ep_ops.
> Make it const to allow the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-28 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 9:20 [PATCH] usb: gadget: pxa25x_udc: Constify static struct pxa25x_ep_ops Rikard Falkeborn
2021-07-28 9:20 ` Rikard Falkeborn
2021-07-28 9:25 ` Felipe Balbi [this message]
2021-07-28 9:25 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7geu6x1.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=daniel@zonque.org \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.