Re: [PATCH V2 12/12] ASoC: amd: enable vangogh acp5x driver build

[Gabriel Krisman Bertazi <krisman@collabora.com>]

Hi,

Vijendar Mukunda <vijendar.mukunda@amd.com> writes:
> Vangogh ACP5x drivers can be built by selecting necessary
> kernel config option.
> The patch enables build support of the same.
>
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
> v1 -> v2: remove extra line in Make file
> ---
>  sound/soc/amd/Kconfig          |  9 +++++++++
>  sound/soc/amd/Makefile         |  1 +
>  sound/soc/amd/vangogh/Makefile | 11 +++++++++++
>  3 files changed, 21 insertions(+)
>  create mode 100644 sound/soc/amd/vangogh/Makefile
>
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index ba5a85bf7412..cc48d4e5b080 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -52,3 +52,12 @@ config SND_SOC_AMD_RENOIR_MACH
>  	depends on SND_SOC_AMD_RENOIR
>  	help
>  	 This option enables machine driver for DMIC
> +
> +config SND_SOC_AMD_ACP5x
> +	tristate "AMD Audio Coprocessor-v5.x I2S support"
> +	depends on X86 && PCI
> +	help
> +	 This option enables ACP v5.x support on AMD platform
> +
> +	 By enabling this flag build will trigger for ACP PCI driver,
> +	 ACP DMA drvier, CPU DAI driver.
> diff --git a/sound/soc/amd/Makefile b/sound/soc/amd/Makefile
> index e6df2f72a2a1..07150d26f315 100644
> --- a/sound/soc/amd/Makefile
> +++ b/sound/soc/amd/Makefile
> @@ -10,3 +10,4 @@ obj-$(CONFIG_SND_SOC_AMD_CZ_RT5645_MACH) += snd-soc-acp-rt5645-mach.o
>  obj-$(CONFIG_SND_SOC_AMD_ACP3x) += raven/
>  obj-$(CONFIG_SND_SOC_AMD_RV_RT5682_MACH) += snd-soc-acp-rt5682-mach.o
>  obj-$(CONFIG_SND_SOC_AMD_RENOIR) += renoir/
> +obj-$(CONFIG_SND_SOC_AMD_ACP5x) += vangogh/
> diff --git a/sound/soc/amd/vangogh/Makefile b/sound/soc/amd/vangogh/Makefile
> new file mode 100644
> index 000000000000..ae2cda804e2f
> --- /dev/null
> +++ b/sound/soc/amd/vangogh/Makefile
> @@ -0,0 +1,11 @@
> +# SPDX-License-Identifier: GPL-2.0+
> +# Vangogh platform Support
> +snd-pci-acp5x-objs	:= pci-acp5x.o
> +snd-acp5x-i2s-objs	:= acp5x-i2s.o
> +snd-acp5x-pcm-dma-objs	:= acp5x-pcm-dma.o
> +snd-soc-acp5x-mach-objs := acp5x-nu8821-cs35l41.o
> +
> +obj-$(CONFIG_SND_SOC_AMD_ACP5x) += snd-pci-acp5x.o
> +obj-$(CONFIG_SND_SOC_AMD_ACP5x)	+= snd-acp5x-i2s.o
> +obj-$(CONFIG_SND_SOC_AMD_ACP5x) += snd-acp5x-pcm-dma.o
> +obj-$(CONFIG_SND_SOC_AMD_VANGOGH_MACH)   += snd-soc-acp5x-mach.o

Looks like CONFIG_SND_SOC_AMD_VANGOGH_MACH is not selected by another
symbol and also not configurable in kconfig.

Is it missing a kconfig entry?

-- 
Gabriel Krisman Bertazi