From: Richard Palethorpe <rpalethorpe@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [f2fs] 02eb84b96b: ltp.swapon03.fail
Date: Mon, 08 Mar 2021 11:53:09 +0000 [thread overview]
Message-ID: <87h7llhnfe.fsf@suse.de> (raw)
In-Reply-To: <20210308072510.GA902@xsang-OptiPlex-9020>
Hello,
> kern :err : [ 187.461914] F2FS-fs (sda1): Swapfile does not align to section
> commit 02eb84b96bc1b382dd138bf60724edbefe77b025
> Author: huangjianan@oppo.com <huangjianan@oppo.com>
> Date: Mon Mar 1 12:58:44 2021 +0800
> f2fs: check if swapfile is section-alligned
> If the swapfile isn't created by pin and fallocate, it can't be
> guaranteed section-aligned, so it may be selected by f2fs gc. When
> gc_pin_file_threshold is reached, the address of swapfile may change,
> but won't be synchronized to swap_extent, so swap will write to wrong
> address, which will cause data corruption.
> Signed-off-by: Huang Jianan <huangjianan@oppo.com>
> Signed-off-by: Guo Weichao <guoweichao@oppo.com>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
The test uses fallocate to preallocate the swap file and writes zeros to
it. I'm not sure what pin refers to?
--
Thank you,
Richard.
WARNING: multiple messages have this Message-ID (diff)
From: Richard Palethorpe <rpalethorpe@suse.de>
To: lkp@lists.01.org
Subject: Re: [LTP] [f2fs] 02eb84b96b: ltp.swapon03.fail
Date: Mon, 08 Mar 2021 11:53:09 +0000 [thread overview]
Message-ID: <87h7llhnfe.fsf@suse.de> (raw)
In-Reply-To: <20210308072510.GA902@xsang-OptiPlex-9020>
[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]
Hello,
> kern :err : [ 187.461914] F2FS-fs (sda1): Swapfile does not align to section
> commit 02eb84b96bc1b382dd138bf60724edbefe77b025
> Author: huangjianan(a)oppo.com <huangjianan@oppo.com>
> Date: Mon Mar 1 12:58:44 2021 +0800
> f2fs: check if swapfile is section-alligned
> If the swapfile isn't created by pin and fallocate, it can't be
> guaranteed section-aligned, so it may be selected by f2fs gc. When
> gc_pin_file_threshold is reached, the address of swapfile may change,
> but won't be synchronized to swap_extent, so swap will write to wrong
> address, which will cause data corruption.
> Signed-off-by: Huang Jianan <huangjianan@oppo.com>
> Signed-off-by: Guo Weichao <guoweichao@oppo.com>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
The test uses fallocate to preallocate the swap file and writes zeros to
it. I'm not sure what pin refers to?
--
Thank you,
Richard.
WARNING: multiple messages have this Message-ID (diff)
From: Richard Palethorpe <rpalethorpe@suse.de>
To: kernel test robot <oliver.sang@intel.com>
Cc: "huangjianan@oppo.com" <huangjianan@oppo.com>,
lkp@intel.com, Linux Memory Management List <linux-mm@kvack.org>,
Chao Yu <yuchao0@huawei.com>, LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Guo Weichao <guoweichao@oppo.com>,
ltp@lists.linux.it
Subject: Re: [LTP] [f2fs] 02eb84b96b: ltp.swapon03.fail
Date: Mon, 08 Mar 2021 11:53:09 +0000 [thread overview]
Message-ID: <87h7llhnfe.fsf@suse.de> (raw)
In-Reply-To: <20210308072510.GA902@xsang-OptiPlex-9020>
Hello,
> kern :err : [ 187.461914] F2FS-fs (sda1): Swapfile does not align to section
> commit 02eb84b96bc1b382dd138bf60724edbefe77b025
> Author: huangjianan@oppo.com <huangjianan@oppo.com>
> Date: Mon Mar 1 12:58:44 2021 +0800
> f2fs: check if swapfile is section-alligned
> If the swapfile isn't created by pin and fallocate, it can't be
> guaranteed section-aligned, so it may be selected by f2fs gc. When
> gc_pin_file_threshold is reached, the address of swapfile may change,
> but won't be synchronized to swap_extent, so swap will write to wrong
> address, which will cause data corruption.
> Signed-off-by: Huang Jianan <huangjianan@oppo.com>
> Signed-off-by: Guo Weichao <guoweichao@oppo.com>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
The test uses fallocate to preallocate the swap file and writes zeros to
it. I'm not sure what pin refers to?
--
Thank you,
Richard.
next prev parent reply other threads:[~2021-03-08 11:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 7:25 [LTP] [f2fs] 02eb84b96b: ltp.swapon03.fail kernel test robot
2021-03-08 7:25 ` kernel test robot
2021-03-08 7:25 ` kernel test robot
2021-03-08 11:53 ` Richard Palethorpe [this message]
2021-03-08 11:53 ` [LTP] " Richard Palethorpe
2021-03-08 11:53 ` Richard Palethorpe
2021-03-09 2:23 ` Weichao Guo
2021-03-09 2:23 ` Weichao Guo
2021-03-09 2:23 ` Weichao Guo
2021-03-09 4:01 ` Matthew Wilcox
2021-03-09 4:01 ` Matthew Wilcox
2021-03-09 4:01 ` Matthew Wilcox
2021-03-10 2:32 ` Huang Jianan
2021-03-10 2:32 ` Huang Jianan
2021-03-10 2:32 ` Huang Jianan
2021-03-10 20:49 ` Jaegeuk Kim
2021-03-10 20:49 ` Jaegeuk Kim
2021-03-10 20:49 ` Jaegeuk Kim
2021-03-23 9:04 ` Chao Yu
2021-03-23 9:04 ` Chao Yu
2021-03-23 9:04 ` Chao Yu
2021-04-29 13:08 ` Weichao Guo
2021-04-29 13:08 ` Weichao Guo
2021-04-29 13:08 ` Weichao Guo
2021-04-30 1:48 ` Gao Xiang
2021-04-30 1:48 ` Gao Xiang
2021-04-30 1:48 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7llhnfe.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.