From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 1/2] i915/gem_exec_whisper: Reopen existing device
Date: Wed, 04 Nov 2020 17:49:38 -0800 [thread overview]
Message-ID: <87h7q4o9n1.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20201105002124.37888-1-chris@chris-wilson.co.uk>
On Wed, 04 Nov 2020 16:21:23 -0800, Chris Wilson wrote:
>
> Reopen the existing device, rather than relying on the filtering in
> drm_open_driver().
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_exec_whisper.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/i915/gem_exec_whisper.c b/tests/i915/gem_exec_whisper.c
> index 9acf6c306..b63d791d1 100644
> --- a/tests/i915/gem_exec_whisper.c
> +++ b/tests/i915/gem_exec_whisper.c
> @@ -87,12 +87,12 @@ struct hang {
> int fd;
> };
>
> -static void init_hang(struct hang *h)
> +static void init_hang(struct hang *h, int fd)
> {
> uint32_t *batch;
> int i, gen;
>
> - h->fd = drm_open_driver(DRIVER_INTEL);
> + h->fd = gem_reopen_driver(fd);
> igt_allow_hang(h->fd, 0, 0);
>
> gen = intel_gen(intel_get_drm_devid(h->fd));
> @@ -224,7 +224,7 @@ static void whisper(int fd, unsigned engine, unsigned flags)
> igt_require(gem_has_queues(fd));
>
> if (flags & HANG)
> - init_hang(&hang);
> + init_hang(&hang, fd);
>
> nchild = 1;
> if (flags & FORKED)
> @@ -304,7 +304,7 @@ static void whisper(int fd, unsigned engine, unsigned flags)
> }
> if (flags & FDS) {
> for (n = 0; n < 64; n++)
> - fds[n] = drm_open_driver(DRIVER_INTEL);
> + fds[n] = gem_reopen_driver(fd);
> }
>
> memset(batches, 0, sizeof(batches));
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
WARNING: multiple messages have this Message-ID (diff)
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t 1/2] i915/gem_exec_whisper: Reopen existing device
Date: Wed, 04 Nov 2020 17:49:38 -0800 [thread overview]
Message-ID: <87h7q4o9n1.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20201105002124.37888-1-chris@chris-wilson.co.uk>
On Wed, 04 Nov 2020 16:21:23 -0800, Chris Wilson wrote:
>
> Reopen the existing device, rather than relying on the filtering in
> drm_open_driver().
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_exec_whisper.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/i915/gem_exec_whisper.c b/tests/i915/gem_exec_whisper.c
> index 9acf6c306..b63d791d1 100644
> --- a/tests/i915/gem_exec_whisper.c
> +++ b/tests/i915/gem_exec_whisper.c
> @@ -87,12 +87,12 @@ struct hang {
> int fd;
> };
>
> -static void init_hang(struct hang *h)
> +static void init_hang(struct hang *h, int fd)
> {
> uint32_t *batch;
> int i, gen;
>
> - h->fd = drm_open_driver(DRIVER_INTEL);
> + h->fd = gem_reopen_driver(fd);
> igt_allow_hang(h->fd, 0, 0);
>
> gen = intel_gen(intel_get_drm_devid(h->fd));
> @@ -224,7 +224,7 @@ static void whisper(int fd, unsigned engine, unsigned flags)
> igt_require(gem_has_queues(fd));
>
> if (flags & HANG)
> - init_hang(&hang);
> + init_hang(&hang, fd);
>
> nchild = 1;
> if (flags & FORKED)
> @@ -304,7 +304,7 @@ static void whisper(int fd, unsigned engine, unsigned flags)
> }
> if (flags & FDS) {
> for (n = 0; n < 64; n++)
> - fds[n] = drm_open_driver(DRIVER_INTEL);
> + fds[n] = gem_reopen_driver(fd);
> }
>
> memset(batches, 0, sizeof(batches));
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-11-05 1:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 0:21 [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_whisper: Reopen existing device Chris Wilson
2020-11-05 0:21 ` [Intel-gfx] " Chris Wilson
2020-11-05 0:21 ` [igt-dev] [PATCH i-g-t 2/2] i915/gem_ctx_thrash: Reopen the same device Chris Wilson
2020-11-05 0:21 ` [Intel-gfx] " Chris Wilson
2020-11-05 1:51 ` [igt-dev] " Dixit, Ashutosh
2020-11-05 1:51 ` Dixit, Ashutosh
2020-11-05 1:25 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] i915/gem_exec_whisper: Reopen existing device Patchwork
2020-11-05 1:49 ` Dixit, Ashutosh [this message]
2020-11-05 1:49 ` [Intel-gfx] [PATCH i-g-t 1/2] " Dixit, Ashutosh
2020-11-05 4:35 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7q4o9n1.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.