All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: kernel test robot <lkp@intel.com>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
	kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Felix Fietkau <nbd@nbd.name>,
	linux-wireless@vger.kernel.org
Subject: Re: drivers/net/wireless/mediatek/mt76/pci.c:8:6: warning: no previous prototype for 'mt76_pci_disable_aspm'
Date: Fri, 12 Jun 2020 10:54:11 +0300	[thread overview]
Message-ID: <87h7vgk9cs.fsf@codeaurora.org> (raw)
In-Reply-To: <202006121458.U2yugTnM%lkp@intel.com> (kernel test robot's message of "Fri, 12 Jun 2020 14:35:01 +0800")

+ linux-wireless

kernel test robot <lkp@intel.com> writes:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   b791d1bdf9212d944d749a5c7ff6febdba241771
> commit: f37f05503575c59020dacd36e999f4e8b3dbc115 mt76: mt76x2e: disable pcie_aspm by default
> date:   8 months ago
> config: microblaze-randconfig-r023-20200612 (attached as .config)
> compiler: microblaze-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout f37f05503575c59020dacd36e999f4e8b3dbc115
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze 
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>, old ones prefixed by <<):
>
>>> drivers/net/wireless/mediatek/mt76/pci.c:8:6: warning: no previous prototype for 'mt76_pci_disable_aspm' [-Wmissing-prototypes]
> 8 | void mt76_pci_disable_aspm(struct pci_dev *pdev)
> |      ^~~~~~~~~~~~~~~~~~~~~
>
> vim +/mt76_pci_disable_aspm +8 drivers/net/wireless/mediatek/mt76/pci.c
>
>      7	
>    > 8	void mt76_pci_disable_aspm(struct pci_dev *pdev)

Looks like "include mt76.h" is missing in pci.c. Can someone send a
patch, please?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: kbuild-all@lists.01.org
Subject: Re: drivers/net/wireless/mediatek/mt76/pci.c:8:6: warning: no previous prototype for 'mt76_pci_disable_aspm'
Date: Fri, 12 Jun 2020 10:54:11 +0300	[thread overview]
Message-ID: <87h7vgk9cs.fsf@codeaurora.org> (raw)
In-Reply-To: <202006121458.U2yugTnM%lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]

+ linux-wireless

kernel test robot <lkp@intel.com> writes:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   b791d1bdf9212d944d749a5c7ff6febdba241771
> commit: f37f05503575c59020dacd36e999f4e8b3dbc115 mt76: mt76x2e: disable pcie_aspm by default
> date:   8 months ago
> config: microblaze-randconfig-r023-20200612 (attached as .config)
> compiler: microblaze-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout f37f05503575c59020dacd36e999f4e8b3dbc115
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze 
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>, old ones prefixed by <<):
>
>>> drivers/net/wireless/mediatek/mt76/pci.c:8:6: warning: no previous prototype for 'mt76_pci_disable_aspm' [-Wmissing-prototypes]
> 8 | void mt76_pci_disable_aspm(struct pci_dev *pdev)
> |      ^~~~~~~~~~~~~~~~~~~~~
>
> vim +/mt76_pci_disable_aspm +8 drivers/net/wireless/mediatek/mt76/pci.c
>
>      7	
>    > 8	void mt76_pci_disable_aspm(struct pci_dev *pdev)

Looks like "include mt76.h" is missing in pci.c. Can someone send a
patch, please?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2020-06-12  7:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12  6:35 drivers/net/wireless/mediatek/mt76/pci.c:8:6: warning: no previous prototype for 'mt76_pci_disable_aspm' kernel test robot
2020-06-12  6:35 ` kernel test robot
2020-06-12  7:54 ` Kalle Valo [this message]
2020-06-12  7:54   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7vgk9cs.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.