From: Kalle Valo <kvalo@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, ath11k@lists.infradead.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set_throttling
Date: Thu, 09 Apr 2020 11:50:01 +0300 [thread overview]
Message-ID: <87h7xtujpi.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200408190606.870098-1-arnd@arndb.de> (Arnd Bergmann's message of "Wed, 8 Apr 2020 21:05:57 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> The empty stub version of this function causes a compile-time
> warning:
>
> In file included from drivers/net/wireless/ath/ath11k/core.h:23,
> from drivers/net/wireless/ath/ath11k/dp_rx.h:8,
> from drivers/net/wireless/ath/ath11k/ce.c:6:
> drivers/net/wireless/ath/ath11k/thermal.h: In function 'ath11k_thermal_set_throttling':
> drivers/net/wireless/ath/ath11k/thermal.h:45:1: error: no return statement in function returning non-void [-Werror=return-type]
>
> Just return success here.
>
> Fixes: a41d10348b01 ("ath11k: add thermal sensor device support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/wireless/ath/ath11k/thermal.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/ath11k/thermal.h b/drivers/net/wireless/ath/ath11k/thermal.h
> index 459b8d49c184..f1395a14748c 100644
> --- a/drivers/net/wireless/ath/ath11k/thermal.h
> +++ b/drivers/net/wireless/ath/ath11k/thermal.h
> @@ -42,6 +42,7 @@ static inline void ath11k_thermal_unregister(struct ath11k *ar)
>
> static inline int ath11k_thermal_set_throttling(struct ath11k *ar, u32 throttle_state)
> {
> + return 0;
> }
Already fixed by this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=c9be1a642a7b9ec021e3f32e084dc781b3e5216d
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
ath11k@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set_throttling
Date: Thu, 09 Apr 2020 11:50:01 +0300 [thread overview]
Message-ID: <87h7xtujpi.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200408190606.870098-1-arnd@arndb.de> (Arnd Bergmann's message of "Wed, 8 Apr 2020 21:05:57 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> The empty stub version of this function causes a compile-time
> warning:
>
> In file included from drivers/net/wireless/ath/ath11k/core.h:23,
> from drivers/net/wireless/ath/ath11k/dp_rx.h:8,
> from drivers/net/wireless/ath/ath11k/ce.c:6:
> drivers/net/wireless/ath/ath11k/thermal.h: In function 'ath11k_thermal_set_throttling':
> drivers/net/wireless/ath/ath11k/thermal.h:45:1: error: no return statement in function returning non-void [-Werror=return-type]
>
> Just return success here.
>
> Fixes: a41d10348b01 ("ath11k: add thermal sensor device support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/wireless/ath/ath11k/thermal.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/ath11k/thermal.h b/drivers/net/wireless/ath/ath11k/thermal.h
> index 459b8d49c184..f1395a14748c 100644
> --- a/drivers/net/wireless/ath/ath11k/thermal.h
> +++ b/drivers/net/wireless/ath/ath11k/thermal.h
> @@ -42,6 +42,7 @@ static inline void ath11k_thermal_unregister(struct ath11k *ar)
>
> static inline int ath11k_thermal_set_throttling(struct ath11k *ar, u32 throttle_state)
> {
> + return 0;
> }
Already fixed by this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=c9be1a642a7b9ec021e3f32e084dc781b3e5216d
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-04-09 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 19:05 [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set_throttling Arnd Bergmann
2020-04-08 19:05 ` Arnd Bergmann
2020-04-08 19:05 ` [PATCH 2/2] ath11k: fix ath11k_thermal_unregister() prototype Arnd Bergmann
2020-04-08 19:05 ` Arnd Bergmann
2020-04-09 8:50 ` Kalle Valo
2020-04-09 8:50 ` Kalle Valo
2020-04-09 8:50 ` Kalle Valo [this message]
2020-04-09 8:50 ` [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set_throttling Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7xtujpi.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pradeepc@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.