All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/4] drm/i915/dsc: make parameter arrays const
Date: Tue, 05 Nov 2019 15:14:12 +0200	[thread overview]
Message-ID: <87h83i79ej.fsf@intel.com> (raw)
In-Reply-To: <20191104222315.GC32264@intel.com>

On Mon, 04 Nov 2019, Manasi Navare <manasi.d.navare@intel.com> wrote:
> On Mon, Nov 04, 2019 at 04:14:36PM +0200, Jani Nikula wrote:
>> No need for them to be mutable.
>> 
>> Cc: Manasi Navare <manasi.d.navare@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Agree that these params are constants
>
> Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>

Thanks for the review, pushed the series to dinq.

BR,
Jani.

>
> Manasi
>
>> ---
>>  drivers/gpu/drm/i915/display/intel_vdsc.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
>> index 9cb36f855f07..763f1d7208e9 100644
>> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
>> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
>> @@ -33,7 +33,7 @@ enum COLUMN_INDEX_BPC {
>>  #define DSC_SUPPORTED_VERSION_MIN		1
>>  
>>  /* From DSC_v1.11 spec, rc_parameter_Set syntax element typically constant */
>> -static u16 rc_buf_thresh[] = {
>> +static const u16 rc_buf_thresh[] = {
>>  	896, 1792, 2688, 3584, 4480, 5376, 6272, 6720, 7168, 7616,
>>  	7744, 7872, 8000, 8064
>>  };
>> @@ -53,7 +53,7 @@ struct rc_parameters {
>>   * Selected Rate Control Related Parameter Recommended Values
>>   * from DSC_v1.11 spec & C Model release: DSC_model_20161212
>>   */
>> -static struct rc_parameters rc_params[][MAX_COLUMN_INDEX] = {
>> +static const struct rc_parameters rc_params[][MAX_COLUMN_INDEX] = {
>>  {
>>  	/* 6BPP/8BPC */
>>  	{ 768, 15, 6144, 3, 13, 11, 11, {
>> -- 
>> 2.20.1
>> 

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/dsc: make parameter arrays const
Date: Tue, 05 Nov 2019 15:14:12 +0200	[thread overview]
Message-ID: <87h83i79ej.fsf@intel.com> (raw)
Message-ID: <20191105131412.xoFVDINIx3jWMUzOOr0f9Zh28Z8osu5Ytj1q7xP9K_0@z> (raw)
In-Reply-To: <20191104222315.GC32264@intel.com>

On Mon, 04 Nov 2019, Manasi Navare <manasi.d.navare@intel.com> wrote:
> On Mon, Nov 04, 2019 at 04:14:36PM +0200, Jani Nikula wrote:
>> No need for them to be mutable.
>> 
>> Cc: Manasi Navare <manasi.d.navare@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Agree that these params are constants
>
> Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>

Thanks for the review, pushed the series to dinq.

BR,
Jani.

>
> Manasi
>
>> ---
>>  drivers/gpu/drm/i915/display/intel_vdsc.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
>> index 9cb36f855f07..763f1d7208e9 100644
>> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
>> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
>> @@ -33,7 +33,7 @@ enum COLUMN_INDEX_BPC {
>>  #define DSC_SUPPORTED_VERSION_MIN		1
>>  
>>  /* From DSC_v1.11 spec, rc_parameter_Set syntax element typically constant */
>> -static u16 rc_buf_thresh[] = {
>> +static const u16 rc_buf_thresh[] = {
>>  	896, 1792, 2688, 3584, 4480, 5376, 6272, 6720, 7168, 7616,
>>  	7744, 7872, 8000, 8064
>>  };
>> @@ -53,7 +53,7 @@ struct rc_parameters {
>>   * Selected Rate Control Related Parameter Recommended Values
>>   * from DSC_v1.11 spec & C Model release: DSC_model_20161212
>>   */
>> -static struct rc_parameters rc_params[][MAX_COLUMN_INDEX] = {
>> +static const struct rc_parameters rc_params[][MAX_COLUMN_INDEX] = {
>>  {
>>  	/* 6BPP/8BPC */
>>  	{ 768, 15, 6144, 3, 13, 11, 11, {
>> -- 
>> 2.20.1
>> 

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-11-05 13:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 14:14 [PATCH v2 1/4] drm/i915/dsc: make parameter arrays const Jani Nikula
2019-11-04 14:14 ` [Intel-gfx] " Jani Nikula
2019-11-04 14:14 ` [PATCH v2 2/4] drm/i915/dsc: clean up rc parameter table access Jani Nikula
2019-11-04 14:14   ` [Intel-gfx] " Jani Nikula
2019-11-05  0:27   ` Manasi Navare
2019-11-05  0:27     ` [Intel-gfx] " Manasi Navare
2019-11-04 14:14 ` [PATCH v2 3/4] drm/i915/dsc: split out encoder specific parts from DSC compute params Jani Nikula
2019-11-04 14:14   ` [Intel-gfx] " Jani Nikula
2019-11-04 22:41   ` Manasi Navare
2019-11-04 22:41     ` [Intel-gfx] " Manasi Navare
2019-11-04 14:14 ` [PATCH v2 4/4] drm/i915/dsc: rename functions for consistency Jani Nikula
2019-11-04 14:14   ` [Intel-gfx] " Jani Nikula
2019-11-04 22:27   ` Manasi Navare
2019-11-04 22:27     ` [Intel-gfx] " Manasi Navare
2019-11-05  5:53     ` Jani Nikula
2019-11-05  5:53       ` [Intel-gfx] " Jani Nikula
2019-11-04 15:57 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/4] drm/i915/dsc: make parameter arrays const Patchwork
2019-11-04 15:57   ` [Intel-gfx] " Patchwork
2019-11-04 22:23 ` [PATCH v2 1/4] " Manasi Navare
2019-11-04 22:23   ` [Intel-gfx] " Manasi Navare
2019-11-05 13:14   ` Jani Nikula [this message]
2019-11-05 13:14     ` Jani Nikula
2019-11-05 11:32 ` ✓ Fi.CI.IGT: success for series starting with [v2,1/4] " Patchwork
2019-11-05 11:32   ` [Intel-gfx] " Patchwork
2019-11-05 13:25 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/4] drm/i915/dsc: make parameter arrays const (rev2) Patchwork
2019-11-05 13:25   ` [Intel-gfx] " Patchwork
2019-11-06  0:46 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-06  0:46   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h83i79ej.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=manasi.d.navare@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.