From: Nathan Lynch <nathanl@linux.ibm.com>
To: Tyrel Datwyler <tyreld@linux.ibm.com>
Cc: linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
mpe@ellerman.id.au, bhelgaas@google.com
Subject: Re: [RFC PATCH 1/9] powerpc/pseries: add cpu DLPAR support for drc-info property
Date: Thu, 31 Oct 2019 12:14:31 -0500 [thread overview]
Message-ID: <87h83oltvs.fsf@linux.ibm.com> (raw)
In-Reply-To: <9f7906d9-ef9b-4aa0-a5d6-428f19060919@linux.ibm.com>
Tyrel Datwyler <tyreld@linux.ibm.com> writes:
> On 10/10/19 11:56 AM, Nathan Lynch wrote:
>> As an aside I don't understand how the add_by_count()/dlpar_cpu_exists()
>> algorithm could be correct as it currently stands. It seems to pick the
>> first X indexes for which a corresponding cpu node is absent, but that
>> set of indexes does not necessarily match the set that is available to
>> configure. Something to address separately I suppose.
>
> I'm not sure I follow?
Don't worry about it for this patchset, it's just something I noticed
when reviewing. I'm wondering why the cpu add algorithm doesn't work
more like the one for memory, which actually queries the platform for
connector status via dlpar_acquire_drc(). It's possible I'm
misunderstanding something though. Like I said, I think it's something
to address separately if there is indeed an issue.
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Lynch <nathanl@linux.ibm.com>
To: Tyrel Datwyler <tyreld@linux.ibm.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH 1/9] powerpc/pseries: add cpu DLPAR support for drc-info property
Date: Thu, 31 Oct 2019 12:14:31 -0500 [thread overview]
Message-ID: <87h83oltvs.fsf@linux.ibm.com> (raw)
In-Reply-To: <9f7906d9-ef9b-4aa0-a5d6-428f19060919@linux.ibm.com>
Tyrel Datwyler <tyreld@linux.ibm.com> writes:
> On 10/10/19 11:56 AM, Nathan Lynch wrote:
>> As an aside I don't understand how the add_by_count()/dlpar_cpu_exists()
>> algorithm could be correct as it currently stands. It seems to pick the
>> first X indexes for which a corresponding cpu node is absent, but that
>> set of indexes does not necessarily match the set that is available to
>> configure. Something to address separately I suppose.
>
> I'm not sure I follow?
Don't worry about it for this patchset, it's just something I noticed
when reviewing. I'm wondering why the cpu add algorithm doesn't work
more like the one for memory, which actually queries the platform for
connector status via dlpar_acquire_drc(). It's possible I'm
misunderstanding something though. Like I said, I think it's something
to address separately if there is indeed an issue.
next prev parent reply other threads:[~2019-10-31 17:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 6:12 [RFC PATCH 0/9] Fixes and Enablement of ibm,drc-info property Tyrel Datwyler
2019-10-01 6:12 ` Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 1/9] powerpc/pseries: add cpu DLPAR support for drc-info property Tyrel Datwyler
2019-10-01 6:12 ` Tyrel Datwyler
2019-10-10 18:56 ` Nathan Lynch
2019-10-10 18:56 ` Nathan Lynch
2019-10-30 23:35 ` Tyrel Datwyler
2019-10-30 23:35 ` Tyrel Datwyler
2019-10-31 17:14 ` Nathan Lynch [this message]
2019-10-31 17:14 ` Nathan Lynch
2019-10-01 6:12 ` [RFC PATCH 2/9] powerpc/pseries: fix bad drc_index_start value parsing of drc-info entry Tyrel Datwyler
2019-10-01 6:12 ` Tyrel Datwyler
2019-10-10 19:04 ` Nathan Lynch
2019-10-10 19:04 ` Nathan Lynch
2019-10-10 20:16 ` powerpc/405GP, cuImage and PCI support Carlo Pisani
2019-10-10 20:16 ` Carlo Pisani
2019-10-31 0:15 ` [RFC PATCH 2/9] powerpc/pseries: fix bad drc_index_start value parsing of drc-info entry Tyrel Datwyler
2019-10-31 0:15 ` Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 3/9] powerpc/pseries: fix drc-info mappings of logical cpus to drc-index Tyrel Datwyler
2019-10-01 6:12 ` Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 4/9] PCI: rpaphp: fix up pointer to first drc-info entry Tyrel Datwyler
2019-10-01 6:12 ` Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 5/9] PCI: rpaphp: don't rely on firmware feature to imply drc-info support Tyrel Datwyler
2019-10-01 6:12 ` Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 6/9] PCI: rpaphp: add drc-info support for hotplug slot registration Tyrel Datwyler
2019-10-01 6:12 ` Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 7/9] PCI: rpaphp: annotate and correctly byte swap DRC properties Tyrel Datwyler
2019-10-01 6:12 ` Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 8/9] PCI: rpaphp: correctly match ibm,my-drc-index to drc-name when using drc-info Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 8/9] PCI: rpaphp: correctly match ibm, my-drc-index " Tyrel Datwyler
2019-10-01 6:12 ` [RFC PATCH 9/9] powerpc: Enable support for ibm,drc-info property Tyrel Datwyler
2019-10-01 6:12 ` Tyrel Datwyler
2019-10-01 20:02 ` [RFC PATCH 0/9] Fixes and Enablement of " Bjorn Helgaas
2019-10-01 20:02 ` Bjorn Helgaas
2019-10-31 0:15 ` Tyrel Datwyler
2019-10-31 0:15 ` Tyrel Datwyler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h83oltvs.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.