From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, qemu-arm@nongnu.org
Subject: Re: [PATCH v2 10/16] tests/tcg: add generic version of float_convs
Date: Fri, 20 Sep 2019 11:15:16 +0100 [thread overview]
Message-ID: <87h857z32j.fsf@linaro.org> (raw)
In-Reply-To: <87impnz568.fsf@linaro.org>
Alex Bennée <alex.bennee@linaro.org> writes:
> Richard Henderson <richard.henderson@linaro.org> writes:
>
>> On 9/19/19 10:10 AM, Alex Bennée wrote:
>>> This is broadly similar to the existing fcvt test for ARM but using
>>> the generic float testing framework. We should be able to pare down
>>> the ARM fcvt test case to purely half-precision with or without the
>>> Alt HP provision.
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> ---
>>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> This test seems to be tripping up alpha-linux-user be generating FPU
> exceptions. AFAICT we are meant to start with software exceptions
> disabled but:
>
> cpu_alpha_store_fpcr: enabled exceptions: 2000000
>
> from the get go is what causes the eventual trip up.
I can't figure out what is meant to be going on with CONVERT_BITS. It
seems to be implying there is a direct relationship between status flags
and the exception disable bits. But that is confusing because integer
overflow (IOV) and float overflow (OVF) are different flags bit I assume
both suppressed by Overflow Disable (OVFD).
Why are we doing this magic 32 bit shuffling anyway? Is it purely to
save 32 bits of a mostly empty lower half of the FPCR register?
>
>>
>>
>> r~
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 10/16] tests/tcg: add generic version of float_convs
Date: Fri, 20 Sep 2019 11:15:16 +0100 [thread overview]
Message-ID: <87h857z32j.fsf@linaro.org> (raw)
In-Reply-To: <87impnz568.fsf@linaro.org>
Alex Bennée <alex.bennee@linaro.org> writes:
> Richard Henderson <richard.henderson@linaro.org> writes:
>
>> On 9/19/19 10:10 AM, Alex Bennée wrote:
>>> This is broadly similar to the existing fcvt test for ARM but using
>>> the generic float testing framework. We should be able to pare down
>>> the ARM fcvt test case to purely half-precision with or without the
>>> Alt HP provision.
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> ---
>>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> This test seems to be tripping up alpha-linux-user be generating FPU
> exceptions. AFAICT we are meant to start with software exceptions
> disabled but:
>
> cpu_alpha_store_fpcr: enabled exceptions: 2000000
>
> from the get go is what causes the eventual trip up.
I can't figure out what is meant to be going on with CONVERT_BITS. It
seems to be implying there is a direct relationship between status flags
and the exception disable bits. But that is confusing because integer
overflow (IOV) and float overflow (OVF) are different flags bit I assume
both suppressed by Overflow Disable (OVFD).
Why are we doing this magic 32 bit shuffling anyway? Is it purely to
save 32 bits of a mostly empty lower half of the FPCR register?
>
>>
>>
>> r~
--
Alex Bennée
next prev parent reply other threads:[~2019-09-20 10:15 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 17:09 [PATCH v2 00/16] testing/next (docker/podman, tcg, build fixes) Alex Bennée
2019-09-19 17:10 ` [PATCH v2 01/16] tests/docker: add sanitizers back to clang build Alex Bennée
2019-09-19 17:10 ` Alex Bennée
2019-09-19 17:10 ` [PATCH v2 02/16] tests/docker: fix DOCKER_PARTIAL_IMAGES Alex Bennée
2019-09-19 17:10 ` Alex Bennée
2019-09-23 19:46 ` Cleber Rosa
2019-09-23 19:46 ` Cleber Rosa
2019-09-19 17:10 ` [PATCH v2 03/16] tests/docker: remove python2.7 from docker9-mxe Alex Bennée
2019-09-19 17:10 ` Alex Bennée
2019-09-23 19:49 ` Cleber Rosa
2019-09-23 19:49 ` Cleber Rosa
2019-09-23 19:55 ` John Snow
2019-09-23 19:55 ` John Snow
2019-09-19 17:10 ` [PATCH v2 04/16] tests/docker: reduce scary warnings from failed inspect Alex Bennée
2019-09-19 17:10 ` Alex Bennée
2019-09-23 20:51 ` Cleber Rosa
2019-09-23 20:51 ` Cleber Rosa
2019-09-23 23:00 ` Alex Bennée
2019-09-23 23:00 ` Alex Bennée
2019-09-19 17:10 ` [PATCH v2 05/16] podman: fix command invocation Alex Bennée
2019-09-19 17:10 ` Alex Bennée
2019-09-23 18:47 ` Cleber Rosa
2019-09-23 18:47 ` Cleber Rosa
2019-09-19 17:10 ` [PATCH v2 06/16] target/ppc: fix signal delivery for ppc64abi32 Alex Bennée
2019-09-19 17:10 ` Alex Bennée
2019-09-20 19:27 ` Laurent Vivier
2019-09-20 19:27 ` Laurent Vivier
2019-09-19 17:10 ` [PATCH v2 07/16] tests/tcg: clean-up some comments after the de-tangling Alex Bennée
2019-09-19 17:10 ` Alex Bennée
2019-09-19 17:10 ` [PATCH v2 08/16] tests/tcg: re-enable linux-test for ppc64abi32 Alex Bennée
2019-09-19 17:10 ` Alex Bennée
2019-09-19 22:00 ` Richard Henderson
2019-09-19 17:10 ` [PATCH v2 09/16] tests/tcg: add float_madds test to multiarch Alex Bennée
2019-09-19 22:07 ` Richard Henderson
2019-09-19 17:10 ` [PATCH v2 10/16] tests/tcg: add generic version of float_convs Alex Bennée
2019-09-19 22:09 ` Richard Henderson
2019-09-20 9:29 ` Alex Bennée
2019-09-20 9:29 ` Alex Bennée
2019-09-20 10:15 ` Alex Bennée [this message]
2019-09-20 10:15 ` Alex Bennée
2019-09-20 22:09 ` Richard Henderson
2019-09-20 22:09 ` Richard Henderson
2019-09-19 17:10 ` [PATCH v2 11/16] tests/tcg: add simple record/replay smoke test for aarch64 Alex Bennée
2019-09-19 17:10 ` Alex Bennée
2019-09-19 17:10 ` [PATCH v2 12/16] tests/docker: Add fedora-win10sdk-cross image Alex Bennée
2019-09-19 17:10 ` Alex Bennée
2019-09-19 17:10 ` [PATCH v2 13/16] .shippable.yml: Build WHPX enabled binaries Alex Bennée
2019-09-19 17:10 ` Alex Bennée
2019-09-19 17:10 ` [PATCH v2 14/16] configure: preserve PKG_CONFIG for subdir builds Alex Bennée
2019-09-19 22:12 ` Richard Henderson
2019-09-19 17:10 ` [PATCH v2 15/16] docs/devel: add "check-tcg" to testing.rst Alex Bennée
2019-09-19 17:10 ` [PATCH v2 16/16] Makefile: fix-up qemu-ga.8 paths to take in-src builds into account Alex Bennée
2019-09-19 17:10 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h857z32j.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.