All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregory.clement@bootlin.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: dts: kirkwood: fix error in #sound-dai-cells size
Date: Mon, 05 Mar 2018 14:48:13 +0100	[thread overview]
Message-ID: <87h8pu63c2.fsf@bootlin.com> (raw)
In-Reply-To: <20180301202537.30571-5-robh@kernel.org> (Rob Herring's message of "Thu, 1 Mar 2018 14:25:37 -0600")

Hi Rob,
 
 On jeu., mars 01 2018, Rob Herring <robh@kernel.org> wrote:

> dtc now gives the following warning:
>
> arch/arm/boot/dts/kirkwood-t5325.dtb: Warning (sound_dai_property): /sound/simple-audio-card,cpu:sound-dai: property size (4) too small for cell size 1
>
> The binding documentation gives no indication what the cell size should
> be (which should be fixed too), so just assume 0 is fine as that is what
> the consumer has.
>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Gregory Clement <gregory.clement@free-electrons.com>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Signed-off-by: Rob Herring <robh@kernel.org>

Applied on mvebu/dt with the reviewed-by flag from Andrew.

Thanks,

Gregory

> ---
>  arch/arm/boot/dts/kirkwood.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi
> index eb2bf7409655..81c7eda2c442 100644
> --- a/arch/arm/boot/dts/kirkwood.dtsi
> +++ b/arch/arm/boot/dts/kirkwood.dtsi
> @@ -382,7 +382,7 @@
>  
>  		audio0: audio-controller at a0000 {
>  			compatible = "marvell,kirkwood-audio";
> -			#sound-dai-cells = <1>;
> +			#sound-dai-cells = <0>;
>  			reg = <0xa0000 0x2210>;
>  			interrupts = <24>;
>  			clocks = <&gate_clk 9>;
> -- 
> 2.14.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
	Andrew Lunn <andrew@lunn.ch>,
	arm@kernel.org,
	Gregory Clement <gregory.clement@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] arm: dts: kirkwood: fix error in #sound-dai-cells size
Date: Mon, 05 Mar 2018 14:48:13 +0100	[thread overview]
Message-ID: <87h8pu63c2.fsf@bootlin.com> (raw)
In-Reply-To: <20180301202537.30571-5-robh@kernel.org> (Rob Herring's message of "Thu, 1 Mar 2018 14:25:37 -0600")

Hi Rob,
 
 On jeu., mars 01 2018, Rob Herring <robh@kernel.org> wrote:

> dtc now gives the following warning:
>
> arch/arm/boot/dts/kirkwood-t5325.dtb: Warning (sound_dai_property): /sound/simple-audio-card,cpu:sound-dai: property size (4) too small for cell size 1
>
> The binding documentation gives no indication what the cell size should
> be (which should be fixed too), so just assume 0 is fine as that is what
> the consumer has.
>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Gregory Clement <gregory.clement@free-electrons.com>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Signed-off-by: Rob Herring <robh@kernel.org>

Applied on mvebu/dt with the reviewed-by flag from Andrew.

Thanks,

Gregory

> ---
>  arch/arm/boot/dts/kirkwood.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi
> index eb2bf7409655..81c7eda2c442 100644
> --- a/arch/arm/boot/dts/kirkwood.dtsi
> +++ b/arch/arm/boot/dts/kirkwood.dtsi
> @@ -382,7 +382,7 @@
>  
>  		audio0: audio-controller@a0000 {
>  			compatible = "marvell,kirkwood-audio";
> -			#sound-dai-cells = <1>;
> +			#sound-dai-cells = <0>;
>  			reg = <0xa0000 0x2210>;
>  			interrupts = <24>;
>  			clocks = <&gate_clk 9>;
> -- 
> 2.14.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

  parent reply	other threads:[~2018-03-05 13:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 20:25 [PATCH] arm: dts: kirkwood: fix error in #sound-dai-cells size Rob Herring
2018-03-01 20:25 ` Rob Herring
2018-03-02 13:50 ` Andrew Lunn
2018-03-02 13:50   ` Andrew Lunn
2018-03-05 13:48 ` Gregory CLEMENT [this message]
2018-03-05 13:48   ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8pu63c2.fsf@bootlin.com \
    --to=gregory.clement@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.