All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
Cc: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: Add sta rx packet stats per tid
Date: Fri, 02 Mar 2018 16:24:41 +0200	[thread overview]
Message-ID: <87h8pyo8ra.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <b1fcd67d-e149-acc4-ebbb-23da9a06da02@qti.qualcomm.com> (Vasanthakumar Thiagarajan's message of "Fri, 2 Mar 2018 08:21:25 +0000")

Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> writes:

>> This added new ath10k-check warnings, I fixed those in the pending
>> branch:
>> 
>> drivers/net/wireless/ath/ath10k/debug.h:203: Alignment should match open parenthesis
>> drivers/net/wireless/ath/ath10k/debug.h:226: Alignment should match open parenthesis
>> drivers/net/wireless/ath/ath10k/debugfs_sta.c:24: Alignment should
>> match open parenthesis
>> drivers/net/wireless/ath/ath10k/debugfs_sta.c:40: Alignment should
>> match open parenthesis
>> drivers/net/wireless/ath/ath10k/debugfs_sta.c:60: Alignment should
>> match open parenthesis
>> 
>> Also I fixed the typo "rages" in debug.h. My changes:
>
> Thanks for fixing it. In most of the cases, fixing above warnings
> would result in lines > 80 chars.
> May be we need not be very strict about > 80 char limit?

In ath10k-check I set the limit to 90 chars, but I guess it could be
even higher than that. But on the other it shouldn't be too long, not
everyone like to have one huge window for editor :)

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
Cc: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>,
	"ath10k\@lists.infradead.org" <ath10k@lists.infradead.org>,
	"linux-wireless\@vger.kernel.org"
	<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: Add sta rx packet stats per tid
Date: Fri, 02 Mar 2018 16:24:41 +0200	[thread overview]
Message-ID: <87h8pyo8ra.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <b1fcd67d-e149-acc4-ebbb-23da9a06da02@qti.qualcomm.com> (Vasanthakumar Thiagarajan's message of "Fri, 2 Mar 2018 08:21:25 +0000")

Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> writes:

>> This added new ath10k-check warnings, I fixed those in the pending
>> branch:
>> 
>> drivers/net/wireless/ath/ath10k/debug.h:203: Alignment should match open parenthesis
>> drivers/net/wireless/ath/ath10k/debug.h:226: Alignment should match open parenthesis
>> drivers/net/wireless/ath/ath10k/debugfs_sta.c:24: Alignment should
>> match open parenthesis
>> drivers/net/wireless/ath/ath10k/debugfs_sta.c:40: Alignment should
>> match open parenthesis
>> drivers/net/wireless/ath/ath10k/debugfs_sta.c:60: Alignment should
>> match open parenthesis
>> 
>> Also I fixed the typo "rages" in debug.h. My changes:
>
> Thanks for fixing it. In most of the cases, fixing above warnings
> would result in lines > 80 chars.
> May be we need not be very strict about > 80 char limit?

In ath10k-check I set the limit to 90 chars, but I guess it could be
even higher than that. But on the other it shouldn't be too long, not
everyone like to have one huge window for editor :)

-- 
Kalle Valo

  reply	other threads:[~2018-03-02 14:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31 12:01 [PATCH] ath10k: Add sta rx packet stats per tid Vasanthakumar Thiagarajan
2018-01-31 12:01 ` Vasanthakumar Thiagarajan
2018-02-28 13:17 ` Kalle Valo
2018-02-28 13:17   ` Kalle Valo
2018-03-02  8:21   ` Vasanthakumar Thiagarajan
2018-03-02  8:21     ` Vasanthakumar Thiagarajan
2018-03-02 14:24     ` Kalle Valo [this message]
2018-03-02 14:24       ` Kalle Valo
2018-03-26 15:07 ` Kalle Valo
2018-03-26 15:07 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8pyo8ra.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=vthiagar@codeaurora.org \
    --cc=vthiagar@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.