[PATCH] drm/i915: set initialised only when init_context callback is NULL

[PATCH] drm/i915: set initialised only when init_context callback is NULL

[Chuanxiao Dong]

initialised is fixup by the GVT shadow context as true to avoid the init
from the host because it cannot take the settings from the host. Add a
check to let host driver only overwrite it when the init callback is NULL

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com>
---
 drivers/gpu/drm/i915/intel_lrc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 319d9a8..d0e9b61 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -1956,7 +1956,8 @@ static int execlists_context_deferred_alloc(struct i915_gem_context *ctx,
 
 	ce->ring = ring;
 	ce->state = vma;
-	ce->initialised = engine->init_context == NULL;
+	if (!engine->init_context)
+		ce->initialised = true;
 
 	return 0;
 
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: set initialised only when init_context callback is NULL

[Patchwork]

== Series Details ==

Series: drm/i915: set initialised only when init_context callback is NULL
URL   : https://patchwork.freedesktop.org/series/24286/
State : success

== Summary ==

Series 24286v1 drm/i915: set initialised only when init_context callback is NULL
https://patchwork.freedesktop.org/api/1.0/series/24286/revisions/1/mbox/

Test gem_exec_suspend:
        Subgroup basic-s4-devices:
                pass       -> DMESG-WARN (fi-kbl-7560u) fdo#100125

fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time:439s
fi-bdw-gvtdvm    total:278  pass:256  dwarn:8   dfail:0   fail:0   skip:14  time:435s
fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36  time:582s
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time:506s
fi-bxt-t5700     total:278  pass:258  dwarn:0   dfail:0   fail:0   skip:20  time:559s
fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24  time:496s
fi-byt-n2820     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:491s
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:418s
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:413s
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time:418s
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:503s
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:497s
fi-kbl-7500u     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:460s
fi-kbl-7560u     total:278  pass:267  dwarn:1   dfail:0   fail:0   skip:10  time:576s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:459s
fi-skl-6700hq    total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:17  time:576s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time:475s
fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:498s
fi-skl-gvtdvm    total:278  pass:265  dwarn:0   dfail:0   fail:0   skip:13  time:443s
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:530s
fi-snb-2600      total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:29  time:411s

81dbd44ab4c1331c61a971b05681473a869b3039 drm-tip: 2017y-05m-11d-09h-55m-44s UTC integration manifest
5a738b5 drm/i915: set initialised only when init_context callback is NULL

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4673/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: set initialised only when init_context callback is NULL

[Chris Wilson]

On Thu, May 11, 2017 at 06:07:42PM +0800, Chuanxiao Dong wrote:
> initialised is fixup by the GVT shadow context as true to avoid the init
> from the host because it cannot take the settings from the host. Add a
> check to let host driver only overwrite it when the init callback is NULL

During execlist_context_deferred_alloc() we presumed that the context is
uninitialised (we only just allocated the state object for it!) and
chose to optimise away the later call to engine->init_context() if
engine->init_context were NULL. This breaks with GVT's contexts that are
marked as pre-initialised to avoid us annoyingly calling 
engine->init_context(). The fix is to not override ce->initialised if it
is already true.

> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_lrc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 319d9a8..d0e9b61 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -1956,7 +1956,8 @@ static int execlists_context_deferred_alloc(struct i915_gem_context *ctx,
>  
>  	ce->ring = ring;
>  	ce->state = vma;
> -	ce->initialised = engine->init_context == NULL;
> +	if (!engine->init_context)
> +		ce->initialised = true;

Does the compiler generate a cmov?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: set initialised only when init_context callback is NULL

[Chris Wilson]

On Fri, May 12, 2017 at 10:49:24AM +0100, Chris Wilson wrote:
> On Thu, May 11, 2017 at 06:07:42PM +0800, Chuanxiao Dong wrote:
> > initialised is fixup by the GVT shadow context as true to avoid the init
> > from the host because it cannot take the settings from the host. Add a
> > check to let host driver only overwrite it when the init callback is NULL
> 
> During execlist_context_deferred_alloc() we presumed that the context is
> uninitialised (we only just allocated the state object for it!) and
> chose to optimise away the later call to engine->init_context() if
> engine->init_context were NULL. This breaks with GVT's contexts that are
> marked as pre-initialised to avoid us annoyingly calling 
> engine->init_context(). The fix is to not override ce->initialised if it
> is already true.
> 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_lrc.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> > index 319d9a8..d0e9b61 100644
> > --- a/drivers/gpu/drm/i915/intel_lrc.c
> > +++ b/drivers/gpu/drm/i915/intel_lrc.c
> > @@ -1956,7 +1956,8 @@ static int execlists_context_deferred_alloc(struct i915_gem_context *ctx,
> >  
> >  	ce->ring = ring;
> >  	ce->state = vma;
> > -	ce->initialised = engine->init_context == NULL;
> > +	if (!engine->init_context)
> > +		ce->initialised = true;
> 
> Does the compiler generate a cmov?

Test and jump, may as well just use ce->initialised |= init_context ==
NULL;
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH v2] drm/i915: set initialised only when init_context callback is NULL

[Chris Wilson]

From: Chuanxiao Dong <chuanxiao.dong@intel.com>

During execlist_context_deferred_alloc() we presumed that the context is
uninitialised (we only just allocated the state object for it!) and
chose to optimise away the later call to engine->init_context() if
engine->init_context were NULL. This breaks with GVT's contexts that are
marked as pre-initialised to avoid us annoyingly calling
engine->init_context(). The fix is to not override ce->initialised if it
is already true.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1494497262-24855-1-git-send-email-chuanxiao.dong@intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_lrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 319d9a8f37ca..9a1192d61538 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -1956,7 +1956,7 @@ static int execlists_context_deferred_alloc(struct i915_gem_context *ctx,
 
 	ce->ring = ring;
 	ce->state = vma;
-	ce->initialised = engine->init_context == NULL;
+	ce->initialised |= engine->init_context == NULL;
 
 	return 0;
 
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: set initialised only when init_context callback is NULL

[Dong, Chuanxiao]

> -----Original Message-----
> From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> Sent: Friday, May 12, 2017 6:11 PM
> To: Dong, Chuanxiao <chuanxiao.dong@intel.com>; intel-
> gfx@lists.freedesktop.org; intel-gvt-dev@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915: set initialised only when
> init_context callback is NULL
> 
> On Fri, May 12, 2017 at 10:49:24AM +0100, Chris Wilson wrote:
> > On Thu, May 11, 2017 at 06:07:42PM +0800, Chuanxiao Dong wrote:
> > > initialised is fixup by the GVT shadow context as true to avoid the
> > > init from the host because it cannot take the settings from the
> > > host. Add a check to let host driver only overwrite it when the init
> > > callback is NULL
> >
> > During execlist_context_deferred_alloc() we presumed that the context
> > is uninitialised (we only just allocated the state object for it!) and
> > chose to optimise away the later call to engine->init_context() if
> > engine->init_context were NULL. This breaks with GVT's contexts that
> > engine->are
> > marked as pre-initialised to avoid us annoyingly calling
> > engine->init_context(). The fix is to not override ce->initialised if
> > engine->it
> > is already true.

Thanks Chris, will use this as commit message

> >
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/intel_lrc.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_lrc.c
> > > b/drivers/gpu/drm/i915/intel_lrc.c
> > > index 319d9a8..d0e9b61 100644
> > > --- a/drivers/gpu/drm/i915/intel_lrc.c
> > > +++ b/drivers/gpu/drm/i915/intel_lrc.c
> > > @@ -1956,7 +1956,8 @@ static int
> > > execlists_context_deferred_alloc(struct i915_gem_context *ctx,
> > >
> > >  	ce->ring = ring;
> > >  	ce->state = vma;
> > > -	ce->initialised = engine->init_context == NULL;
> > > +	if (!engine->init_context)
> > > +		ce->initialised = true;
> >
> > Does the compiler generate a cmov?

Just get the assembly code of this change, seems no cmov.
if (!engine->init_context)
ffffffff8156b6f3:       49 83 bf c0 01 00 00    cmpq   $0x0,0x1c0(%r15)
ffffffff8156b6fa:       00
ffffffff8156b6fb:       0f 84 e5 01 00 00       je     ffffffff8156b8e6 <execlists_context_pin+0x486>
.........
        ce->initialised = true;
ffffffff8156b8e6:       4d 6b ed 28             imul   $0x28,%r13,%r13
ffffffff8156b8ea:       43 c6 44 2e 7c 01       movb   $0x1,0x7c(%r14,%r13,1)
ffffffff8156b8f0:       e9 0c fe ff ff          jmpq   ffffffff8156b701 <execlists_context_pin+0x2a1>

> 
> Test and jump, may as well just use ce->initialised |= init_context == NULL; -
> Chris

This is the new assembly code for this new change:

         ce->initialised |= engine->init_context == NULL;
ffffffff8156b6f3:       49 83 bf c0 01 00 00    cmpq   $0x0,0x1c0(%r15)
ffffffff8156b6fa:       00
ffffffff8156b6fb:       0f 94 c2                sete   %dl
ffffffff8156b6fe:       08 50 7c                or     %dl,0x7c(%rax)

looks your change is better because the compiler doesn't generate a jump. :)

Will send out v2 with your idea.

Thanks
Chuanxiao
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v2] drm/i915: set initialised only when init_context callback is NULL

[Dong, Chuanxiao]

Thanks Chris! Have a nice weekend. :)

> -----Original Message-----
> From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> Sent: Friday, May 12, 2017 6:12 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Dong, Chuanxiao <chuanxiao.dong@intel.com>; Chris Wilson
> <chris@chris-wilson.co.uk>
> Subject: [PATCH v2] drm/i915: set initialised only when init_context callback
> is NULL
> 
> From: Chuanxiao Dong <chuanxiao.dong@intel.com>
> 
> During execlist_context_deferred_alloc() we presumed that the context is
> uninitialised (we only just allocated the state object for it!) and chose to
> optimise away the later call to engine->init_context() if
> engine->init_context were NULL. This breaks with GVT's contexts that are
> marked as pre-initialised to avoid us annoyingly calling
> engine->init_context(). The fix is to not override ce->initialised if it
> is already true.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com>
> Link: http://patchwork.freedesktop.org/patch/msgid/1494497262-24855-1-
> git-send-email-chuanxiao.dong@intel.com
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/intel_lrc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c
> b/drivers/gpu/drm/i915/intel_lrc.c
> index 319d9a8f37ca..9a1192d61538 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -1956,7 +1956,7 @@ static int execlists_context_deferred_alloc(struct
> i915_gem_context *ctx,
> 
>  	ce->ring = ring;
>  	ce->state = vma;
> -	ce->initialised = engine->init_context == NULL;
> +	ce->initialised |= engine->init_context == NULL;
> 
>  	return 0;
> 
> --
> 2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: set initialised only when init_context callback is NULL (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915: set initialised only when init_context callback is NULL (rev2)
URL   : https://patchwork.freedesktop.org/series/24286/
State : success

== Summary ==

Series 24286v2 drm/i915: set initialised only when init_context callback is NULL
https://patchwork.freedesktop.org/api/1.0/series/24286/revisions/2/mbox/

Test gem_exec_suspend:
        Subgroup basic-s4-devices:
                pass       -> DMESG-WARN (fi-kbl-7560u) fdo#100125

fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time:438s
fi-bdw-gvtdvm    total:278  pass:256  dwarn:8   dfail:0   fail:0   skip:14  time:437s
fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36  time:576s
fi-bxt-t5700     total:278  pass:258  dwarn:0   dfail:0   fail:0   skip:20  time:562s
fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24  time:497s
fi-byt-n2820     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:481s
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:411s
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:415s
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time:414s
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:500s
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:478s
fi-kbl-7500u     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:468s
fi-kbl-7560u     total:278  pass:267  dwarn:1   dfail:0   fail:0   skip:10  time:572s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:459s
fi-skl-6700hq    total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:17  time:582s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time:461s
fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:502s
fi-skl-gvtdvm    total:278  pass:265  dwarn:0   dfail:0   fail:0   skip:13  time:440s
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:536s
fi-snb-2600      total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:29  time:419s
fi-bxt-j4205 failed to collect. IGT log at Patchwork_4681/fi-bxt-j4205/igt.log

51350ea90d1a5c8bb7e6532eb61c64a57e83ab9b drm-tip: 2017y-05m-11d-13h-05m-06s UTC integration manifest
fdaa20d drm/i915: set initialised only when init_context callback is NULL

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4681/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✓ Fi.CI.BAT: success for drm/i915: set initialised only when init_context callback is NULL (rev2)

[Chris Wilson]

On Fri, May 12, 2017 at 11:34:21AM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: set initialised only when init_context callback is NULL (rev2)
> URL   : https://patchwork.freedesktop.org/series/24286/
> State : success
> 
> == Summary ==
> 
> Series 24286v2 drm/i915: set initialised only when init_context callback is NULL
> https://patchwork.freedesktop.org/api/1.0/series/24286/revisions/2/mbox/
> 
> Test gem_exec_suspend:
>         Subgroup basic-s4-devices:
>                 pass       -> DMESG-WARN (fi-kbl-7560u) fdo#100125

Thanks for the patch and pushed.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✓ Fi.CI.BAT: success for drm/i915: set initialised only when init_context callback is NULL (rev2)

[Zhenyu Wang]

[-- Attachment #1.1: Type: text/plain, Size: 900 bytes --]

On 2017.05.12 12:44:48 +0100, Chris Wilson wrote:
> On Fri, May 12, 2017 at 11:34:21AM -0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: drm/i915: set initialised only when init_context callback is NULL (rev2)
> > URL   : https://patchwork.freedesktop.org/series/24286/
> > State : success
> > 
> > == Summary ==
> > 
> > Series 24286v2 drm/i915: set initialised only when init_context callback is NULL
> > https://patchwork.freedesktop.org/api/1.0/series/24286/revisions/2/mbox/
> > 
> > Test gem_exec_suspend:
> >         Subgroup basic-s4-devices:
> >                 pass       -> DMESG-WARN (fi-kbl-7560u) fdo#100125
> 
> Thanks for the patch and pushed.

Could this be picked to -fixes? It should be in 4.12 and apply for
-stable kernel too I think.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✓ Fi.CI.BAT: success for drm/i915: set initialised only when init_context callback is NULL (rev2)

[Jani Nikula]

On Fri, 19 May 2017, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> On 2017.05.12 12:44:48 +0100, Chris Wilson wrote:
>> On Fri, May 12, 2017 at 11:34:21AM -0000, Patchwork wrote:
>> > == Series Details ==
>> > 
>> > Series: drm/i915: set initialised only when init_context callback is NULL (rev2)
>> > URL   : https://patchwork.freedesktop.org/series/24286/
>> > State : success
>> > 
>> > == Summary ==
>> > 
>> > Series 24286v2 drm/i915: set initialised only when init_context callback is NULL
>> > https://patchwork.freedesktop.org/api/1.0/series/24286/revisions/2/mbox/
>> > 
>> > Test gem_exec_suspend:
>> >         Subgroup basic-s4-devices:
>> >                 pass       -> DMESG-WARN (fi-kbl-7560u) fdo#100125
>> 
>> Thanks for the patch and pushed.
>
> Could this be picked to -fixes? It should be in 4.12 and apply for
> -stable kernel too I think.

Argh, you asked this to be picked up on irc, so I did. But you only
mentioned 4.12 and nothing about stable backports, so it doesn't have
cc: stable now. Is this needed for stable?!

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx