All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Richard Henderson <rth@twiddle.net>
Cc: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo
Date: Tue, 15 Nov 2016 22:59:42 +0100	[thread overview]
Message-ID: <87h978cskx.fsf@linux-m68k.org> (raw)
In-Reply-To: <d9563bc3-bbb4-0abb-80ac-13a72b28f218@twiddle.net> (Richard Henderson's message of "Tue, 15 Nov 2016 22:18:18 +0100")

On Nov 15 2016, Richard Henderson <rth@twiddle.net> wrote:

> On 11/15/2016 10:12 PM, Laurent Vivier wrote:
>> Le 15/11/2016 à 22:07, Laurent Vivier a écrit :
>>> Le 15/11/2016 à 21:44, Richard Henderson a écrit :
>>>> @@ -5415,6 +5450,8 @@ void register_m68k_insns (CPUM68KState *env)
>>>>      INSN(bfop_reg, eac0, fff8, BITFIELD);   /* bfchg */
>>>>      INSN(bfop_mem, ecc0, ffc0, BITFIELD);   /* bfclr */
>>>>      INSN(bfop_reg, ecc0, fff8, BITFIELD);   /* bfclr */
>>>> +    INSN(bfop_mem, edc0, ffc0, BITFIELD);   /* bfffo */
>>>> +    INSN(bfop_reg, edc0, fff8, BITFIELD);   /* bfffo */
>>>
>>> In my doc, bfffo is 0xE9C0.
>>
>> I think my doc [1] is wrong, because it is the same as bextu and the
>> as/objdump gives me 0xEDC0.
>
> My doc gives the same wrong opcode on the bfffo description page.  It
> confused me for some time until I scrolled to the opcode map at the end of
> the document, where it is correctly identified as EDC0.

The printed manual has the correct opcode, it is only wrong in the PDF.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

  reply	other threads:[~2016-11-15 21:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15 20:44 [Qemu-devel] [PATCH] target-m68k: Implement bfffo Richard Henderson
2016-11-15 21:07 ` Laurent Vivier
2016-11-15 21:12   ` Laurent Vivier
2016-11-15 21:18     ` Richard Henderson
2016-11-15 21:59       ` Andreas Schwab [this message]
2016-11-15 21:21   ` Richard Henderson
2016-11-15 21:33     ` Laurent Vivier
2016-11-27 19:53 ` Laurent Vivier
2016-11-28 14:31   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h978cskx.fsf@linux-m68k.org \
    --to=schwab@linux-m68k.org \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.