[PATCH] libdrm: Update plane type enum definitions to correspond to kernel change

[PATCH] libdrm: Update plane type enum definitions to correspond to kernel change

[Dhinakaran Pandiyan]

The positions of primary and overlay plane type enums in the kernel were
updated in

	    drm/doc: Polish for drm_plane.[hc]

So, making the change here as well.

Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
 xf86drmMode.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xf86drmMode.h b/xf86drmMode.h
index 4de7bbb..718b34f 100644
--- a/xf86drmMode.h
+++ b/xf86drmMode.h
@@ -305,9 +305,9 @@ typedef struct _drmModeConnector {
 	uint32_t *encoders; /**< List of encoder ids */
 } drmModeConnector, *drmModeConnectorPtr;
 
-#define DRM_PLANE_TYPE_OVERLAY 0
-#define DRM_PLANE_TYPE_PRIMARY 1
-#define DRM_PLANE_TYPE_CURSOR  2
+#define DRM_PLANE_TYPE_PRIMARY 0
+#define DRM_PLANE_TYPE_CURSOR  1
+#define DRM_PLANE_TYPE_OVERLAY 2
 
 typedef struct _drmModeObjectProperties {
 	uint32_t count_props;
-- 
2.5.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] libdrm: Update plane type enum definitions to correspond to kernel change

[Jani Nikula]

On Fri, 23 Sep 2016, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> wrote:
> The positions of primary and overlay plane type enums in the kernel were
> updated in
>
> 	    drm/doc: Polish for drm_plane.[hc]
>
> So, making the change here as well.

NAK. That was a regression in the kernel, and fixed in the kernel.

BR,
Jani.

>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
>  xf86drmMode.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/xf86drmMode.h b/xf86drmMode.h
> index 4de7bbb..718b34f 100644
> --- a/xf86drmMode.h
> +++ b/xf86drmMode.h
> @@ -305,9 +305,9 @@ typedef struct _drmModeConnector {
>  	uint32_t *encoders; /**< List of encoder ids */
>  } drmModeConnector, *drmModeConnectorPtr;
>  
> -#define DRM_PLANE_TYPE_OVERLAY 0
> -#define DRM_PLANE_TYPE_PRIMARY 1
> -#define DRM_PLANE_TYPE_CURSOR  2
> +#define DRM_PLANE_TYPE_PRIMARY 0
> +#define DRM_PLANE_TYPE_CURSOR  1
> +#define DRM_PLANE_TYPE_OVERLAY 2
>  
>  typedef struct _drmModeObjectProperties {
>  	uint32_t count_props;

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] libdrm: Update plane type enum definitions to correspond to kernel change

[Emil Velikov]

Hi Dhinakaran,

On 23 September 2016 at 07:33, Dhinakaran Pandiyan
<dhinakaran.pandiyan@intel.com> wrote:
> The positions of primary and overlay plane type enums in the kernel were
> updated in
>
>             drm/doc: Polish for drm_plane.[hc]
>
> So, making the change here as well.
>
Obviously the issue is/has been fixed elsewhere, so just a general comment:

One must _not_ break API/ABI without bumping the library major. Unless
you hate your users and you want them to suffer, that is ;-)

Regards,
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel