From: "Alex Bennée" <alex.bennee@linaro.org>
To: Sergey Fedorov <sergey.fedorov@linaro.org>
Cc: qemu-devel@nongnu.org, Sergey Fedorov <serge.fdrv@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 11/11] tcg: Note requirement on atomic direct jump patching
Date: Wed, 20 Apr 2016 15:25:05 +0100 [thread overview]
Message-ID: <87h9ewuzlq.fsf@linaro.org> (raw)
In-Reply-To: <1460044433-19282-12-git-send-email-sergey.fedorov@linaro.org>
Sergey Fedorov <sergey.fedorov@linaro.org> writes:
> From: Sergey Fedorov <serge.fdrv@gmail.com>
>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
> ---
> include/exec/exec-all.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
> index 6a054ee720a8..1878e7b7856c 100644
> --- a/include/exec/exec-all.h
> +++ b/include/exec/exec-all.h
> @@ -229,6 +229,7 @@ static inline void tlb_flush_by_mmuidx(CPUState *cpu, ...)
> || defined(__sparc__) || defined(__aarch64__) \
> || defined(__s390x__) || defined(__mips__) \
> || defined(CONFIG_TCG_INTERPRETER)
> +/* NOTE: Direct jump patching must be atomic and thread-safe. */
Maybe:
/* NOTE: Direct jump patching must be atomic to be thread-safe. */
Otherwise:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> #define USE_DIRECT_JUMP
> #endif
--
Alex Bennée
next prev parent reply other threads:[~2016-04-20 14:25 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 15:53 [Qemu-devel] [PATCH 00/11] tcg: Make direct jump patching thread-safe Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 01/11] tci: Fix build regression Sergey Fedorov
2016-04-07 18:15 ` Richard Henderson
2016-04-07 19:16 ` Stefan Weil
2016-04-07 20:37 ` Stefan Weil
2016-04-08 3:40 ` Richard Henderson
2016-04-07 15:53 ` [Qemu-devel] [PATCH 02/11] pc-bios/s390-ccw: Use correct strip when cross-compiling Sergey Fedorov
2016-04-07 16:18 ` Cornelia Huck
2016-04-07 16:22 ` Sergey Fedorov
2016-04-18 13:15 ` Sergey Fedorov
2016-04-18 14:51 ` Cornelia Huck
2016-04-18 15:34 ` Cornelia Huck
2016-04-18 15:47 ` Sergey Fedorov
2016-04-21 17:36 ` Sergey Fedorov
2016-04-21 17:49 ` Alex Bennée
2016-04-21 18:56 ` Sergey Fedorov
2016-04-22 8:08 ` Cornelia Huck
2016-05-09 12:49 ` Paolo Bonzini
2016-05-10 10:47 ` Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 03/11] tci: Make direct jump patching thread-safe Sergey Fedorov
2016-04-20 9:42 ` Alex Bennée
2016-04-20 11:40 ` Sergey Fedorov
2016-04-20 13:14 ` Alex Bennée
2016-04-22 11:31 ` Sergey Fedorov
2016-04-22 12:49 ` Alex Bennée
2016-04-07 15:53 ` [Qemu-devel] [PATCH 04/11] tcg/ppc: " Sergey Fedorov
2016-04-20 9:49 ` Alex Bennée
2016-04-07 15:53 ` [Qemu-devel] [PATCH 05/11] tcg/i386: " Sergey Fedorov
2016-04-20 9:55 ` Alex Bennée
2016-04-20 11:43 ` Sergey Fedorov
2016-04-20 15:04 ` Richard Henderson
2016-04-20 16:15 ` Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 06/11] tcg/s390: " Sergey Fedorov
2016-04-20 10:01 ` Alex Bennée
2016-04-20 11:45 ` Sergey Fedorov
2016-04-07 15:53 ` [PATCH 07/11] tcg/arm: " Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] " Sergey Fedorov
2016-04-20 13:33 ` Alex Bennée
2016-04-20 13:33 ` [Qemu-devel] " Alex Bennée
2016-04-20 14:29 ` Sergey Fedorov
2016-04-20 14:29 ` [Qemu-devel] " Sergey Fedorov
2016-04-20 14:40 ` Alex Bennée
2016-04-20 14:40 ` [Qemu-devel] " Alex Bennée
2016-04-20 16:12 ` Sergey Fedorov
2016-04-20 16:12 ` [Qemu-devel] " Sergey Fedorov
2016-04-07 15:53 ` [PATCH 08/11] tcg/aarch64: " Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] " Sergey Fedorov
2016-04-20 14:01 ` Alex Bennée
2016-04-20 14:01 ` [Qemu-devel] " Alex Bennée
2016-04-20 15:08 ` Richard Henderson
2016-04-20 15:08 ` [Qemu-devel] " Richard Henderson
2016-04-20 18:22 ` Alex Bennée
2016-04-20 18:22 ` [Qemu-devel] " Alex Bennée
2016-04-20 18:57 ` Richard Henderson
2016-04-20 18:57 ` [Qemu-devel] " Richard Henderson
2016-04-20 19:51 ` Alex Bennée
2016-04-20 19:51 ` [Qemu-devel] " Alex Bennée
2016-04-20 18:44 ` Sergey Fedorov
2016-04-20 18:44 ` [Qemu-devel] " Sergey Fedorov
2016-04-21 15:47 ` Sergey Fedorov
2016-04-21 15:47 ` [Qemu-devel] " Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 09/11] tcg/sparc: " Sergey Fedorov
2016-04-20 14:23 ` Alex Bennée
2016-04-07 15:53 ` [Qemu-devel] [PATCH 10/11] tcg/mips: " Sergey Fedorov
2016-04-07 16:01 ` Paolo Bonzini
2016-04-07 16:09 ` Sergey Fedorov
2016-04-07 15:53 ` [Qemu-devel] [PATCH 11/11] tcg: Note requirement on atomic direct jump patching Sergey Fedorov
2016-04-20 14:25 ` Alex Bennée [this message]
2016-04-07 15:56 ` [Qemu-devel] [PATCH 00/11] tcg: Make direct jump patching thread-safe Sergey Fedorov
2016-04-20 8:44 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9ewuzlq.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=serge.fdrv@gmail.com \
--cc=sergey.fedorov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.