From: Jani Nikula <jani.nikula@linux.intel.com>
To: Sean Paul <seanpaul@chromium.org>,
dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch,
airlied@linux.ie
Cc: daniels@collabora.com, mmaneetsingh@nvidia.com
Subject: Re: [PATCH] drm: Correct arguments to list_tail_add in create blob ioctl
Date: Thu, 08 Oct 2015 17:51:39 +0300 [thread overview]
Message-ID: <87h9m176ro.fsf@intel.com> (raw)
In-Reply-To: <1444313424-31988-1-git-send-email-seanpaul@chromium.org>
On Thu, 08 Oct 2015, Sean Paul <seanpaul@chromium.org> wrote:
> From: Maneet Singh <mmaneetsingh@nvidia.com>
>
> From: Maneet Singh <mmaneetsingh@nvidia.com>
>
> Arguments passed to list_add_tail were reversed resulting in deletion
> of old blob property everytime the new one is added.
>
> Signed-off-by: Maneet Singh <mmaneetsingh@nvidia.com>
> [seanpaul tweaked commit subject a little]
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> Reviewed-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Fixes
commit e2f5d2ea479b9b2619965d43db70939589afe43a
Author: Daniel Stone <daniels@collabora.com>
Date: Fri May 22 13:34:51 2015 +0100
drm/mode: Add user blob-creation ioctl
> ---
> drivers/gpu/drm/drm_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index e600a5f..049c7b7 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -4454,7 +4454,7 @@ int drm_mode_createblob_ioctl(struct drm_device *dev,
> * not associated with any file_priv. */
> mutex_lock(&dev->mode_config.blob_lock);
> out_resp->blob_id = blob->base.id;
> - list_add_tail(&file_priv->blobs, &blob->head_file);
> + list_add_tail(&blob->head_file, &file_priv->blobs);
> mutex_unlock(&dev->mode_config.blob_lock);
>
> return 0;
> --
> 2.6.0.rc2.230.g3dd15c0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-10-08 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 14:10 [PATCH] drm: Correct arguments to list_tail_add in create blob ioctl Sean Paul
2015-10-08 14:51 ` Jani Nikula [this message]
2015-10-29 11:07 ` Daniel Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9m176ro.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=mmaneetsingh@nvidia.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.