[PATCH] drm: Correct arguments to list_tail_add in create blob ioctl

[PATCH] drm: Correct arguments to list_tail_add in create blob ioctl

[Sean Paul]

From: Maneet Singh <mmaneetsingh@nvidia.com>

From: Maneet Singh <mmaneetsingh@nvidia.com>

Arguments passed to list_add_tail were reversed resulting in deletion
of old blob property everytime the new one is added.

Signed-off-by: Maneet Singh <mmaneetsingh@nvidia.com>
[seanpaul tweaked commit subject a little]
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Daniel Stone <daniels@collabora.com>
---
 drivers/gpu/drm/drm_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index e600a5f..049c7b7 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -4454,7 +4454,7 @@ int drm_mode_createblob_ioctl(struct drm_device *dev,
 	 * not associated with any file_priv. */
 	mutex_lock(&dev->mode_config.blob_lock);
 	out_resp->blob_id = blob->base.id;
-	list_add_tail(&file_priv->blobs, &blob->head_file);
+	list_add_tail(&blob->head_file, &file_priv->blobs);
 	mutex_unlock(&dev->mode_config.blob_lock);
 
 	return 0;
-- 
2.6.0.rc2.230.g3dd15c0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: Correct arguments to list_tail_add in create blob ioctl

[Jani Nikula]

On Thu, 08 Oct 2015, Sean Paul <seanpaul@chromium.org> wrote:
> From: Maneet Singh <mmaneetsingh@nvidia.com>
>
> From: Maneet Singh <mmaneetsingh@nvidia.com>
>
> Arguments passed to list_add_tail were reversed resulting in deletion
> of old blob property everytime the new one is added.
>
> Signed-off-by: Maneet Singh <mmaneetsingh@nvidia.com>
> [seanpaul tweaked commit subject a little]
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> Reviewed-by: Daniel Stone <daniels@collabora.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Fixes

commit e2f5d2ea479b9b2619965d43db70939589afe43a
Author: Daniel Stone <daniels@collabora.com>
Date:   Fri May 22 13:34:51 2015 +0100

    drm/mode: Add user blob-creation ioctl




> ---
>  drivers/gpu/drm/drm_crtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index e600a5f..049c7b7 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -4454,7 +4454,7 @@ int drm_mode_createblob_ioctl(struct drm_device *dev,
>  	 * not associated with any file_priv. */
>  	mutex_lock(&dev->mode_config.blob_lock);
>  	out_resp->blob_id = blob->base.id;
> -	list_add_tail(&file_priv->blobs, &blob->head_file);
> +	list_add_tail(&blob->head_file, &file_priv->blobs);
>  	mutex_unlock(&dev->mode_config.blob_lock);
>  
>  	return 0;
> -- 
> 2.6.0.rc2.230.g3dd15c0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: Correct arguments to list_tail_add in create blob ioctl

[Daniel Stone]

Hi Dave,

On 8 October 2015 at 15:51, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Thu, 08 Oct 2015, Sean Paul <seanpaul@chromium.org> wrote:
>> From: Maneet Singh <mmaneetsingh@nvidia.com>
>>
>> From: Maneet Singh <mmaneetsingh@nvidia.com>
>>
>> Arguments passed to list_add_tail were reversed resulting in deletion
>> of old blob property everytime the new one is added.
>>
>> Signed-off-by: Maneet Singh <mmaneetsingh@nvidia.com>
>> [seanpaul tweaked commit subject a little]
>> Signed-off-by: Sean Paul <seanpaul@chromium.org>
>> Reviewed-by: Daniel Stone <daniels@collabora.com>
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Fixes
>
> commit e2f5d2ea479b9b2619965d43db70939589afe43a
> Author: Daniel Stone <daniels@collabora.com>
> Date:   Fri May 22 13:34:51 2015 +0100
>
>     drm/mode: Add user blob-creation ioctl

Could you please pick this up, CC'ed to stable for 4.2? igt to catch
this is here:
http://lists.freedesktop.org/archives/intel-gfx/2015-October/079069.html

Cheers,
Daniel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel