From: Ben Gamari <ben@smart-cactus.org>
To: Thierry Reding <thierry.reding@gmail.com>,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Cc: Guenter Roeck <linux@roeck-us.net>,
Anand Moon <linux.amoon@gmail.com>,
Lukasz Majewski <l.majewski@samsung.com>,
Eduardo Valentin <edubezval@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Markus Reichl <m.reichl@fivetechno.de>
Subject: Re: [PATCH 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan
Date: Fri, 10 Apr 2015 13:25:52 -0400 [thread overview]
Message-ID: <87h9snvqsf.fsf@gmail.com> (raw)
In-Reply-To: <20150410135844.GA20147@ulmo.nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1184 bytes --]
Thierry Reding <thierry.reding@gmail.com> writes:
> On Fri, Apr 10, 2015 at 03:30:01PM +0200, Sjoerd Simons wrote:
>>
>> Yes/no/maybe :). Imho this is something to clarify in the pwm API
>> documentation. As currently all it says is:
>> "pwm_disable - stop a PWM output toggling",
>>
>> Which is what the exynos driver does.
>>
>> Thierry, could you clearify what the intention is here? I'm happy to
>> prepare a pwm driver patch if needed to solve this?
>
> I think the safest thing to do is for users to do both. You call
> pwm_config() with a zero duty cycle to make it clear what the status is
> that you want. Then you call pwm_disable() to state that you don't need
> the output signal anymore, so that any clocks needed by the PWM can be
> stopped. Doing so gives the driver the most information and should make
> the user more resilient against any possible quirks in drivers.
>
It would be great if the documentation were more clear on this matter
regardless. This is something I can imagine having to spend substantial
amounts of time Googling whereas a simple note in the documentation would
have removed all ambiguity.
Cheers,
- Ben
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: ben@smart-cactus.org (Ben Gamari)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan
Date: Fri, 10 Apr 2015 13:25:52 -0400 [thread overview]
Message-ID: <87h9snvqsf.fsf@gmail.com> (raw)
In-Reply-To: <20150410135844.GA20147@ulmo.nvidia.com>
Thierry Reding <thierry.reding@gmail.com> writes:
> On Fri, Apr 10, 2015 at 03:30:01PM +0200, Sjoerd Simons wrote:
>>
>> Yes/no/maybe :). Imho this is something to clarify in the pwm API
>> documentation. As currently all it says is:
>> "pwm_disable - stop a PWM output toggling",
>>
>> Which is what the exynos driver does.
>>
>> Thierry, could you clearify what the intention is here? I'm happy to
>> prepare a pwm driver patch if needed to solve this?
>
> I think the safest thing to do is for users to do both. You call
> pwm_config() with a zero duty cycle to make it clear what the status is
> that you want. Then you call pwm_disable() to state that you don't need
> the output signal anymore, so that any clocks needed by the PWM can be
> stopped. Doing so gives the driver the most information and should make
> the user more resilient against any possible quirks in drivers.
>
It would be great if the documentation were more clear on this matter
regardless. This is something I can imagine having to spend substantial
amounts of time Googling whereas a simple note in the documentation would
have removed all ambiguity.
Cheers,
- Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 472 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150410/698d67eb/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Ben Gamari <ben@smart-cactus.org>
To: Thierry Reding <thierry.reding@gmail.com>,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Cc: Guenter Roeck <linux@roeck-us.net>,
Anand Moon <linux.amoon@gmail.com>,
Lukasz Majewski <l.majewski@samsung.com>,
Eduardo Valentin <edubezval@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org,
"linux-samsung-soc\@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Markus Reichl <m.reichl@fivetechno.de>
Subject: Re: [PATCH 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan
Date: Fri, 10 Apr 2015 13:25:52 -0400 [thread overview]
Message-ID: <87h9snvqsf.fsf@gmail.com> (raw)
In-Reply-To: <20150410135844.GA20147@ulmo.nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1184 bytes --]
Thierry Reding <thierry.reding@gmail.com> writes:
> On Fri, Apr 10, 2015 at 03:30:01PM +0200, Sjoerd Simons wrote:
>>
>> Yes/no/maybe :). Imho this is something to clarify in the pwm API
>> documentation. As currently all it says is:
>> "pwm_disable - stop a PWM output toggling",
>>
>> Which is what the exynos driver does.
>>
>> Thierry, could you clearify what the intention is here? I'm happy to
>> prepare a pwm driver patch if needed to solve this?
>
> I think the safest thing to do is for users to do both. You call
> pwm_config() with a zero duty cycle to make it clear what the status is
> that you want. Then you call pwm_disable() to state that you don't need
> the output signal anymore, so that any clocks needed by the PWM can be
> stopped. Doing so gives the driver the most information and should make
> the user more resilient against any possible quirks in drivers.
>
It would be great if the documentation were more clear on this matter
regardless. This is something I can imagine having to spend substantial
amounts of time Googling whereas a simple note in the documentation would
have removed all ambiguity.
Cheers,
- Ben
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]
next prev parent reply other threads:[~2015-04-10 17:25 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 16:39 Exynos5422 odroidxu3 pwm-fan control using thermal sensors Anand Moon
2015-03-26 16:39 ` Anand Moon
2015-03-26 16:39 ` [PATCH 1/6] ARM: dts :exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board Anand Moon
2015-03-26 16:39 ` Anand Moon
2015-04-08 7:46 ` Lukasz Majewski
2015-04-08 7:46 ` Lukasz Majewski
2015-03-26 16:39 ` [PATCH 2/6] ARM: dts exynos5420 update the cooling cells for core cpu0 Anand Moon
2015-03-26 16:39 ` Anand Moon
2015-04-08 7:47 ` Lukasz Majewski
2015-04-08 7:47 ` Lukasz Majewski
2015-03-26 16:39 ` [PATCH 3/6] ARM:dts exynos5422 Update the thermal sensor for tmu_cpu0 Anand Moon
2015-03-26 16:39 ` Anand Moon
2015-04-08 8:02 ` Lukasz Majewski
2015-04-08 8:02 ` Lukasz Majewski
2015-04-08 8:02 ` Lukasz Majewski
2015-04-08 9:12 ` Anand Moon
2015-04-08 9:12 ` Anand Moon
2015-04-08 9:12 ` Anand Moon
2015-04-08 9:30 ` Lukasz Majewski
2015-04-08 9:30 ` Lukasz Majewski
2015-04-08 9:44 ` Anand Moon
2015-04-08 9:44 ` Anand Moon
2015-03-26 16:39 ` [PATCH 4/6] ARM: dts: OdroidXU3: Enable TMU at Exynos5422 base Anand Moon
2015-03-26 16:39 ` Anand Moon
2015-04-08 8:03 ` Lukasz Majewski
2015-04-08 8:03 ` Lukasz Majewski
2015-03-26 16:39 ` [PATCH 5/6] pwm: samsung: Fix output race on disabling Anand Moon
2015-03-26 16:39 ` Anand Moon
2015-03-26 16:39 ` Anand Moon
2015-04-08 8:28 ` Lukasz Majewski
2015-04-08 8:28 ` Lukasz Majewski
2015-04-08 8:42 ` Sjoerd Simons
2015-04-08 8:42 ` Sjoerd Simons
2015-04-08 8:53 ` Anand Moon
2015-04-08 8:53 ` Anand Moon
2015-03-26 16:39 ` [PATCH 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan Anand Moon
2015-03-26 16:39 ` Anand Moon
2015-04-08 8:44 ` Lukasz Majewski
2015-04-08 8:44 ` Lukasz Majewski
2015-04-08 13:11 ` Guenter Roeck
2015-04-08 13:11 ` Guenter Roeck
2015-04-08 15:32 ` Guenter Roeck
2015-04-08 15:32 ` Guenter Roeck
2015-04-08 16:02 ` Anand Moon
2015-04-08 16:02 ` Anand Moon
2015-04-08 16:53 ` Guenter Roeck
2015-04-08 16:53 ` Guenter Roeck
2015-04-08 17:49 ` Anand Moon
2015-04-08 17:49 ` Anand Moon
2015-04-10 11:28 ` Anand Moon
2015-04-10 11:28 ` Anand Moon
2015-04-10 12:00 ` Sjoerd Simons
2015-04-10 12:00 ` Sjoerd Simons
2015-04-10 12:00 ` Sjoerd Simons
[not found] ` <1428667201.22057.20.camel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-04-10 12:59 ` Anand Moon
2015-04-10 12:59 ` Anand Moon
2015-04-10 12:59 ` Anand Moon
2015-04-10 13:09 ` Guenter Roeck
2015-04-10 13:09 ` Guenter Roeck
2015-04-10 13:17 ` Anand Moon
2015-04-10 13:17 ` Anand Moon
2015-04-10 13:30 ` Sjoerd Simons
2015-04-10 13:30 ` Sjoerd Simons
2015-04-10 13:30 ` Sjoerd Simons
2015-04-10 13:58 ` Thierry Reding
2015-04-10 13:58 ` Thierry Reding
2015-04-10 17:25 ` Ben Gamari [this message]
2015-04-10 17:25 ` Ben Gamari
2015-04-10 17:25 ` Ben Gamari
2015-04-10 17:58 ` Guenter Roeck
2015-04-10 17:58 ` Guenter Roeck
2015-04-02 10:02 ` Exynos5422 odroidxu3 pwm-fan control using thermal sensors Markus Reichl
2015-04-02 10:02 ` Markus Reichl
2015-04-02 10:06 ` Markus Reichl
2015-04-02 10:06 ` Markus Reichl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9snvqsf.fsf@gmail.com \
--to=ben@smart-cactus.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=kgene@kernel.org \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=linux@arm.linux.org.uk \
--cc=linux@roeck-us.net \
--cc=m.reichl@fivetechno.de \
--cc=sjoerd.simons@collabora.co.uk \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.