From: Rusty Russell <rusty@rustcorp.com.au>
To: Venkatesh Srinivas <venkateshs@google.com>
Cc: virtualization@lists.linux-foundation.org,
Theodore Ts'o <tytso@mit.edu>,
Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor
Date: Mon, 31 Mar 2014 14:22:50 +1030 [thread overview]
Message-ID: <87ha6fowh9.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAHdzE--CvgsPOFQ5OFRoe7L+kkJ0J3eRWR0JQv34i4AmNDBJug@mail.gmail.com>
Venkatesh Srinivas <venkateshs@google.com> writes:
> On Wed, Mar 19, 2014 at 10:48 AM, Venkatesh Srinivas
> <venkateshs@google.com> wrote:
>>> And I rewrote it substantially, mainly to take
>>> VIRTIO_RING_F_INDIRECT_DESC into account.
>>>
>>> As QEMU sets the vq size for PCI to 128, Venkatash's patch wouldn't
>>> have made a change. This version does (since QEMU also offers
>>> VIRTIO_RING_F_INDIRECT_DESC.
>>
>> That divide-by-2 produced the same queue depth as the prior
>> computation in QEMU was deliberate -- but raising it to 128 seems
>> pretty reasonable.
>>
>> Signed-off-by: Venkatesh Srinivas <venkateshs@google.com>
>
> Soft ping about this patch.
It's head of my virtio-next tree.
Cheers,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Venkatesh Srinivas <venkateshs@google.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor
Date: Mon, 31 Mar 2014 14:22:50 +1030 [thread overview]
Message-ID: <87ha6fowh9.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAHdzE--CvgsPOFQ5OFRoe7L+kkJ0J3eRWR0JQv34i4AmNDBJug@mail.gmail.com>
Venkatesh Srinivas <venkateshs@google.com> writes:
> On Wed, Mar 19, 2014 at 10:48 AM, Venkatesh Srinivas
> <venkateshs@google.com> wrote:
>>> And I rewrote it substantially, mainly to take
>>> VIRTIO_RING_F_INDIRECT_DESC into account.
>>>
>>> As QEMU sets the vq size for PCI to 128, Venkatash's patch wouldn't
>>> have made a change. This version does (since QEMU also offers
>>> VIRTIO_RING_F_INDIRECT_DESC.
>>
>> That divide-by-2 produced the same queue depth as the prior
>> computation in QEMU was deliberate -- but raising it to 128 seems
>> pretty reasonable.
>>
>> Signed-off-by: Venkatesh Srinivas <venkateshs@google.com>
>
> Soft ping about this patch.
It's head of my virtio-next tree.
Cheers,
Rusty.
next prev parent reply other threads:[~2014-03-31 3:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 23:57 [PATCH] virtio-blk: Initialize blkqueue depth from virtqueue size Venkatesh Srinivas
2014-03-15 3:34 ` [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor Theodore Ts'o
2014-03-15 3:34 ` Theodore Ts'o
2014-03-15 10:57 ` Konrad Rzeszutek Wilk
2014-03-15 10:57 ` Konrad Rzeszutek Wilk
2014-03-15 13:20 ` Theodore Ts'o
2014-03-15 13:20 ` Theodore Ts'o
2014-03-15 13:57 ` Christoph Hellwig
2014-03-15 13:57 ` Christoph Hellwig
2014-03-15 15:13 ` Theodore Ts'o
2014-03-15 15:13 ` Theodore Ts'o
2014-03-17 0:42 ` Rusty Russell
2014-03-17 0:42 ` Rusty Russell
2014-03-17 5:40 ` tytso
2014-03-17 5:40 ` tytso
2014-03-19 6:28 ` Rusty Russell
2014-03-19 6:28 ` Rusty Russell
2014-03-19 17:48 ` Venkatesh Srinivas
2014-03-19 17:48 ` Venkatesh Srinivas
2014-03-25 18:50 ` Venkatesh Srinivas
2014-03-25 18:50 ` Venkatesh Srinivas
2014-03-31 3:52 ` Rusty Russell [this message]
2014-03-31 3:52 ` Rusty Russell
2014-04-01 2:27 ` Theodore Ts'o
2014-04-01 10:49 ` Stefan Hajnoczi
2014-04-02 7:36 ` Rusty Russell
2014-04-01 2:27 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ha6fowh9.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=tytso@mit.edu \
--cc=venkateshs@google.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.