[PATCH] ARM: mvebu: Add Netgear ReadyNAS 2120 board

[arno@natisbad.org (Arnaud Ebalard)]

Hi Sebastian,

Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> writes:

> On 11/09/2013 09:27 PM, Arnaud Ebalard wrote:
>> All hardware parts of the (mv78230 Armada XP based) NETGEAR ReadyNAS
>> 2120 are supported by mainline kernel (USB 3.0 and eSATA rear ports,
>> USB 2.0 front port, Gigabit controller and PHYs for the two rear ports,
>> serial port, LEDs, Buttons, 88SE9170 SATA controllers, three G762 fan
>> controllers, G751 temperature sensor) except for:
>>
>>   - the Intersil ISL12057 I2C RTC Chip,
>>   - the Armada NAND controller.
>>
>> Support for both of those is currently work in progress and does not
>> prevent boot.
>>
>> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
>> ---
> [...]
>>   arch/arm/boot/dts/Makefile                     |   1 +
>>   arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 289 +++++++++++++++++++++++++
>
> Arnaud,
>
> thanks for providing this! I do have some comments below.
>
> we recently had a discussion about the naming of new DTS files, which
> proposes to name those after vendor,board.dts (or vendor-board.dts).
>
> I personally prefer vendor,board.dts which would give
> netgear,readynas-2120.dts based on your compatible below.
> The final call for ',' vs '-' has not been made, so I  suggest Jason
> makes a call here.

ok, will wait for a decision before resending. I a am not in a hurry.

>> +
>> +			serial at 12000 {
>> +				clock-frequency = <250000000>;
>
> Where does that 250MHz come from? If it is an internal clock
> and we already have a DT clock provider for it, please use
> clocks = <&provider num>;
>
> If it is TCLK it can be optained from <&coreclk 0>.

Well, no innovation here: to be honest - it's not a valid argument but -
I copy pasted the line from other armada-xp-*.dts files:

$ grep 250000000 armada-xp-*.dts
armada-xp-axpwifiap.dts:                                clock-frequency = <250000000>;
armada-xp-axpwifiap.dts:                                clock-frequency = <250000000>;
armada-xp-db.dts:                               clock-frequency = <250000000>;
armada-xp-db.dts:                               clock-frequency = <250000000>;
armada-xp-db.dts:                               clock-frequency = <250000000>;
armada-xp-db.dts:                               clock-frequency = <250000000>;
armada-xp-gp.dts:                               clock-frequency = <250000000>;
armada-xp-gp.dts:                               clock-frequency = <250000000>;
armada-xp-gp.dts:                               clock-frequency = <250000000>;
armada-xp-gp.dts:                               clock-frequency = <250000000>;
armada-xp-openblocks-ax3-4.dts:                         clock-frequency = <250000000>;
armada-xp-openblocks-ax3-4.dts:                         clock-frequency = <250000000>;

I will use <&coreclk 0> in next resend.


>
>> +				status = "okay";
>> +			};
>> +
>> +			mdio {
>> +				phy0: ethernet-phy at 0 {
>> +					reg = <0>;
>
> Can you evaluate PHYs compatible from u-boot or post vendor:prodid
> from MDIO registers?

Looking at the PCB, 88E1318-NNB2. I will dig into Documentation/ the
associated compatible. Out of curiosity, how do you get the PHY model
from u-boot or userland?


>> +
>> +	clocks {
>> +	       #address-cells = <1>;
>> +	       #size-cells = <0>;
>
> Your nodes below neither have a reg property nor can they be
> addressed in any way.

I think I do not understand that comment. Can you clarify, possibly w/
an example of you think is wrong and how it could be corrected? 


> Both properties above are not required, so please remove them.
>
>> +	       g762_clk: fixedclk {
>
> s/fixedclk/oscillator/ ?
>
>> +			 compatible = "fixed-clock";
>> +			 #clock-cells = <0>;
>> +			 clock-frequency = <32768>;
>> +	       };
>> +	};
>> +

Something like the following?

        clocks {
               g762_clk: oscillator {
                         compatible = "fixed-clock";
                         #clock-cells = <0>;
                         clock-frequency = <32768>;
               };
        };

I think I could then backport that change to all readynas .dts and
the Documentation/devicetree/bindings/hwmon/g762.txt at some point.


>> +	gpio_leds {
>> +		compatible = "gpio-leds";
>> +		pinctrl-0 = <&sata1_led_pin &sata2_led_pin &err_led_pin
>> +			     &sata3_led_pin &sata4_led_pin>;
>> +		pinctrl-names = "default";
>> +
>> +		red_sata1_led {
>> +			label = "rn2120:red:sata1";
>> +			gpios = <&gpio0 31 0>;   /* GPIO 31 Active High */
>
> You can
>
> #include <dt-bindings/gpio/gpio.h>
>
> then use
>
> gpios = <&gpio0 31 GPIO_ACTIVE_HIGH>
>
> and get rid of the comments.

ok, will do.


>> +			default-state = "off";
>> +		};
>> +
>> +		red_sata2_led {
>> +			label = "rn2120:red:sata2";
>> +			gpios = <&gpio1 8 0>;   /* GPIO 40 Active High */
>> +			default-state = "off";
>> +		};
>> +
>> +		red_sata3_led {
>> +			label = "rn2120:red:sata3";
>> +			gpios = <&gpio1 12 0>;   /* GPIO 44 Active High */
>> +			default-state = "off";
>> +		};
>> +
>> +		red_sata4_led {
>> +			label = "rn2120:red:sata4";
>> +			gpios = <&gpio1 15 0>;   /* GPIO 47 Active High */
>> +			default-state = "off";
>> +		};
>> +
>> +		red_err_led {
>> +			label = "rn2120:red:err";
>> +			gpios = <&gpio1 13 1>;   /* GPIO 45 Active Low */
>> +			default-state = "off";
>> +		};
>> +	};
>> +
>> +	gpio_keys {
>> +		compatible = "gpio-keys";
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>
> Again, no addressing of those buttons possible.
>
>> +		pinctrl-0 = <&power_key_pin
>> +			     &reset_key_pin>;
>> +		pinctrl-names = "default";
>> +
>> +		button at 1 {
>
> Instead of button at n you can name the nodes after their function,
> e.g. power_button, reset_button, ...

ok, will change that.


> I know both comments above are in the current binding documentation
> (at least for gpio-keys-polled.txt, there is no gpio-keys.txt); but
> IMHO both "bus-like" structure of gpio_keys and numbering of buttons
> just looks so wrong.


Thanks for your feedback.

Cheers,

a+