* [PATCH] ARM: omap2: throw the die id into the entropy pool
@ 2013-09-04 20:25 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-09-04 20:25 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-arm-kernel, linux-omap, Linus Walleij, Theodore Ts'o,
Paul Walmsley
Atleast eight bytes of this number are totally unique for the device
it seems, so this is a perfect candidate for feeding the entropy
pool. One byte more or less of constants does not matter so feed in
the entire OID struct.
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
arch/arm/mach-omap2/id.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
index 2dc62a2..fc03cc6 100644
--- a/arch/arm/mach-omap2/id.c
+++ b/arch/arm/mach-omap2/id.c
@@ -18,6 +18,7 @@
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/io.h>
+#include <linux/random.h>
#include <linux/slab.h>
#ifdef CONFIG_SOC_BUS
@@ -130,6 +131,17 @@ void omap_get_die_id(struct omap_die_id *odi)
odi->id_3 = read_tap_reg(OMAP_TAP_DIE_ID_3);
}
+static int __init omap_feed_randpool(void)
+{
+ struct omap_die_id odi;
+
+ /* Throw the die ID into the entropy pool at boot */
+ omap_get_die_id(&odi);
+ add_device_randomness(&odi, sizeof(odi));
+ return 0;
+}
+device_initcall(omap_feed_randpool);
+
void __init omap2xxx_check_revision(void)
{
int i, j;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: omap2: throw the die id into the entropy pool
@ 2013-09-04 20:25 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-09-04 20:25 UTC (permalink / raw)
To: linux-arm-kernel
Atleast eight bytes of this number are totally unique for the device
it seems, so this is a perfect candidate for feeding the entropy
pool. One byte more or less of constants does not matter so feed in
the entire OID struct.
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
arch/arm/mach-omap2/id.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
index 2dc62a2..fc03cc6 100644
--- a/arch/arm/mach-omap2/id.c
+++ b/arch/arm/mach-omap2/id.c
@@ -18,6 +18,7 @@
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/io.h>
+#include <linux/random.h>
#include <linux/slab.h>
#ifdef CONFIG_SOC_BUS
@@ -130,6 +131,17 @@ void omap_get_die_id(struct omap_die_id *odi)
odi->id_3 = read_tap_reg(OMAP_TAP_DIE_ID_3);
}
+static int __init omap_feed_randpool(void)
+{
+ struct omap_die_id odi;
+
+ /* Throw the die ID into the entropy pool at boot */
+ omap_get_die_id(&odi);
+ add_device_randomness(&odi, sizeof(odi));
+ return 0;
+}
+device_initcall(omap_feed_randpool);
+
void __init omap2xxx_check_revision(void)
{
int i, j;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: omap2: throw the die id into the entropy pool
2013-09-04 20:25 ` Linus Walleij
@ 2013-09-04 22:24 ` Kevin Hilman
-1 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2013-09-04 22:24 UTC (permalink / raw)
To: Linus Walleij
Cc: Tony Lindgren, linux-arm-kernel, linux-omap, Theodore Ts'o,
Paul Walmsley
Linus Walleij <linus.walleij@linaro.org> writes:
> Atleast eight bytes of this number are totally unique for the device
> it seems, so this is a perfect candidate for feeding the entropy
> pool. One byte more or less of constants does not matter so feed in
> the entire OID struct.
>
> Cc: Theodore Ts'o <tytso@mit.edu>
> Cc: Paul Walmsley <paul@pwsan.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> arch/arm/mach-omap2/id.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> index 2dc62a2..fc03cc6 100644
> --- a/arch/arm/mach-omap2/id.c
> +++ b/arch/arm/mach-omap2/id.c
> @@ -18,6 +18,7 @@
> #include <linux/kernel.h>
> #include <linux/init.h>
> #include <linux/io.h>
> +#include <linux/random.h>
> #include <linux/slab.h>
>
> #ifdef CONFIG_SOC_BUS
> @@ -130,6 +131,17 @@ void omap_get_die_id(struct omap_die_id *odi)
> odi->id_3 = read_tap_reg(OMAP_TAP_DIE_ID_3);
> }
>
> +static int __init omap_feed_randpool(void)
> +{
> + struct omap_die_id odi;
> +
> + /* Throw the die ID into the entropy pool at boot */
> + omap_get_die_id(&odi);
> + add_device_randomness(&odi, sizeof(odi));
> + return 0;
> +}
> +device_initcall(omap_feed_randpool);
Needs to be omap_device_initcall() so it doesn't get called on non-OMAPs
in a multi-platform kernel.
Otherwise looks good.
Reviewed-by: Kevin Hilman <khilman@linaro.org>
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: omap2: throw the die id into the entropy pool
@ 2013-09-04 22:24 ` Kevin Hilman
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2013-09-04 22:24 UTC (permalink / raw)
To: linux-arm-kernel
Linus Walleij <linus.walleij@linaro.org> writes:
> Atleast eight bytes of this number are totally unique for the device
> it seems, so this is a perfect candidate for feeding the entropy
> pool. One byte more or less of constants does not matter so feed in
> the entire OID struct.
>
> Cc: Theodore Ts'o <tytso@mit.edu>
> Cc: Paul Walmsley <paul@pwsan.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> arch/arm/mach-omap2/id.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> index 2dc62a2..fc03cc6 100644
> --- a/arch/arm/mach-omap2/id.c
> +++ b/arch/arm/mach-omap2/id.c
> @@ -18,6 +18,7 @@
> #include <linux/kernel.h>
> #include <linux/init.h>
> #include <linux/io.h>
> +#include <linux/random.h>
> #include <linux/slab.h>
>
> #ifdef CONFIG_SOC_BUS
> @@ -130,6 +131,17 @@ void omap_get_die_id(struct omap_die_id *odi)
> odi->id_3 = read_tap_reg(OMAP_TAP_DIE_ID_3);
> }
>
> +static int __init omap_feed_randpool(void)
> +{
> + struct omap_die_id odi;
> +
> + /* Throw the die ID into the entropy pool at boot */
> + omap_get_die_id(&odi);
> + add_device_randomness(&odi, sizeof(odi));
> + return 0;
> +}
> +device_initcall(omap_feed_randpool);
Needs to be omap_device_initcall() so it doesn't get called on non-OMAPs
in a multi-platform kernel.
Otherwise looks good.
Reviewed-by: Kevin Hilman <khilman@linaro.org>
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-04 22:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-04 20:25 [PATCH] ARM: omap2: throw the die id into the entropy pool Linus Walleij
2013-09-04 20:25 ` Linus Walleij
2013-09-04 22:24 ` Kevin Hilman
2013-09-04 22:24 ` Kevin Hilman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.