From: Chris Ball <cjb@laptop.org>
To: Marek Vasut <marex@denx.de>
Cc: linux-mmc@vger.kernel.org, "Shawn Guo" <shawn.guo@linaro.org>,
"Fabio Estevam" <fabio.estevam@freescale.com>,
"Lothar Waßmann" <LW@karo-electronics.de>
Subject: Re: [PATCH] mmc: mxs-mmc: Add wp-inverted property
Date: Thu, 19 Jul 2012 11:02:10 -0400 [thread overview]
Message-ID: <87hat394lp.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1339181738-22769-1-git-send-email-marex@denx.de> (Marek Vasut's message of "Fri, 8 Jun 2012 20:55:38 +0200")
Hi Marek,
On Fri, Jun 08 2012, Marek Vasut wrote:
> The write-protect GPIO is inverted on some boards. Handle such case.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: linux-mmc@vger.kernel.org
> Cc: Chris Ball <cjb@laptop.org>
> Cc: Lothar Waßmann <LW@karo-electronics.de>
> ---
> drivers/mmc/host/mxs-mmc.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
> index 34a9026..c6964e1 100644
> --- a/drivers/mmc/host/mxs-mmc.c
> +++ b/drivers/mmc/host/mxs-mmc.c
> @@ -164,16 +164,23 @@ struct mxs_mmc_host {
> spinlock_t lock;
> int sdio_irq_en;
> int wp_gpio;
> + int wp_inverted:1;
Mind if I change this to "bool wp_inverted;"? Other than that, looks
fine and I'll merge it for 3.6.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-07-19 15:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 18:55 [PATCH] mmc: mxs-mmc: Add wp-inverted property Marek Vasut
2012-07-19 11:50 ` Marek Vasut
2012-07-19 15:02 ` Chris Ball [this message]
2012-07-19 15:06 ` Marek Vasut
2012-07-19 15:12 ` Chris Ball
-- strict thread matches above, loose matches on Subject: below --
2012-05-21 21:01 Marek Vasut
2012-05-21 21:01 ` Marek Vasut
2012-05-21 21:17 ` Guennadi Liakhovetski
2012-05-21 21:17 ` Guennadi Liakhovetski
2012-05-21 3:36 Marek Vasut
2012-05-21 3:36 ` Marek Vasut
2012-05-21 3:45 ` Chris Ball
2012-05-21 3:45 ` Chris Ball
2012-05-21 3:49 ` Marek Vasut
2012-05-21 3:49 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hat394lp.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=LW@karo-electronics.de \
--cc=fabio.estevam@freescale.com \
--cc=linux-mmc@vger.kernel.org \
--cc=marex@denx.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.