From: Juan Quintela <quintela@redhat.com>
To: Igor Mitsyanko <i.mitsyanko@samsung.com>
Cc: peter.maydell@linaro.org, balrog@zabor.org,
e.voevodin@samsung.com, qemu-devel@nongnu.org,
kyungmin.park@samsung.com, d.solodkiy@samsung.com,
m.kozlov@samsung.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 4/5] vmstate: refactor and move VMSTATE_UINTTL* macro
Date: Wed, 22 Feb 2012 15:00:26 +0100 [thread overview]
Message-ID: <87hayjufwl.fsf@elfo.elfo> (raw)
In-Reply-To: <1329905754-11873-5-git-send-email-i.mitsyanko@samsung.com> (Igor Mitsyanko's message of "Wed, 22 Feb 2012 14:15:53 +0400")
Igor Mitsyanko <i.mitsyanko@samsung.com> wrote:
> Instead of defining VMSTATE_UINTTL* based on TARGET_LONG_BITS value, we can
> use qemu_put_betls/qemu_get_betls functions. These two functions depend on
> TARGET_LONG_BITS as well, and this new approach for VMSTATE_UINTTL* will result
> in the same thing as before (will call qemu_get_be32s/qemu_put_be32s for 32-bit
> target or qemu_put_be64s/qemu_get_be64s for 64-bit target).
> Move VMSTATE_UINTTL* definitions to vmstate.h where they belong.
The idea was to removed the other functions. Notice that the cases are
equivalent. i.e. this just bring us a new type that we have to
represent, maintain. The other makes use to use a define, take your poison.
Later, Juan.
next prev parent reply other threads:[~2012-02-22 14:00 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 10:15 [Qemu-devel] [PATCH 0/5] VMState cleanups Igor Mitsyanko
2012-02-22 10:15 ` [Qemu-devel] [PATCH 1/5] target-alpha/machine.c: use VMSTATE_UINT64* instead of VMSTATE_UINTTL* Igor Mitsyanko
2012-02-22 11:19 ` Peter Maydell
2012-02-22 13:49 ` Juan Quintela
2012-02-22 10:15 ` [Qemu-devel] [PATCH 2/5] hw/pxa2xx_dma.c: drop VMSTATE_UINTTL usage Igor Mitsyanko
2012-02-22 11:06 ` Peter Maydell
2012-02-22 13:47 ` Juan Quintela
2012-02-22 13:52 ` Peter Maydell
2012-02-22 14:05 ` Juan Quintela
2012-02-22 10:15 ` [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: " Igor Mitsyanko
2012-02-22 11:07 ` Peter Maydell
2012-02-22 11:36 ` andrzej zaborowski
2012-02-22 12:00 ` Peter Maydell
2012-02-22 12:13 ` andrzej zaborowski
2012-02-22 12:48 ` Peter Maydell
2012-02-22 12:56 ` andrzej zaborowski
2012-02-22 13:32 ` Mitsyanko Igor
2012-02-22 13:56 ` Juan Quintela
2012-02-22 12:26 ` Mitsyanko Igor
2012-02-22 12:48 ` andrzej zaborowski
2012-02-22 13:30 ` Mitsyanko Igor
2012-02-22 10:15 ` [Qemu-devel] [PATCH 4/5] vmstate: refactor and move VMSTATE_UINTTL* macro Igor Mitsyanko
2012-02-22 14:00 ` Juan Quintela [this message]
2012-02-22 10:15 ` [Qemu-devel] [PATCH 5/5] vmstate: introduce get_bufsize entry in VMStateField Igor Mitsyanko
2012-02-22 11:26 ` [Qemu-devel] [PATCH 0/5] VMState cleanups Peter Maydell
2012-02-22 12:01 ` Mitsyanko Igor
2012-02-22 12:49 ` Andreas Färber
2012-02-22 12:50 ` Peter Maydell
2012-02-22 14:02 ` Juan Quintela
2012-02-22 15:37 ` Andreas Färber
2012-02-22 15:42 ` Peter Maydell
2012-02-22 16:04 ` Andreas Färber
2012-02-22 16:09 ` Peter Maydell
2012-02-22 23:41 ` Alexander Graf
2012-02-23 13:52 ` Juan Quintela
2012-02-22 12:06 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hayjufwl.fsf@elfo.elfo \
--to=quintela@redhat.com \
--cc=afaerber@suse.de \
--cc=balrog@zabor.org \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=i.mitsyanko@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=m.kozlov@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.