Re: [PATCH] ARM: OMAP4: cpuidle: Fix the C-state reporting to cpuidle governor.

[Kevin Hilman <khilman@ti.com>]

Santosh Shilimkar <santosh.shilimkar@ti.com> writes:

> OMAP4 cpuidle driver is reporting the state requested by governor rather than
> the actually attempted one.
>
> This is obviously misleading sysfs and powertop cpuidle statistics.
> Fix it so that stats are reported correctly.
>
> Reported-by: Kevin Hilman <khilman@ti.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
>  arch/arm/mach-omap2/cpuidle44xx.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c
> index cfdbb86..f128489 100644
> --- a/arch/arm/mach-omap2/cpuidle44xx.c
> +++ b/arch/arm/mach-omap2/cpuidle44xx.c
> @@ -85,6 +85,7 @@ static int omap4_enter_idle(struct cpuidle_device *dev,
>  	cpu1_state = pwrdm_read_pwrst(cpu1_pd);
>  	if (cpu1_state != PWRDM_POWER_OFF) {
>  		new_state_idx = drv->safe_state_index;
> +		index = drv->safe_state_index;

How about just get rid of new_state_idx all together and just update
index and use it to index in to the states.

Kevin

>  		cx = cpuidle_get_statedata(&dev->states_usage[new_state_idx]);
>  	}