From: Kevin Hilman <khilman@deeprootsystems.com>
To: Greg KH <greg@kroah.com>
Cc: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm@lists.infradead.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] OMAP: Serial: Define register access modes in LCR
Date: Wed, 17 Nov 2010 09:28:52 -0800 [thread overview]
Message-ID: <87hbff7tbf.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20101117161729.GF10992@kroah.com> (Greg KH's message of "Wed, 17 Nov 2010 08:17:29 -0800")
Greg KH <greg@kroah.com> writes:
> On Wed, Nov 17, 2010 at 10:31:52AM +0200, Emeltchenko Andrei wrote:
>> From: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
>>
>> Access to some registers depends on register access mode
>> Three different modes are available for OMAP (at least)
>> • Operational mode LCR_REG[7] = 0x0
>> • Configuration mode A LCR_REG[7] = 0x1 and LCR_REG[7:0]! = 0xBF
>> • Configuration mode B LCR_REG[7] = 0x1 and LCR_REG[7:0] = 0xBF
>>
>> Define access modes and remove redefinitions and magic numbers
>> in serial drivers (and later in bluetooth driver).
>>
>> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
>> ---
>> arch/arm/mach-omap2/serial.c | 12 ++++----
>> arch/arm/plat-omap/include/plat/omap-serial.h | 9 ------
>> drivers/serial/8250.c | 26 +++++++++---------
>> drivers/serial/omap-serial.c | 34 ++++++++++++------------
>> include/linux/serial_reg.h | 7 +++++
>
> What tree should this go through? THe omap or serial one?
Since this only affects OMAP drivers, we can take this through OMAP.
That will also help us avoid conflicts, as we'll hopefully be converting
the omap-serial driver to runtime PM for this next merge window as well.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Greg KH <greg@kroah.com>
Cc: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm@lists.infradead.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] OMAP: Serial: Define register access modes in LCR
Date: Wed, 17 Nov 2010 09:28:52 -0800 [thread overview]
Message-ID: <87hbff7tbf.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20101117161729.GF10992@kroah.com> (Greg KH's message of "Wed, 17 Nov 2010 08:17:29 -0800")
Greg KH <greg@kroah.com> writes:
> On Wed, Nov 17, 2010 at 10:31:52AM +0200, Emeltchenko Andrei wrote:
>> From: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
>>
>> Access to some registers depends on register access mode
>> Three different modes are available for OMAP (at least)
>> • Operational mode LCR_REG[7] = 0x0
>> • Configuration mode A LCR_REG[7] = 0x1 and LCR_REG[7:0]! = 0xBF
>> • Configuration mode B LCR_REG[7] = 0x1 and LCR_REG[7:0] = 0xBF
>>
>> Define access modes and remove redefinitions and magic numbers
>> in serial drivers (and later in bluetooth driver).
>>
>> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
>> ---
>> arch/arm/mach-omap2/serial.c | 12 ++++----
>> arch/arm/plat-omap/include/plat/omap-serial.h | 9 ------
>> drivers/serial/8250.c | 26 +++++++++---------
>> drivers/serial/omap-serial.c | 34 ++++++++++++------------
>> include/linux/serial_reg.h | 7 +++++
>
> What tree should this go through? THe omap or serial one?
Since this only affects OMAP drivers, we can take this through OMAP.
That will also help us avoid conflicts, as we'll hopefully be converting
the omap-serial driver to runtime PM for this next merge window as well.
Kevin
next prev parent reply other threads:[~2010-11-17 17:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 8:31 [PATCH] OMAP: Serial: Define register access modes in LCR Emeltchenko Andrei
2010-11-17 8:31 ` Emeltchenko Andrei
2010-11-17 9:06 ` Govindraj
2010-11-17 9:06 ` Govindraj
2010-11-17 16:17 ` Greg KH
2010-11-17 17:28 ` Kevin Hilman [this message]
2010-11-17 17:28 ` Kevin Hilman
2010-11-17 17:31 ` Greg KH
2010-11-17 17:31 ` Greg KH
2010-11-17 19:05 ` Tony Lindgren
2010-11-17 19:05 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hbff7tbf.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=greg@kroah.com \
--cc=linux-arm@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.