All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: linux-pm@lists.linux-foundation.org, Pavel Machek <pavel@ucw.cz>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] OMAP: omap3_pm_get_suspend_state() error ignored in pwrdm_suspend_get()
Date: Wed, 16 Dec 2009 09:23:59 -0800	[thread overview]
Message-ID: <87hbrqbzo0.fsf@deeprootsystems.com> (raw)
In-Reply-To: <4B29092C.4040600@gmail.com> (Roel Kluin's message of "Wed\, 16 Dec 2009 17\:22\:04 +0100")

Roel Kluin <roel.kluin@gmail.com> writes:

> val is an u64 pointer, we need an int to check the error.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

Thanks, will queue this in my PM fixes queue for .33-rc series.

Kevin

> ---
> Found using coccinelle: http://coccinelle.lip6.fr/
>
> diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
> index 860b755..081ca85 100644
> --- a/arch/arm/mach-omap2/pm-debug.c
> +++ b/arch/arm/mach-omap2/pm-debug.c
> @@ -488,9 +488,11 @@ int pm_dbg_regset_init(int reg_set)
>  
>  static int pwrdm_suspend_get(void *data, u64 *val)
>  {
> -	*val = omap3_pm_get_suspend_state((struct powerdomain *)data);
> +	int ret;
> +	ret = omap3_pm_get_suspend_state((struct powerdomain *)data);
> +	*val = ret;
>  
> -	if (*val >= 0)
> +	if (ret >= 0)
>  		return 0;
>  	return *val;
>  }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: linux-pm@lists.linux-foundation.org, Pavel Machek <pavel@ucw.cz>,
	"linux-omap\@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] OMAP: omap3_pm_get_suspend_state() error ignored in pwrdm_suspend_get()
Date: Wed, 16 Dec 2009 09:23:59 -0800	[thread overview]
Message-ID: <87hbrqbzo0.fsf@deeprootsystems.com> (raw)
In-Reply-To: <4B29092C.4040600@gmail.com> (Roel Kluin's message of "Wed\, 16 Dec 2009 17\:22\:04 +0100")

Roel Kluin <roel.kluin@gmail.com> writes:

> val is an u64 pointer, we need an int to check the error.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

Thanks, will queue this in my PM fixes queue for .33-rc series.

Kevin

> ---
> Found using coccinelle: http://coccinelle.lip6.fr/
>
> diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
> index 860b755..081ca85 100644
> --- a/arch/arm/mach-omap2/pm-debug.c
> +++ b/arch/arm/mach-omap2/pm-debug.c
> @@ -488,9 +488,11 @@ int pm_dbg_regset_init(int reg_set)
>  
>  static int pwrdm_suspend_get(void *data, u64 *val)
>  {
> -	*val = omap3_pm_get_suspend_state((struct powerdomain *)data);
> +	int ret;
> +	ret = omap3_pm_get_suspend_state((struct powerdomain *)data);
> +	*val = ret;
>  
> -	if (*val >= 0)
> +	if (ret >= 0)
>  		return 0;
>  	return *val;
>  }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

  parent reply	other threads:[~2009-12-16 17:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-16 16:22 [PATCH] OMAP: omap3_pm_get_suspend_state() error ignored in pwrdm_suspend_get() Roel Kluin
2009-12-16 16:22 ` Roel Kluin
2009-12-16 17:23 ` Kevin Hilman
2009-12-16 17:23 ` Kevin Hilman [this message]
2009-12-16 17:23   ` Kevin Hilman
  -- strict thread matches above, loose matches on Subject: below --
2009-12-16 16:22 Roel Kluin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hbrqbzo0.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=pavel@ucw.cz \
    --cc=roel.kluin@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.